From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 114218 invoked by alias); 23 Aug 2016 21:11:45 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 114202 invoked by uid 89); 23 Aug 2016 21:11:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1199, Training, training, late X-HELO: mail-pf0-f196.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=X6qxaNgPMOTtnpwwo6T6lq6vYSjWQNimkpCDTpY2yLY=; b=HVOrVHi83GzU1WY/ZR0yYKHNjdqTaLHHct3HbcNOFqhwlMEq+t6nz8JlHNPIAvkopc 2UbFUgwSJJg54NDJhGGTsc46ANP2haG8VpSBcDvIY1vOm//kq+bKLto4PnQulutdzupI XO7yVcR1w1SShQGM9fvqA5RQw3yUesDcBzXEaamrPvGByJETVXQNVeq7LzuOM3JCw4gT 7ZZYkD8++BLoLoeDhpsO9VGe5nYtO42oCZec2b/9lZTGU+RwSUnojLoFlfcBGCMoveW7 GdBXRBhkxSbeTGUrlhDhIxJBddyE40L3uuplxlYU/FU4m6cbMaKcJ4LSWVS9V0ZWfIPA eEEA== X-Gm-Message-State: AEkoousU6OjQj+fPPlLnkAmNn0Q4KFSi7zCyN7d1+Oiw3RHLkrU3MmSBG+APFyTUIGtO3Q== X-Received: by 10.98.18.221 with SMTP id 90mr57417654pfs.3.1471986693425; Tue, 23 Aug 2016 14:11:33 -0700 (PDT) Subject: Re: [glibc PATCH] fcntl: put F_OFD_* constants under #ifdef __USE_FILE_OFFSET64 To: Cyril Hrubis , Jeff Layton References: <1471461304.3196.101.camel@redhat.com> <1471464343.3196.125.camel@redhat.com> <20160817203746.GF21655@vapier.lan> <1471467478.3196.143.camel@redhat.com> <20160817213522.GG21655@vapier.lan> <1471470526.3196.153.camel@redhat.com> <8e1a972a-7966-139b-9d75-6d3a847a1be8@redhat.com> <20160823110343.GA4962@rei.suse.cz> <1471952179.13027.3.camel@redhat.com> <20160823113830.GB4962@rei.suse.cz> Cc: mtk.manpages@gmail.com, Florian Weimer , Mike Frysinger , libc-alpha@sourceware.org, linux-fsdevel@vger.kernel.org, Carlos O'Donell , Yuriy Kolerov From: "Michael Kerrisk (man-pages)" Message-ID: <8acbfa50-516f-d402-928f-9a391610557d@gmail.com> Date: Tue, 23 Aug 2016 21:11:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160823113830.GB4962@rei.suse.cz> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-08/txt/msg00740.txt.bz2 On 08/23/2016 11:38 PM, Cyril Hrubis wrote: > Hi! >> To be clear, that approach was NAK'ed by Christoph (and I think that's >> a good thing, actually -- one more nail in the non-LFS coffin). I think >> what we want merged into glibc is this patch that I sent late on >> Thursday: >> >> [glibc PATCHv2] fcntl: don't define OFD lock constants for 32-bit builds with small file offsets >> >> We'll also need your patch to the fcntl(2) manpage as well, but that's >> a separate problem. > > Hmm, the patch for man-pages should be updated as well. We need > somethign as: > > ... > This lock type is Linux-specific, and available since Linux 3.15. > On 32bit platform _FILE_OFFSET_BITS must defined to 64 (before including > any header files) to make these locks available. > ... > > Michael should I send updated patch or will you take care of this? I can do it, or you can. At the moment, I'm just holding off until I see what is accepted into glibc. Cheers, Michael -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/