Re: [PATCH 2/3] dlfcn,elf: implement dlmem() and audit [BZ #11767]

[stsp <stsp2@yandex.ru>]

Hi Carlos,

20.02.2023 20:50, Carlos O'Donell пишет:
> * No new LD_AUDIT interfaces reuqired so auditors and developer tooling does
>    not need to be updated.

I dropped LD_AUDIT stuff just as you say.


> My suggestion therefore is to attempt to refactor what you have around an API
> that is like fdlopen(), and see what the implementation and performance looks
> like in glibc.
>
> Thoughts?
Done in a just posted v9.
It has fdlopen() in tst-dlmem-fdlopen.
Its source are also listed below.
I think that impl should go to libbsd,
not into glibc though.
What do you think?

Source:

static void *
fdlopen (int fd, int flags)
{
   off_t len;
   void *addr;
   void *handle;

   len = lseek (fd, 0, SEEK_END);
   lseek (fd, 0, SEEK_SET);
   addr = mmap (NULL, len, PROT_READ, MAP_PRIVATE, fd, 0);
   if (addr == MAP_FAILED)
     {
       printf ("cannot mmap, %s\n", strerror(errno));
       exit (EXIT_FAILURE);
     }
   handle = dlmem (addr, len, flags, NULL);
   munmap (addr, len);
   return handle;
}