From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cockroach.ash.relay.mailchannels.net (cockroach.ash.relay.mailchannels.net [23.83.222.37]) by sourceware.org (Postfix) with ESMTPS id AA92F3858D20 for ; Thu, 25 May 2023 00:59:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AA92F3858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id ECF143C229B; Thu, 25 May 2023 00:59:44 +0000 (UTC) Received: from pdx1-sub0-mail-a305.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 865683C1E38; Thu, 25 May 2023 00:59:44 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1684976384; a=rsa-sha256; cv=none; b=uae0t6NfBVqmeGIsO0B5U+jsy4Sq3n2cVeGqAMKCoh8RzoW22QESJIDcOcPaCERBLQUIrF xLSh/krH4CJDnVqNenSrjyx+So1fZJIQ8AhHgWIzgx07ndAmSUolJ/ddS68igmu1qtU3Ju 5mAYx/pBZSesReUr7OVYj8sLTDkRNCqLw4HMyoOT6zFHVZIprgGqjECIcDFp3mc8gLlShO PqukeZoYx73S1LzAX0PKZPHG2UXBy5ie4ZQMsQT9Wb0tDwWRHmyBWsv4SMnBKTAgNnpi9j Hn9ogS6DeTG7bQvso3zJvqdqSgqxlnGZWkRTMtWetzINY9wXMGZrogZoAzLltQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1684976384; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CBKfrN+LbWkhmRTwHarYEueXCHN/LTP4I55tOWcpjM8=; b=PBPXaC0xQEi00dj9Tvre4FmJ5XXeO6vAxVhbBGmFrCbgarWiPpxJn5ZrgBNAL2yF+wnrl3 f4ABicvP5tMIFpJpWh8+xXC83gkRT5jJ8eKSNo6z2mPe4z3ZXK0JuKgoRJuUhuqJ/MGoU5 rWH4xdw7r7mhdXr3AnJQ3TMQJquv3Dv54wi2M64+m5LH9/zQa1WytVBsgBpVNCB1vv/hIU e72btkANKt3AkcDI96MEz5RdELsscIX5Gpc68c1FCqjp5iiR1aGm12gqhgCHo/uavLCKi6 E9rD+W8UrKdd6ULDnKFXRtaNIH+trrc7aXgKWBXur+WQ0aEhiScPfHy999wk5A== ARC-Authentication-Results: i=1; rspamd-79bb5575d7-lqgwk; auth=pass smtp.auth=dreamhost smtp.mailfrom=siddhesh@gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Bottle-Dime: 4d7a3e7a3f7587e9_1684976384778_4290585612 X-MC-Loop-Signature: 1684976384777:2889948450 X-MC-Ingress-Time: 1684976384777 Received: from pdx1-sub0-mail-a305.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.97.48.120 (trex/6.8.1); Thu, 25 May 2023 00:59:44 +0000 Received: from [192.168.0.182] (bras-vprn-toroon4834w-lp130-02-142-113-138-85.dsl.bell.ca [142.113.138.85]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a305.dreamhost.com (Postfix) with ESMTPSA id 4QRV8011s6zRG; Wed, 24 May 2023 17:59:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gotplt.org; s=dreamhost; t=1684976384; bh=CBKfrN+LbWkhmRTwHarYEueXCHN/LTP4I55tOWcpjM8=; h=Date:Subject:To:From:Content-Type:Content-Transfer-Encoding; b=QLkaNv9xvy8kqGOhYt23TVTM7Laef9+AVjGYabGH1CJqT0Fi2eQnx4jQ97BX74IG0 0W7UuZnkyZhL8bszO5O0raBYz8ZEycXjQQGdbe2OMiWSIjU/zfFOZE7KXyJi44tKbY st9aMQCfrpV/J3XtBqpQNpwKNXyYonV1IkDLzWHcGlVXFgCIrVM3dWGzwv5X1BDEs/ XSKpNRenGGlC9+OI7St4nDuCqHX4HJMZVub7GKnMDB+M9xJUZ0a+HwvYfWNQwJA9kC IKeWG92OWyGjVejdCJQxQAe8K+xkLIGqkhqY7xV3/hjc3zquhQuMgrDI7FwYCu1+E5 JDAuA8KZV/V7A== Message-ID: <8b330666-c118-dc6d-41c6-2b1b8342a233@gotplt.org> Date: Wed, 24 May 2023 20:59:42 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v4 06/15] sysdeps/pthread/eintr.c: fix warn unused result Content-Language: en-US To: =?UTF-8?B?RnLDqWTDqXJpYyBCw6lyYXQ=?= , libc-alpha@sourceware.org References: <20230428122142.928135-1-fberat@redhat.com> <20230428122142.928135-7-fberat@redhat.com> From: Siddhesh Poyarekar In-Reply-To: <20230428122142.928135-7-fberat@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3037.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-04-28 08:21, Frédéric Bérat wrote: > Fix unused result warnings, detected when _FORTIFY_SOURCE is enabled in > glibc. > --- > sysdeps/pthread/eintr.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) LGTM. Reviewed-by: Siddhesh Poyarekar > > diff --git a/sysdeps/pthread/eintr.c b/sysdeps/pthread/eintr.c > index 000649d24e..16191395a7 100644 > --- a/sysdeps/pthread/eintr.c > +++ b/sysdeps/pthread/eintr.c > @@ -31,10 +31,12 @@ eintr_handler (int sig) > { > if (sig != the_sig) > { > - write (STDOUT_FILENO, "eintr_handler: signal number wrong\n", 35); > + /* empty if statement avoids warn unused result */ > + if (write (STDOUT_FILENO, > + "eintr_handler: signal number wrong\n", 35) < 35) {}; > _exit (1); > } > - write (STDOUT_FILENO, ".", 1); > + if (write (STDOUT_FILENO, ".", 1)) {/* Avoid warn unused result */}; > } > >