From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from brown.elm.relay.mailchannels.net (brown.elm.relay.mailchannels.net [23.83.212.23]) by sourceware.org (Postfix) with ESMTPS id 55885385782D for ; Thu, 17 Mar 2022 02:31:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 55885385782D X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id EF4C88018D0; Thu, 17 Mar 2022 02:31:07 +0000 (UTC) Received: from pdx1-sub0-mail-a305.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 05993801A76; Thu, 17 Mar 2022 02:31:07 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1647484267; a=rsa-sha256; cv=none; b=5KvhBCR5RX2Zvi3a0Czwjc+MZYABuIXCv1b0U26FfXe0qQQU43qLBLGq2zL7t/oApBwbnO 4Diif17Pi5uLR0Od5aD14VJkKakYvySQrM1ck8KLUP52zVRczbqs0kx+gJ+qDzbN2sz7HR ikYbh/JHsWogNeKyUSnlT/11+EUcgLFsN+n4tmCYu6kinejYCeLVDdaSExwaJ0tTwvg4yy as/vWsXC2KavKQIUPhWkLmZzvsKmsjTEMQEDuDGnsn4XdHo1YLYZqGy0ViKgXnYrqLwDps G/TflgNWc0l7uFU2ct/jP0n/TvuWZUriO2nZhPZHJKR5qhm478N2uAq+EBwupA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1647484267; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g17yQ2FGsh0n1as+3ipiHxrdVwqafTo236N62Om4k3k=; b=woMMY4aRmjD83GqAKbqo7ssjSzORFkfcS6XSasmh7JTgCn0KNq6Zu53JXwXynUaHc+o23l dxEH8saQ20wdTVaKU3ELcplWxLrMdrRMGZukVRKfzQWkDabAXb6rdP2WtFstRxFRhUaUy2 uPWiYNzF8Fff/eqkU8FrN+npzubbnyT8PQEFCTcNaRIMPKxQDD8uNHCCexokZYXcUvPHcO sg+qs0Vls871UUvoo8ewRz0g9cIb+ofVzDUj+OE7Cq7u6R0iale3+BdUoaWg6mvVeVLFIe /Xj82l2zIJuxwCxW+/jSqIHO6nN5jcbM0Puko7OtujISbkPjelwYJPgrTCwbuA== ARC-Authentication-Results: i=1; rspamd-74bfb75fc6-fgp5v; auth=pass smtp.auth=dreamhost smtp.mailfrom=siddhesh@sourceware.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a305.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.120.38.157 (trex/6.5.3); Thu, 17 Mar 2022 02:31:07 +0000 X-MC-Relay: Junk X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Keen-Interest: 7f12e1442d5fd5e1_1647484267848_991552001 X-MC-Loop-Signature: 1647484267848:3640350618 X-MC-Ingress-Time: 1647484267848 Received: from [192.168.1.174] (unknown [1.186.123.88]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a305.dreamhost.com (Postfix) with ESMTPSA id 4KJrjj4pcnz3b; Wed, 16 Mar 2022 19:31:05 -0700 (PDT) Message-ID: <8bb467a1-5e46-74c0-bb07-b1dbf718acae@sourceware.org> Date: Thu, 17 Mar 2022 08:00:59 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2 03/12] getaddrinfo: Fix leak with AI_ALL [BZ #28852] Content-Language: en-US To: DJ Delorie Cc: libc-alpha@sourceware.org References: From: Siddhesh Poyarekar In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3486.4 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_NONE, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_NONE, RCVD_IN_SBL, SPF_HELO_NONE, SPF_NEUTRAL, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Mar 2022 02:31:10 -0000 On 17/03/2022 05:12, DJ Delorie via Libc-alpha wrote: > Siddhesh Poyarekar via Libc-alpha writes: >> Use realloc in convert_hostent_to_gaih_addrtuple and fix up pointers in >> the result list so that a single block is maintained for >> hostbyname3_r/hostbyname2_r and freed in gaih_inet. This result is >> never merged with any other results, since the hosts database does not >> permit merging. > > It took me a while to realize that you're basically converting the data > structure from a linked list to an array, and ensuring that it's always > handled as an array. That means the comment preceeding > convert_hostent_to_gaih_addrtuple() is no longer accurate and needs > updating. Ideally, the users could be optimized to treat it as an array > instead of a list, but it may need to remain a list-like type for > compatibility. Thanks, I'll update the comment. Thanks, Siddhesh