From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x834.google.com (mail-qt1-x834.google.com [IPv6:2607:f8b0:4864:20::834]) by sourceware.org (Postfix) with ESMTPS id A80D83858D28 for ; Thu, 16 Dec 2021 10:30:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A80D83858D28 Received: by mail-qt1-x834.google.com with SMTP id t11so24943488qtw.3 for ; Thu, 16 Dec 2021 02:30:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=3EV4TjBlbr9QdyaxXp1kgi5df73HlGVUZCPnKEuMUkY=; b=28rEsNsTTVIHpBsXkeVUiXOvsP7XvejFuToqQRAbR3UnoImSw7Q5uFJM7RZsoBCwmW ++wYTxs4/h0lZwy3ZZ2L9Med0JUNWovpMpri7Lym25Xdmv9v50T81JAvcDkJ2F4rHeor iSllK5dEWH0RinIuCUM+5vheRfiZJVsmc1t5MAC/zB421zR0bMYEgTY9cpZ44iA75Gem 8XXYJ5ZnzZCzi4fuNlquFrZ7CaxL6+d/ZunOOvUe3r1Yk99sz1mAJfFFg10cWCfDlEK1 hPKvlljAXL2ptiWUcAQxygb+EwwEXORWJFbe6uNg7AR+SwqbHvh9JSekI4ZTV47oWazY Moqg== X-Gm-Message-State: AOAM530T5c2w0jBtlDu5IEwc/IFQ8P0f0WdKMkC2Mw9eOMhc1RmPS1+s v0tv7ZqSfzCTeFUzXnyOFaU73jck6tGkQw== X-Google-Smtp-Source: ABdhPJx+94aN5woBsiGGvtgJZqW9Dd6RaOEVDiphOUqEAlAs15Dtg3MOM8+qEriPwt6dbbVkWgqvzw== X-Received: by 2002:ac8:5fd6:: with SMTP id k22mr8923614qta.444.1639650619227; Thu, 16 Dec 2021 02:30:19 -0800 (PST) Received: from ?IPV6:2804:431:c7ca:103f:96e9:fe91:2aff:a44d? ([2804:431:c7ca:103f:96e9:fe91:2aff:a44d]) by smtp.gmail.com with ESMTPSA id y15sm2547244qko.74.2021.12.16.02.30.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Dec 2021 02:30:18 -0800 (PST) Message-ID: <8bd97df9-e629-feaf-5028-e20f61fd4001@linaro.org> Date: Thu, 16 Dec 2021 07:30:16 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v3 03/13] or1k: ABI Implementation Content-Language: en-US To: Stafford Horne Cc: Joseph Myers , GLIBC patches , Openrisc References: <20211210233456.4146479-1-shorne@gmail.com> <20211210233456.4146479-4-shorne@gmail.com> <86e61afa-ab95-62e1-10a7-3de71db8deb8@linaro.org> From: Adhemerval Zanella In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Dec 2021 10:30:21 -0000 On 15/12/2021 20:33, Stafford Horne wrote: > > > On Wed, Dec 15, 2021, 10:15 AM Adhemerval Zanella > wrote: > > > > On 14/12/2021 19:43, Joseph Myers wrote: > > On Tue, 14 Dec 2021, Adhemerval Zanella via Libc-alpha wrote: > > > >> +if test "x$profile" != xno; then > >> +  if test "x$with_profile" == xno; then > >> +    AC_MSG_ERROR([ABI does not support profiling]) > > > > Using == in test is a bashism. > > > > I'd expect such a change to require the build-many-glibcs.py configuration > > for OpenRISC to use --disable-profile. > > > > I ended up mixing up things and what or1k does not support is LD_PROFILE > instead of --enable-profile.  In this case I am not sure if it would > be better to just not enable it (by ignoring the LD_PROFILE handling > in rtld.c or dl-support.c) and emitting a warning or by just dumping > and error at process initialization. > > > I checked, new ports like csky and arc also do not seem to support LD_PROFILE.  They choose not to leave a placeholder block in dl-machine.h like I did in or1k. > > I could remove the comment, or replace it with an abort, but I prefer to keep it as it makes it clear where to add the dynamic linker profile hook. I think we should remove the comments, the code might ended up being not updated. LD_PROFILE seems to be not a really used feature, I will try to clean this up by adding an internal option that if the port that does not support we, rtld at least disable all the required code and not start the profile process (like preparing the file, etc).