From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 977BE3858297 for ; Fri, 29 Jul 2022 15:44:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 977BE3858297 Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-483-oADkAaGoMBqjI1wgVertSw-1; Fri, 29 Jul 2022 11:44:07 -0400 X-MC-Unique: oADkAaGoMBqjI1wgVertSw-1 Received: by mail-qk1-f197.google.com with SMTP id y17-20020a05620a25d100b006b66293d75aso3836762qko.17 for ; Fri, 29 Jul 2022 08:44:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=VBnEwYMpW9GWgCbowo30ciSv1gvWNQC3lbJXsBbogpo=; b=CwMEOKdTRgKNdVwPDOAfryAGlBqTo20ijBlW18tPGaecGv2mq21F5lNP3QJRPn+M9w JcShsHfdQ04n5PGQhOIadY9u93hCF34rk2XFt/ooOx9iUVG5GybEsUv0fah54DYP/YQ2 4OGUgv8jSMRFJmHL2WTAp5kaBacNPs7mEfoZ6SCreq5hAJpmqXXLwi1HpgHYHAYN9ZvO g2vvwr9JEInyPXkHopE5e/eNHU3RCJP4ls7bsybc9jG/bqVc1RK8F4ibmU5DvxXRxhf5 E8bWK9RUx9eazBjcNTUjb5K0RTi6OLlkJ+GL1nSdavQjvFgkNL7D4Bo37h9JtzN4dNjE q1Kg== X-Gm-Message-State: AJIora+Se3XyHsd2BG/X6rqkQ61RSm7FHKYehcU3mes2hUmPznj4r6xl wxGx98Y9ORyK/pB8mlKxRkyUvG2qXtHhJfZQz05+audNBmBCDvJ1ggGFBquJYwACLWVn5Wt9xFj iLBOdjeXsK6xbu9m4zaeL X-Received: by 2002:ac8:7dd2:0:b0:31e:f857:a8ab with SMTP id c18-20020ac87dd2000000b0031ef857a8abmr4024498qte.346.1659109447213; Fri, 29 Jul 2022 08:44:07 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sd04WkR+UXQoZFhKZguEZy1Be1JezkCQIYtGYPmTtiboBG0tzHPg668QFB5yONEI3R+lbGEw== X-Received: by 2002:ac8:7dd2:0:b0:31e:f857:a8ab with SMTP id c18-20020ac87dd2000000b0031ef857a8abmr4024484qte.346.1659109447002; Fri, 29 Jul 2022 08:44:07 -0700 (PDT) Received: from [192.168.0.241] (192-0-145-146.cpe.teksavvy.com. [192.0.145.146]) by smtp.gmail.com with ESMTPSA id bm8-20020a05620a198800b006a787380a5csm2758174qkb.67.2022.07.29.08.44.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Jul 2022 08:44:06 -0700 (PDT) Message-ID: <8c2e6f15-c08c-9872-3b53-f514ead5692f@redhat.com> Date: Fri, 29 Jul 2022 11:44:05 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] elf.h: Add ELFCOMPRESS_ZSTD To: Fangrui Song , Adhemerval Zanella Netto , Cary Coutant Cc: Florian Weimer , libc-alpha References: <20220708233233.2554110-1-maskray@google.com> <871qus8cuw.fsf@oldenburg.str.redhat.com> <20220722230837.qea3d33gvji5kxtl@google.com> From: Carlos O'Donell Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jul 2022 15:44:11 -0000 On 7/26/22 16:30, Fangrui Song wrote: > On Tue, Jul 26, 2022 at 1:24 PM Adhemerval Zanella Netto > wrote: >> >> >> >> On 22/07/22 20:08, Fangrui Song via Libc-alpha wrote: >>> On 2022-07-18, Carlos O'Donell via Libc-alpha wrote: >>>> On 7/11/22 00:58, Florian Weimer via Libc-alpha wrote: >>>>> * Fangrui Song via Libc-alpha: >>>>> >>>>>> I wish that the macro definition can catch up the upcoming >>>>>> https://sourceware.org/glibc/wiki/Release/2.36 [1], so that >>>>>> projects can expect the value ELFCOMPRESS_ZSTD from elf.h. >>>>>> The projects may choose to define the macro themselves, >>>>>> but having the definition in an earlier release seems a good idea >>>>>> anyway, and it the glibc definition makes it clearer ELFCOMPRESS_ZSTD >>>>>> is standard and vendors can start adding support. >>>>>> >>>>>> [1]: https://sourceware.org/pipermail/libc-alpha/2022-July/140352.html >>>>>> ("Release of glibc 2.36 in 1 month! Please add blockers and desirable for release.") >>>>> >>>>> This looks quite backportable to me, so it should not be a release >>>>> blocker. It's only a blocker if we apply the patch today, then we'd >>>>> have to wait until the gABI assignment actually happens as expected. >>>> >>>> Agreed. This is a NACK from me as the RM until the gABI assignment happens. >>>> >>> >>> Cary has accepted this value: https://groups.google.com/g/generic-abi/c/satyPkuMisk/m/KwTF_U8rBAAJ >>> (Thanks!) >>> >>> Ed Maste from FreeBSD wants to define this in FreeBSD. >>> >>> Shall we define it for glibc as well? :) >> >> I think this is ok, we are already fixing bad designs so we most likely need >> more time for testing. > > Thanks. Now that it is approved, the commit message can be changed to > the following if you want to push it to the 2.36 release branch. > > elf.h: Add ELFCOMPRESS_ZSTD > > From the approved generic ABI proposal > https://groups.google.com/g/generic-abi/c/satyPkuMisk > ("Add new ch_type value: ELFCOMPRESS_ZSTD"). Cary, Is there a public repo that I can use to cross-check the glibc value with the accepted ELF gABI value? A public repo would make the process of adding matching constants easier because I could review what went into the public repository. Fangrui, Just for clarity, I don't consider this a release blocker for 2.36. -- Cheers, Carlos.