From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85358 invoked by alias); 9 Jul 2019 21:08:33 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 85348 invoked by uid 89); 9 Jul 2019 21:08:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=objective, H*f:sk:87sgrfc X-HELO: mail-qt1-f196.google.com Return-Path: Subject: Re: [PATCH] test-in-container: Install locales into the test container To: Florian Weimer , DJ Delorie Cc: libc-alpha@sourceware.org References: <87sgrfc4n5.fsf@oldenburg2.str.redhat.com> From: Carlos O'Donell Message-ID: <8c64089e-c44c-db20-1a80-562e009d2d42@redhat.com> Date: Tue, 09 Jul 2019 21:08:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <87sgrfc4n5.fsf@oldenburg2.str.redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2019-07/txt/msg00201.txt.bz2 On 7/9/19 4:52 PM, Florian Weimer wrote: > I think applying this patch as-is would make glibc development > substantially more difficult for me. Where do you draw the line? Eventually the testing is going to slow down your edit/build/test cycle. If this is a problem for developers then we need some kind of objective "line" that we try not to cross. Should we have a staggered approach? make check-sanity -- Run as many tests as fit into 10s. -- Run all tests which are not support_become_root, test-in-container, or xcheck tests, since these can be expensive. make check -- No time limit for testing. -- Run all tests which are not xcheck tests. make xhceck -- No time limit for testing. -- Run all tests including xcheck tests. -- Cheers, Carlos.