From: Szabolcs Nagy <Szabolcs.Nagy@arm.com>
To: "马凌(彦军)" <ling.ml@antfin.com>,
libc-alpha <libc-alpha@sourceware.org>,
"Lu, Hongjiu" <hongjiu.lu@intel.com>,
"Xiao, Wei3" <wei3.xiao@intel.com>
Cc: nd <nd@arm.com>, ling.ma.program <ling.ma.program@gmail.com>
Subject: Re: 转发:[PATCH] NUMA spinlock [BZ #23962]
Date: Thu, 03 Jan 2019 14:52:00 -0000 [thread overview]
Message-ID: <8c67f319-31bf-818b-4a89-66d25328026e@arm.com> (raw)
In-Reply-To: <c7f11fea-371e-4453-b5d0-9b142632aecc.ling.ml@antfin.com>
On 03/01/2019 05:35, 马凌(彦军) wrote:
> create mode 100644 manual/examples/numa-spinlock.c
> create mode 100644 sysdeps/unix/sysv/linux/numa-spinlock-private.h
> create mode 100644 sysdeps/unix/sysv/linux/numa-spinlock.c
> create mode 100644 sysdeps/unix/sysv/linux/numa-spinlock.h
> create mode 100644 sysdeps/unix/sysv/linux/numa_spinlock_alloc.c
> create mode 100644 sysdeps/unix/sysv/linux/x86/tst-numa-variable-overhead.c
> create mode 100644 sysdeps/unix/sysv/linux/x86/tst-variable-overhead-skeleton.c
> create mode 100644 sysdeps/unix/sysv/linux/x86/tst-variable-overhead.c
as far as i can tell the new code is generic
(other than the presence of efficient getcpu),
so i think the test should be generic too.
> --- /dev/null
> +++ b/sysdeps/unix/sysv/linux/x86/tst-variable-overhead-skeleton.c
> @@ -0,0 +1,384 @@
...
> +/* Check spinlock overhead with large number threads. Critical region is
> + very smmall. Critical region + spinlock overhead aren't noticeable
> + when number of threads is small. When thread number increases,
> + spinlock overhead become the bottleneck. It shows up in wall time
> + of thread execution. */
yeah, this is not easy to do in a generic way, i think
even on x86 such measurement is problematic, you don't
know what goes on a system (or vm) when the glibc test
is running.
but doing precise timing is not that important for
checking the correctness of the locks, so i think a
simplified version can be generic test code.
next prev parent reply other threads:[~2019-01-03 14:52 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-26 9:51 [PATCH] " Ma Ling
2019-01-03 4:05 ` 马凌(彦军)
[not found] ` <0a474516-b8c8-48cf-aeea-e57c77b78cbd.ling.ml@antfin.com>
2019-01-03 5:35 ` 转发:[PATCH] " 马凌(彦军)
2019-01-03 14:52 ` Szabolcs Nagy [this message]
2019-01-03 19:59 ` H.J. Lu
2019-01-05 12:34 ` [PATCH] " Carlos O'Donell
2019-01-05 16:36 ` H.J. Lu
2019-01-07 19:12 ` Florian Weimer
2019-01-07 19:49 ` H.J. Lu
2019-01-10 16:31 ` Carlos O'Donell
2019-01-10 16:32 ` Florian Weimer
2019-01-10 16:41 ` Carlos O'Donell
2019-01-10 17:52 ` Szabolcs Nagy
2019-01-10 19:24 ` Carlos O'Donell
2019-01-11 12:01 ` kemi
2019-01-14 22:45 ` Torvald Riegel
2019-01-15 9:32 ` Florian Weimer
2019-01-15 12:01 ` Torvald Riegel
2019-01-15 12:17 ` Florian Weimer
2019-01-15 12:31 ` Torvald Riegel
2019-01-11 16:24 ` H.J. Lu
2019-01-14 23:03 ` Torvald Riegel
2019-01-04 4:13 ` 转发:[PATCH] " 马凌(彦军)
2019-01-03 20:43 ` [PATCH] " Rich Felker
2019-01-03 20:55 ` H.J. Lu
2019-01-03 21:21 ` Rich Felker
2019-01-03 21:28 ` H.J. Lu
2019-01-14 23:18 ` Torvald Riegel
2019-01-15 2:33 ` kemi
2019-01-15 12:37 ` Torvald Riegel
2019-01-15 16:44 ` Rich Felker
2019-01-17 3:10 ` kemi
2019-02-04 17:23 ` Torvald Riegel
2019-01-14 22:40 ` Torvald Riegel
2019-01-14 23:26 ` Torvald Riegel
2019-01-15 4:47 ` 马凌(彦军)
2019-01-15 2:56 ` kemi
2019-01-15 4:27 ` 马凌(彦军)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c67f319-31bf-818b-4a89-66d25328026e@arm.com \
--to=szabolcs.nagy@arm.com \
--cc=hongjiu.lu@intel.com \
--cc=libc-alpha@sourceware.org \
--cc=ling.ma.program@gmail.com \
--cc=ling.ml@antfin.com \
--cc=nd@arm.com \
--cc=wei3.xiao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).