[PATCH] locales: et_EE: locale has wrong {p,n}_cs_precedes value

[PATCH] locales: et_EE: locale has wrong {p,n}_cs_precedes value

[Priit Laes]

From: Märt Põder <tramm@p6drad-teel.net>

According to "Requirements of information technology in Estonian
language and cultural environment" [1] the monetary symbol should be
written after the amount number.

Since standards are protected by copyright, I can only safely link to a
draft of this standard at the web site of The Institute of the Estonian
Language [2], which on pages 23-24 describes how to write sums of money
in Estonian. The draft doesn't differ from official standard in this
respect (accordingly pages 26-27). The first four rows of section 4 of
the standard were removed after Estonia joining Euro zone [3], so "EEK"
and "kr" are now obsolete.

Now the part about Euro has three columns, the first one is about
"international" usage and second two describe the "local" uses of word
"euro" and sign "€". Although international usage is also documented
there, you shouldn't be misguided by that, since this is not the one you
would use in normal Estonian, but only when representing Euro in
banking/international context. The second and the third column show that
currency symbol has to be written after the amount number.

So I am suggesting that localedata for et_EE should be fixed to follow
current official standard EVS 8: 2008.

You can confirm my interpretation by looking at the usage of the Euro in
all three referred forms ("EUR", "euro", "€") documented in Estonian
Wikipedia entry about the currency [4] or one of the receipts issued by
any business entity big enough to pay attention at proper grammar.
However, Unicode Consortium's CLDR project might be even more
authoritative reference and has several confirming examples of the use.
[5]

[1] https://www.evs.ee/products/evs-8-2008
[2] http://www.eki.ee/itstandard/2008/EVS8_2006_kavand.doc
[3] https://www.evs.ee/products/evs-8-2008-ac-2011
[4] https://et.wikipedia.org/wiki/Euro#Vahetuskursid
[5] http://demo.icu-project.org/icu-bin/locexp?d_=en&_=et_EE
---
 localedata/ChangeLog     | 5 +++++
 localedata/locales/et_EE | 4 ++--
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/localedata/ChangeLog b/localedata/ChangeLog
index 9aedf51..0a23d2c 100644
--- a/localedata/ChangeLog
+++ b/localedata/ChangeLog
@@ -1,3 +1,8 @@
+2016-08-11  Priit Laes  <plaes@plaes.org>
+
+	[BZ #20459]
+	* locales/et_EE: Fix {n,p}_cs_precedes. Pointed out by Märt Põder.
+
 2016-08-10  Martin Pitt  <martin.pitt@ubuntu.com>
 
 	[BZ #9842]
diff --git a/localedata/locales/et_EE b/localedata/locales/et_EE
index 096cdd5..83115c6 100644
--- a/localedata/locales/et_EE
+++ b/localedata/locales/et_EE
@@ -2141,9 +2141,9 @@ positive_sign       ""
 negative_sign       "<U002D>"
 int_frac_digits     2
 frac_digits         2
-p_cs_precedes       1
+p_cs_precedes       0
 p_sep_by_space      1
-n_cs_precedes       1
+n_cs_precedes       0
 n_sep_by_space      1
 p_sign_posn         1
 n_sign_posn         1
-- 
2.9.2

Re: [PATCH] locales: et_EE: locale has wrong {p,n}_cs_precedes value

[Marko Myllynen]

Hi,

On 2016-08-11 18:13, Priit Laes wrote:
> From: Märt Põder <tramm@p6drad-teel.net>
> 
> According to "Requirements of information technology in Estonian
> language and cultural environment" [1] the monetary symbol should be
> written after the amount number.
> 
> Since standards are protected by copyright, I can only safely link to a
> draft of this standard at the web site of The Institute of the Estonian
> Language [2], which on pages 23-24 describes how to write sums of money
> in Estonian. The draft doesn't differ from official standard in this
> respect (accordingly pages 26-27). The first four rows of section 4 of
> the standard were removed after Estonia joining Euro zone [3], so "EEK"
> and "kr" are now obsolete.
> 
> Now the part about Euro has three columns, the first one is about
> "international" usage and second two describe the "local" uses of word
> "euro" and sign "€". Although international usage is also documented
> there, you shouldn't be misguided by that, since this is not the one you
> would use in normal Estonian, but only when representing Euro in
> banking/international context. The second and the third column show that
> currency symbol has to be written after the amount number.
> 
> So I am suggesting that localedata for et_EE should be fixed to follow
> current official standard EVS 8: 2008.
> 
> You can confirm my interpretation by looking at the usage of the Euro in
> all three referred forms ("EUR", "euro", "€") documented in Estonian
> Wikipedia entry about the currency [4] or one of the receipts issued by
> any business entity big enough to pay attention at proper grammar.
> However, Unicode Consortium's CLDR project might be even more
> authoritative reference and has several confirming examples of the use.
> [5]
> 
> [1] https://www.evs.ee/products/evs-8-2008
> [2] http://www.eki.ee/itstandard/2008/EVS8_2006_kavand.doc
> [3] https://www.evs.ee/products/evs-8-2008-ac-2011
> [4] https://et.wikipedia.org/wiki/Euro#Vahetuskursid
> [5] http://demo.icu-project.org/icu-bin/locexp?d_=en&_=et_EE
> ---
>  localedata/ChangeLog     | 5 +++++
>  localedata/locales/et_EE | 4 ++--
>  2 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/localedata/ChangeLog b/localedata/ChangeLog
> index 9aedf51..0a23d2c 100644
> --- a/localedata/ChangeLog
> +++ b/localedata/ChangeLog
> @@ -1,3 +1,8 @@
> +2016-08-11  Priit Laes  <plaes@plaes.org>
> +
> +	[BZ #20459]
> +	* locales/et_EE: Fix {n,p}_cs_precedes. Pointed out by Märt Põder.
> +
>  2016-08-10  Martin Pitt  <martin.pitt@ubuntu.com>
>  
>  	[BZ #9842]
> diff --git a/localedata/locales/et_EE b/localedata/locales/et_EE
> index 096cdd5..83115c6 100644
> --- a/localedata/locales/et_EE
> +++ b/localedata/locales/et_EE
> @@ -2141,9 +2141,9 @@ positive_sign       ""
>  negative_sign       "<U002D>"
>  int_frac_digits     2
>  frac_digits         2
> -p_cs_precedes       1
> +p_cs_precedes       0
>  p_sep_by_space      1
> -n_cs_precedes       1
> +n_cs_precedes       0
>  n_sep_by_space      1
>  p_sign_posn         1
>  n_sign_posn         1

Makes sense / looks good to me.

Thanks,

-- 
Marko Myllynen

Re: [PATCH] locales: et_EE: locale has wrong {p,n}_cs_precedes value

[Florian Weimer]

On 08/11/2016 05:13 PM, Priit Laes wrote:
> From: Märt Põder <tramm@p6drad-teel.net>
>
> According to "Requirements of information technology in Estonian
> language and cultural environment" [1] the monetary symbol should be
> written after the amount number.

Did you or Märt write this patch?

Thanks,
Florian

Re: [PATCH] locales: et_EE: locale has wrong {p,n}_cs_precedes value

[Märt Põder]

[-- Attachment #1: Type: text/plain, Size: 531 bytes --]

On Mon, 15 Aug 2016 12:11:45 +0200 Florian Weimer <fweimer@redhat.com> wrote:

> Did you or Märt write this patch?

Actually, this is an old hack [1] I invented for Estonian remaster of Ubuntu that I used to work with. Since Priit already had history with the locale data project, forwarding the patch to him seemed to smoothest way to get it to upstream.

Märt Põder

[1] http://bazaar.launchpad.net/~estobuntu/estobuntu/trunk/view/head:/remaster/libraries/customization-profiles/localized_cd/customize.estobuntu#L777

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] locales: et_EE: locale has wrong {p,n}_cs_precedes value

[Florian Weimer]

On 08/15/2016 01:13 PM, Märt Põder wrote:
> On Mon, 15 Aug 2016 12:11:45 +0200 Florian Weimer <fweimer@redhat.com> wrote:
>
>> Did you or Märt write this patch?
>
> Actually, this is an old hack [1] I invented for Estonian remaster of Ubuntu that I used to work with. Since Priit already had history with the locale data project, forwarding the patch to him seemed to smoothest way to get it to upstream.

Thanks, I have committed this, attributed to you.

Florian