From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-74334-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 19436 invoked by alias); 2 Nov 2016 20:55:39 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 19400 invoked by uid 89); 2 Nov 2016 20:55:38 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM autolearn=no version=3.3.2 spammy=H*MI:sk:1478116
X-HELO: mail-qk0-f177.google.com
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:subject:to:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding;
        bh=66DvMhrzxM3qjF+NSiA31mOYOhWuc8DNDiMDRn0bF4w=;
        b=l59qOdA3jZe3VVcU9m/eZCUtX1Og4GHYqZyujQlVKQEd54QAcdj3NJv89C1wP4uu3G
         xSI+ywiBR4/Gdf1fAoCGHgQsOE4GzOLte/PIbQmW1KeYOaBL1UWZ5f2AwDrjPFDntRiB
         CZ1EzmgqCet5Y6vW9giBWboP6gRkdx5ZYNE08czdFzFFr2JYg5JoF/jaT8B3JNR4avMi
         2wv7Sg+UMeRrqUMl6xYLl9FDErVmnuydkc6pa2gHhNP1aHAbRiUbYrsnMa7GWT465pfR
         y/k7bYZMBxDAMGSn690J8HLUcpQ30VtudOSCwbEWbRoX+tUH0pv+PH/2Q+1VuB4Dhc/m
         L2XQ==
X-Gm-Message-State: ABUngveoIjSyWBTelLOSz1GQ+k7Ih7JbDthw0O5ku2+lxRhP/ZkaRZRUDi+w38ztrsMVtuKV
X-Received: by 10.55.90.194 with SMTP id o185mr4731489qkb.219.1478120133011;
        Wed, 02 Nov 2016 13:55:33 -0700 (PDT)
Subject: Re: [PATCH] Fix -Wformat-length warning in time/tst-strptime2.c
To: Steve Ellcey <sellcey@caviumnetworks.com>, libc-alpha@sourceware.org
References: <1477326501.8523.51.camel@caviumnetworks.com>
 <1478116026.2891.53.camel@caviumnetworks.com>
From: Carlos O'Donell <carlos@redhat.com>
Message-ID: <8cd86260-3ce5-dfa8-477c-f2981b29ac3d@redhat.com>
Date: Wed, 02 Nov 2016 20:55:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <1478116026.2891.53.camel@caviumnetworks.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2016-11/txt/msg00087.txt.bz2

On 11/02/2016 03:47 PM, Steve Ellcey wrote:
> Here is an updated version of my earlier patch, I hadn't tested the
> original one with an old GCC so I hadn't realized I needed to put the
> DIAG_IGNORE_NEEDS_COMMENT in an ifdef.  This version was tested with
> GCC 5.4 and GCC 7.0 with no regressions.
> 
> I also double checked that the test program is deliberately using
> snprintf to truncate the output so changing the test by increasing the
> buffer size and avoiding the warnings that way would change what was
> being tested.
> 
> OK to checkin?

LGTM.

c.