From: Xi Ruoyao <xry111@xry111.site>
To: libc-alpha@sourceware.org
Cc: caiyinyu <caiyinyu@loongson.cn>,
Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>,
Joseph Myers <joseph@codesourcery.com>,
Wang Xuerui <i.swmail@xen0n.name>
Subject: Re: [PATCH] LoongArch: Fix dl-machine.h code formatting
Date: Sat, 20 Aug 2022 16:43:22 +0800 [thread overview]
Message-ID: <8ce256e286c01177b8082543ea5cd9064805b4be.camel@xry111.site> (raw)
In-Reply-To: <f37d8223fb1875aefa4c74e54afd7a86ebfc1e7f.camel@xry111.site>
Discarded. My mail client was not configured properly. Will resend.
On Sat, 2022-08-20 at 16:40 +0800, Xi Ruoyao wrote:
> The case labels with conditional operator is bad formatted (they seem
> caused by a bug of clang-format). Fix them manually.
>
> No functional change.
>
> Signed-off-by: Xi Ruoyao <xry111@xry111.site>
> ---
> sysdeps/loongarch/dl-machine.h | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/sysdeps/loongarch/dl-machine.h b/sysdeps/loongarch/dl-
> machine.h
> index c69c72d0ff..c5286041c0 100644
> --- a/sysdeps/loongarch/dl-machine.h
> +++ b/sysdeps/loongarch/dl-machine.h
> @@ -166,8 +166,7 @@ elf_machine_rela (struct link_map *map, struct
> r_scope_elem *scope[],
> {
>
> case R_LARCH_JUMP_SLOT:
> - case __WORDSIZE == 64 ? R_LARCH_64:
> - R_LARCH_32:
> + case __WORDSIZE == 64 ? R_LARCH_64 : R_LARCH_32:
> *addr_field = value;
> break;
>
> @@ -175,18 +174,15 @@ elf_machine_rela (struct link_map *map, struct
> r_scope_elem *scope[],
> break;
>
> #ifndef RTLD_BOOTSTRAP
> - case __WORDSIZE == 64 ? R_LARCH_TLS_DTPMOD64:
> - R_LARCH_TLS_DTPMOD32:
> + case __WORDSIZE == 64 ? R_LARCH_TLS_DTPMOD64 :
> R_LARCH_TLS_DTPMOD32:
> *addr_field = sym_map->l_tls_modid;
> break;
>
> - case __WORDSIZE == 64 ? R_LARCH_TLS_DTPREL64:
> - R_LARCH_TLS_DTPREL32:
> + case __WORDSIZE == 64 ? R_LARCH_TLS_DTPREL64 :
> R_LARCH_TLS_DTPREL32:
> *addr_field = TLS_DTPREL_VALUE (sym) + reloc->r_addend;
> break;
>
> - case __WORDSIZE == 64 ? R_LARCH_TLS_TPREL64:
> - R_LARCH_TLS_TPREL32:
> + case __WORDSIZE == 64 ? R_LARCH_TLS_TPREL64 :
> R_LARCH_TLS_TPREL32:
> CHECK_STATIC_TLS (map, sym_map);
> *addr_field = TLS_TPREL_VALUE (sym_map, sym) + reloc->r_addend;
> break;
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
prev parent reply other threads:[~2022-08-20 8:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-20 8:40 Xi Ruoyao
2022-08-20 8:43 ` Xi Ruoyao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ce256e286c01177b8082543ea5cd9064805b4be.camel@xry111.site \
--to=xry111@xry111.site \
--cc=adhemerval.zanella@linaro.org \
--cc=caiyinyu@loongson.cn \
--cc=i.swmail@xen0n.name \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).