* [patch, nios2, committed] Delete sysdeps/unix/sysv/linux/nios2/kernel-features.h
@ 2020-05-04 13:43 Chung-Lin Tang
2020-05-04 13:52 ` Adhemerval Zanella
0 siblings, 1 reply; 3+ messages in thread
From: Chung-Lin Tang @ 2020-05-04 13:43 UTC (permalink / raw)
To: Carroll, Paul, GNU C Library
[-- Attachment #1: Type: text/plain, Size: 276 bytes --]
In commit 06436acf819d9e6ada7be3ca977d5c0a23d3f138, a kernel-features.h
file for nios2 was created to undef __ASSUME_SYSVIPC_DEFAULT_IPC_64,
which was wrong for Nios II.
This patch removes the file again. Fixed on master and 2.31, credits to Paul Carroll.
Thanks,
Chung-Lin
[-- Attachment #2: 0001-nios2-delete-sysdeps-unix-sysv-linux-nios2-kernel-fe.patch --]
[-- Type: text/plain, Size: 1851 bytes --]
From 38c67888183db1b6ac21f2f9681b8a384987dfe8 Mon Sep 17 00:00:00 2001
From: Chung-Lin Tang <cltang@codesourcery.com>
Date: Mon, 4 May 2020 20:23:25 +0800
Subject: [PATCH] nios2: delete sysdeps/unix/sysv/linux/nios2/kernel-features.h
Commit 06436acf819d9e6ada7be3ca977d5c0a23d3f138 created a kernel-features.h
file with '#undef __ASSUME_SYSVIPC_DEFAULT_IPC_64', which is wrong for Nios II.
Deleting the header.
---
.../unix/sysv/linux/nios2/kernel-features.h | 22 -------------------
1 file changed, 22 deletions(-)
delete mode 100644 sysdeps/unix/sysv/linux/nios2/kernel-features.h
diff --git a/sysdeps/unix/sysv/linux/nios2/kernel-features.h b/sysdeps/unix/sysv/linux/nios2/kernel-features.h
deleted file mode 100644
index d68d114981..0000000000
--- a/sysdeps/unix/sysv/linux/nios2/kernel-features.h
+++ /dev/null
@@ -1,22 +0,0 @@
-/* Set flags signalling availability of kernel features based on given
- kernel version number. NIOS2 version.
- Copyright (C) 2019-2020 Free Software Foundation, Inc.
- This file is part of the GNU C Library.
-
- The GNU C Library is free software; you can redistribute it and/or
- modify it under the terms of the GNU Lesser General Public
- License as published by the Free Software Foundation; either
- version 2.1 of the License, or (at your option) any later version.
-
- The GNU C Library is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- Lesser General Public License for more details.
-
- You should have received a copy of the GNU Lesser General Public
- License along with the GNU C Library; if not, see
- <https://www.gnu.org/licenses/>. */
-
-#include_next <kernel-features.h>
-
-#undef __ASSUME_SYSVIPC_DEFAULT_IPC_64
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch, nios2, committed] Delete sysdeps/unix/sysv/linux/nios2/kernel-features.h
2020-05-04 13:43 [patch, nios2, committed] Delete sysdeps/unix/sysv/linux/nios2/kernel-features.h Chung-Lin Tang
@ 2020-05-04 13:52 ` Adhemerval Zanella
2020-05-05 10:20 ` Chung-Lin Tang
0 siblings, 1 reply; 3+ messages in thread
From: Adhemerval Zanella @ 2020-05-04 13:52 UTC (permalink / raw)
To: libc-alpha
On 04/05/2020 10:43, Chung-Lin Tang wrote:
> In commit 06436acf819d9e6ada7be3ca977d5c0a23d3f138, a kernel-features.h
> file for nios2 was created to undef __ASSUME_SYSVIPC_DEFAULT_IPC_64,
> which was wrong for Nios II.
>
> This patch removes the file again. Fixed on master and 2.31, credits to Paul Carroll.
>
> Thanks,
> Chung-Lin
LGTM, thanks.
As a side note, is there an easy way to get a qemu system for nios2 to check
for such regressions (an system emulation would be better to rule out qemu
user issue)?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch, nios2, committed] Delete sysdeps/unix/sysv/linux/nios2/kernel-features.h
2020-05-04 13:52 ` Adhemerval Zanella
@ 2020-05-05 10:20 ` Chung-Lin Tang
0 siblings, 0 replies; 3+ messages in thread
From: Chung-Lin Tang @ 2020-05-05 10:20 UTC (permalink / raw)
To: Adhemerval Zanella, libc-alpha
On 2020/5/4 9:52 PM, Adhemerval Zanella via Libc-alpha wrote:
>
>
> On 04/05/2020 10:43, Chung-Lin Tang wrote:
>> In commit 06436acf819d9e6ada7be3ca977d5c0a23d3f138, a kernel-features.h
>> file for nios2 was created to undef __ASSUME_SYSVIPC_DEFAULT_IPC_64,
>> which was wrong for Nios II.
>>
>> This patch removes the file again. Fixed on master and 2.31, credits to Paul Carroll.
>>
>> Thanks,
>> Chung-Lin
>
> LGTM, thanks.
>
> As a side note, is there an easy way to get a qemu system for nios2 to check
> for such regressions (an system emulation would be better to rule out qemu
> user issue)?
>
We've been doing testing using hardware so far. A QEMU setup is something that's nice
to have, but still TBD here.
Thanks,
Chung-Lin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-05 10:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-04 13:43 [patch, nios2, committed] Delete sysdeps/unix/sysv/linux/nios2/kernel-features.h Chung-Lin Tang
2020-05-04 13:52 ` Adhemerval Zanella
2020-05-05 10:20 ` Chung-Lin Tang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).