From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-0010f301.pphosted.com (mx0a-0010f301.pphosted.com [148.163.149.254]) by sourceware.org (Postfix) with ESMTPS id D16873858408 for ; Tue, 4 Jan 2022 17:13:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D16873858408 Received: from pps.filterd (m0102857.ppops.net [127.0.0.1]) by mx0b-0010f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 204A91uL023366; Tue, 4 Jan 2022 11:13:20 -0600 Received: from mx4.mail.rice.edu (mx4.mail.rice.edu [128.42.199.101]) by mx0b-0010f301.pphosted.com (PPS) with ESMTPS id 3dbxdksgaf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 04 Jan 2022 11:13:20 -0600 Received: from mx4.mail.rice.edu (localhost [127.0.0.1]) by mx4.mail.rice.edu (Postfix) with ESMTP id DA464433A82; Tue, 4 Jan 2022 11:13:19 -0600 (CST) Received: from localhost (localhost [127.0.0.1]) by mx4.mail.rice.edu (Postfix) with ESMTP id D8867424642; Tue, 4 Jan 2022 11:13:19 -0600 (CST) X-Virus-Scanned: by amavis-2.12.1 at mx4.mail.rice.edu, auth channel Received: from mx4.mail.rice.edu ([127.0.0.1]) by localhost (mx4.mail.rice.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id CGPdHbgpdJBw; Tue, 4 Jan 2022 11:13:11 -0600 (CST) Received: from [73.32.6.9] (c-73-32-6-9.hsd1.tx.comcast.net [73.32.6.9]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: jma14) by mx4.mail.rice.edu (Postfix) with ESMTPSA id 17D27209DE2; Tue, 4 Jan 2022 11:13:11 -0600 (CST) Message-ID: <8d3fbd30-324f-6a7a-df3e-e6743a3f48e9@rice.edu> Date: Tue, 4 Jan 2022 11:13:10 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH v9 1/4] elf: Add la_activity during application exit Content-Language: en-US To: Adhemerval Zanella , libc-alpha@sourceware.org Cc: John Mellor-Crummey , Ben Woodard References: <20220103132530.1149542-1-adhemerval.zanella@linaro.org> <20220103132530.1149542-2-adhemerval.zanella@linaro.org> From: Jonathon Anderson In-Reply-To: <20220103132530.1149542-2-adhemerval.zanella@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: HsZr35_e2bETPWq-I-NVq8fTSGvKErdn X-Proofpoint-ORIG-GUID: HsZr35_e2bETPWq-I-NVq8fTSGvKErdn X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-01-04_08,2022-01-04_01,2021-12-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 suspectscore=0 mlxscore=0 phishscore=0 spamscore=0 bulkscore=0 mlxlogscore=607 clxscore=1015 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2201040116 X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Jan 2022 17:13:26 -0000 On 1/3/22 07:25, Adhemerval Zanella wrote: > + /* The cookie identifies the object at the head of the link map, > + so we only add a new namespace if it changes from previous > + one. This work since dlmopen is the last in the test body. */ Very minor nit: this comment seems to belong on the second conditional, rather than the first. > + if (cookie != last_act_cookie && last_act_cookie != -1) > + TEST_COMPARE (last_act, LA_ACT_CONSISTENT); > + > + if (this_act == LA_ACT_ADD && acts[nacts - 1] != cookie) > + { > + acts[nacts++] = cookie; > + last_act_cookie = cookie; > + } Otherwise LGTM. Thanks for taking the time to work on this patch! -Jonathon