From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v4 3/3] csu: Implement and use _dl_early_allocate during static startup
Date: Mon, 9 May 2022 14:37:03 -0300 [thread overview]
Message-ID: <8d91b95b-aa00-f588-3087-52295334ab30@linaro.org> (raw)
In-Reply-To: <87sfpi8whb.fsf@oldenburg.str.redhat.com>
On 09/05/2022 14:08, Florian Weimer wrote:
> * Adhemerval Zanella:
>
>> The idea is to allow __mmap64 use the mmap64_call and have the syscall
>> logic in one place. Something like:
>>
>> void *
>> __mmap64 (void *addr, size_t len, int prot, int flags, int fd, off64_t offset)
>> {
>> MMAP_CHECK_PAGE_UNIT ();
>>
>> if (offset & MMAP_OFF_MASK)
>> return (void *) INLINE_SYSCALL_ERROR_RETURN_VALUE (EINVAL);
>>
>> MMAP_PREPARE (addr, len, prot, flags, fd, offset);
>> return mmap64_call (addr, len, prot, flags, fd, offset);
>> }
>
> With this, a definition of mmap64_call still needs a working definition
> of MMAP2_PAGE_UNIT for mmap2 targets, I think.
We can add the MMAP2_PAGE_UNIT as an additional argument for mmap64_call
and use a valid but unused value, I think compiler would see than using 0
as offset argument and optimize the division away.
next prev parent reply other threads:[~2022-05-09 17:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 15:06 [PATCH v4 1/3] ia64: Always define IA64_USE_NEW_STUB as a flag macro Florian Weimer
2022-05-05 15:07 ` [PATCH v4 2/3] Linux: Implement a useful version of _startup_fatal Florian Weimer
2022-05-05 15:28 ` Andreas Schwab
2022-05-05 15:43 ` Florian Weimer
2022-05-05 17:29 ` Adhemerval Zanella
2022-05-05 15:08 ` [PATCH v4 3/3] csu: Implement and use _dl_early_allocate during static startup Florian Weimer
2022-05-05 17:48 ` Adhemerval Zanella
2022-05-05 18:03 ` Florian Weimer
2022-05-05 18:25 ` Adhemerval Zanella
2022-05-06 10:00 ` Florian Weimer
2022-05-06 13:04 ` Adhemerval Zanella
2022-05-06 13:19 ` Adhemerval Zanella
2022-05-09 16:10 ` Florian Weimer
2022-05-09 16:52 ` Adhemerval Zanella
2022-05-09 17:08 ` Florian Weimer
2022-05-09 17:37 ` Adhemerval Zanella [this message]
2022-05-05 17:28 ` [PATCH v4 1/3] ia64: Always define IA64_USE_NEW_STUB as a flag macro Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d91b95b-aa00-f588-3087-52295334ab30@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).