* [PATCH] scripts/test-installation.pl: Ignore nss_test* DSOs [BZ #21911]
@ 2017-08-10 12:25 Florian Weimer
2017-10-05 10:54 ` Florian Weimer
2017-10-07 10:52 ` Rical Jasan
0 siblings, 2 replies; 4+ messages in thread
From: Florian Weimer @ 2017-08-10 12:25 UTC (permalink / raw)
To: libc-alpha
2017-08-10 Florian Weimer <fweimer@redhat.com>
[BZ #21911]
* scripts/test-installation.pl: Ignore nss_test* DSOs.
diff --git a/scripts/test-installation.pl b/scripts/test-installation.pl
index c5b9fdefd2..4b0e9f3c4a 100755
--- a/scripts/test-installation.pl
+++ b/scripts/test-installation.pl
@@ -124,7 +124,7 @@ while (<SOVERSIONS>) {
next if ($build_mathvec == 0 && $name eq "mvec");
if ($name ne "nss_ldap" && $name ne "db1"
&& !($name =~/^nss1_/) && $name ne "thread_db"
- && $name ne "nss_test1" && $name ne "libgcc_s") {
+ && $name !~ /^nss_test\d+/ && $name ne "libgcc_s") {
$link_libs .= " -l$name";
$versions{$name} = $version;
}
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scripts/test-installation.pl: Ignore nss_test* DSOs [BZ #21911]
2017-08-10 12:25 [PATCH] scripts/test-installation.pl: Ignore nss_test* DSOs [BZ #21911] Florian Weimer
@ 2017-10-05 10:54 ` Florian Weimer
2017-10-07 10:52 ` Rical Jasan
1 sibling, 0 replies; 4+ messages in thread
From: Florian Weimer @ 2017-10-05 10:54 UTC (permalink / raw)
To: libc-alpha; +Cc: DJ Delorie
On 08/10/2017 02:24 PM, Florian Weimer wrote:
> 2017-08-10 Florian Weimer<fweimer@redhat.com>
>
> [BZ #21911]
> * scripts/test-installation.pl: Ignore nss_test* DSOs.
Ping?
<https://sourceware.org/ml/libc-alpha/2017-08/msg00390.html>
Thanks,
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scripts/test-installation.pl: Ignore nss_test* DSOs [BZ #21911]
2017-08-10 12:25 [PATCH] scripts/test-installation.pl: Ignore nss_test* DSOs [BZ #21911] Florian Weimer
2017-10-05 10:54 ` Florian Weimer
@ 2017-10-07 10:52 ` Rical Jasan
2017-10-10 9:26 ` Florian Weimer
1 sibling, 1 reply; 4+ messages in thread
From: Rical Jasan @ 2017-10-07 10:52 UTC (permalink / raw)
To: Florian Weimer; +Cc: libc-alpha
On 08/10/2017 05:24 AM, Florian Weimer wrote:
> 2017-08-10 Florian Weimer <fweimer@redhat.com>
>
> [BZ #21911]
> * scripts/test-installation.pl: Ignore nss_test* DSOs.
>
> diff --git a/scripts/test-installation.pl b/scripts/test-installation.pl
> index c5b9fdefd2..4b0e9f3c4a 100755
> --- a/scripts/test-installation.pl
> +++ b/scripts/test-installation.pl
> @@ -124,7 +124,7 @@ while (<SOVERSIONS>) {
> next if ($build_mathvec == 0 && $name eq "mvec");
> if ($name ne "nss_ldap" && $name ne "db1"
> && !($name =~/^nss1_/) && $name ne "thread_db"
> - && $name ne "nss_test1" && $name ne "libgcc_s") {
> + && $name !~ /^nss_test\d+/ && $name ne "libgcc_s") {
> $link_libs .= " -l$name";
> $versions{$name} = $version;
> }
An anchor would more closely preserve the test (i.e.,
"/^nss_test\d+$/"), and avoid matches like "nss_test9 garb @ g3".
Rical
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scripts/test-installation.pl: Ignore nss_test* DSOs [BZ #21911]
2017-10-07 10:52 ` Rical Jasan
@ 2017-10-10 9:26 ` Florian Weimer
0 siblings, 0 replies; 4+ messages in thread
From: Florian Weimer @ 2017-10-10 9:26 UTC (permalink / raw)
To: Rical Jasan; +Cc: libc-alpha
[-- Attachment #1: Type: text/plain, Size: 1007 bytes --]
On 10/07/2017 12:55 PM, Rical Jasan wrote:
> On 08/10/2017 05:24 AM, Florian Weimer wrote:
>> 2017-08-10 Florian Weimer <fweimer@redhat.com>
>>
>> [BZ #21911]
>> * scripts/test-installation.pl: Ignore nss_test* DSOs.
>>
>> diff --git a/scripts/test-installation.pl b/scripts/test-installation.pl
>> index c5b9fdefd2..4b0e9f3c4a 100755
>> --- a/scripts/test-installation.pl
>> +++ b/scripts/test-installation.pl
>> @@ -124,7 +124,7 @@ while (<SOVERSIONS>) {
>> next if ($build_mathvec == 0 && $name eq "mvec");
>> if ($name ne "nss_ldap" && $name ne "db1"
>> && !($name =~/^nss1_/) && $name ne "thread_db"
>> - && $name ne "nss_test1" && $name ne "libgcc_s") {
>> + && $name !~ /^nss_test\d+/ && $name ne "libgcc_s") {
>> $link_libs .= " -l$name";
>> $versions{$name} = $version;
>> }
>
> An anchor would more closely preserve the test (i.e.,
> "/^nss_test\d+$/"), and avoid matches like "nss_test9 garb @ g3".
Good point. Updated patch attached.
Thanks,
Florian
[-- Attachment #2: bug21911.patch --]
[-- Type: text/x-patch, Size: 655 bytes --]
2017-10-10 Florian Weimer <fweimer@redhat.com>
[BZ #21911]
* scripts/test-installation.pl: Ignore nss_test* DSOs.
diff --git a/scripts/test-installation.pl b/scripts/test-installation.pl
index 45c666b0a2..74d25e1c8d 100755
--- a/scripts/test-installation.pl
+++ b/scripts/test-installation.pl
@@ -123,7 +123,7 @@ while (<SOVERSIONS>) {
next if ($build_mathvec == 0 && $name eq "mvec");
if ($name ne "nss_ldap" && $name ne "db1"
&& $name ne "thread_db"
- && $name ne "nss_test1" && $name ne "libgcc_s") {
+ && $name !~ /^nss_test\d+$/ && $name ne "libgcc_s") {
$link_libs .= " -l$name";
$versions{$name} = $version;
}
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-10-10 9:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-10 12:25 [PATCH] scripts/test-installation.pl: Ignore nss_test* DSOs [BZ #21911] Florian Weimer
2017-10-05 10:54 ` Florian Weimer
2017-10-07 10:52 ` Rical Jasan
2017-10-10 9:26 ` Florian Weimer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).