Re: [RFC v3 2/3] sys/types.h: struct timespec: Use __snseconds_t for tv_nsec

["Alejandro Colomar (man-pages)" <alx.manpages@gmail.com>]

On 12/8/21 15:53, Zack Weinberg wrote:
> On Wed, Dec 8, 2021, at 9:47 AM, Alejandro Colomar wrote:
>>
>> Use __snseconds_t to simplify the definition of struct timespec.
> ...
>>   #if __WORDSIZE == 64 \
>>     || (defined __SYSCALL_WORDSIZE && __SYSCALL_WORDSIZE == 64) \
>>     || (__TIMESIZE == 32 && !defined __USE_TIME_BITS64)
>> -  __syscall_slong_t tv_nsec;	/* Nanoseconds.  */
>> +  __snseconds_t tv_nsec;  /* Nanoseconds.  */
> 
> All my grousing about spec bugs aside, the _point_ of having tv_nsec's type be a typedef is that it ought to be possible to make this preprocessor conditional (and the rest of the cases in the same if-else chain) less hairy.  Can you look into that please?

Yes, that's what I'd like to achieve in the end too.  However, I first 
wanted to make sure that I get the definition of snseconds_t right.  I'd 
remove those ifdefs in a 4th patch (definitely in a separate patch from 
this one changing the type), so that each one is clearly understandable.

Can you please confirm if this change by itself is correct for all cases?

Thanks,
Alex


-- 
Alejandro Colomar
Linux man-pages maintainer; https://www.kernel.org/doc/man-pages/