From: Vineet Gupta <vineet.gupta1@synopsys.com>
To: Andreas Schwab <schwab@suse.de>
Cc: Adhemerval Zanella <adhemerval.zanella@linaro.org>,
<libc-alpha@sourceware.org>, <linux-snps-arc@lists.infradead.org>
Subject: Need for arch pthread-offsets.h (was Re: [PATCH v2 05/15] ARC: Atomics and Locking primitives)
Date: Fri, 01 Feb 2019 01:59:00 -0000 [thread overview]
Message-ID: <8e025bb4-d86d-ba54-f937-3ae73870a71f@synopsys.com> (raw)
In-Reply-To: <b7766cd4-3055-3e3b-f49b-fe870fee2740@synopsys.com>
On 1/30/19 9:40 AM, Vineet Gupta wrote:
> On 1/30/19 12:28 AM, Andreas Schwab wrote:
>> On Jan 29 2019, Vineet Gupta <vineet.gupta1@synopsys.com> wrote:
>>
>>> +#define __PTHREAD_MUTEX_NUSERS_AFTER_KIND 1
>>> +#define __PTHREAD_MUTEX_USE_UNION 1
>> New ports should use the preferred values for these macros.
>
> OK, changed to 0 and 0 per commit 06be6368da16104 ("nptl: Define
> __PTHREAD_MUTEX_{NUSERS_AFTER_KIND,USE_UNION}")
So this required a bunch of tricking changes to _SIZEOF_PTHREAD_*.
However what was not obvious is adjustment to
sysdeps/<arch>/nptl/pthread-offsets.h to __PTHREAD_MUTEX_*_OFFSET. But these don't
seem to be *actually* used anywhere. Sure there are assert checks in
pthread_mutext_init.c but what's the point: the struct is generic anyways. IOW I'm
not sure what port specific errors/inconsistency they are catching, other than the
fact that they need to be hand calculating when starting a new port.
Am I missing something ?
next prev parent reply other threads:[~2019-02-01 1:59 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 1:28 [PATCH v2 00/15] glibc port to ARC processors Vineet Gupta
2019-01-30 1:27 ` [PATCH v2 15/15] make-syscalls.sh: fix comment referencing syscall-template Vineet Gupta
2019-01-30 2:20 ` Joseph Myers
2019-01-30 1:27 ` [PATCH v2 06/15] ARC: math soft float support Vineet Gupta
2019-01-30 1:27 ` [PATCH v2 03/15] ARC: startup and dynamic linking code Vineet Gupta
2019-01-30 1:27 ` [PATCH v2 07/15] ARC: Linux Syscall Interface Vineet Gupta
2019-01-30 1:27 ` [PATCH v2 02/15] ARC: ABI Implementation Vineet Gupta
2019-01-30 1:27 ` [PATCH v2 10/15] ARC: ABI lists Vineet Gupta
2019-01-30 1:27 ` [PATCH v2 11/15] ARC: Update syscall-names.list for ARC specific syscalls Vineet Gupta
2019-01-30 1:27 ` [PATCH v2 12/15] ARC: Build Infrastructure Vineet Gupta
2019-01-30 1:28 ` [PATCH v2 08/15] ARC: Linux ABI Vineet Gupta
2019-01-30 1:28 ` [PATCH v2 01/15] ARC: add definitions to elf/elf.h Vineet Gupta
2019-01-30 1:28 ` [PATCH v2 09/15] ARC: Linux Startup and Dynamic Loading Vineet Gupta
2019-01-30 1:33 ` [PATCH v2 14/15] NEWS: mention ARC port Vineet Gupta
2019-01-30 1:33 ` [PATCH v2 13/15] build-many-glibcs.py: Enable ARC builds Vineet Gupta
2019-01-30 1:33 ` [PATCH v2 04/15] ARC: Thread Local Storage support Vineet Gupta
2019-01-30 1:33 ` [PATCH v2 05/15] ARC: Atomics and Locking primitives Vineet Gupta
2019-01-30 8:29 ` Andreas Schwab
2019-01-30 17:42 ` Vineet Gupta
2019-02-01 1:59 ` Vineet Gupta [this message]
2019-02-04 10:03 ` Need for arch pthread-offsets.h (was Re: [PATCH v2 05/15] ARC: Atomics and Locking primitives) Andreas Schwab
2019-01-30 21:04 ` [PATCH v2 05/15] ARC: Atomics and Locking primitives Joseph Myers
2019-01-30 21:37 ` Vineet Gupta
2019-01-30 21:50 ` Joseph Myers
2019-01-30 22:02 ` Vineet Gupta
2019-01-30 22:05 ` Joseph Myers
2019-01-30 2:30 ` [PATCH v2 00/15] glibc port to ARC processors Joseph Myers
2019-01-30 18:16 ` Vineet Gupta
2019-01-30 21:19 ` Joseph Myers
2020-01-17 20:07 ` ARCv2 Public PRM (was Re: [PATCH v2 00/15] glibc port to ARC processors) Vineet Gupta
2020-01-17 22:04 ` Joseph Myers
2020-02-06 17:19 ` Vineet Gupta
2020-02-06 21:51 ` Joseph Myers
2020-02-06 22:14 ` Alistair Francis
2020-02-06 22:42 ` Vineet Gupta
2020-02-09 12:27 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e025bb4-d86d-ba54-f937-3ae73870a71f@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).