From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x32e.google.com (mail-ot1-x32e.google.com [IPv6:2607:f8b0:4864:20::32e]) by sourceware.org (Postfix) with ESMTPS id 3626D3858416 for ; Mon, 17 Jan 2022 18:13:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3626D3858416 Received: by mail-ot1-x32e.google.com with SMTP id t4-20020a05683022e400b00591aaf48277so20866647otc.13 for ; Mon, 17 Jan 2022 10:13:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=P8D/rVQt41l5RKRNBKL/m3Vvid+D12hv0NWuhDdjitc=; b=NDBzYIRAOcjWsJNi7VpW1Q+4IBOQ8AYc0TdklCSXkWR+vVzr83a39w9qWKjjjsOo73 lbpqYy6mr4O3q2NQx3NNiTJezJAm4ray5+S80BbQAB8h+zrJYBQ6TO9kMXc7bUAsBKM9 NVMWCh6yNqs64zyxMCboTHoQg37wiQlJYcArxvcr2MCIMk7x5CzEqW6FUKvl8bL7Fbyo WnnnyijZvU8YetibYjjwW0sBCJlpnfsrmsjsNUreeR0Uu0BD2sPmXKtS2DEXlopj2fz2 jgJRa1Vmk5mKfUrwAMzN6aTcEIHIPOFplfBQPQpbxvqFooY9V/p9o03BHuu/9AZs9QYu TgDA== X-Gm-Message-State: AOAM531/LHwkUYhUBC13C95MbOjV5Wns286MqJzqVzRvG3oGUv5vB4m9 N0JehuQ3ukOn0nv0L50bHznWlwwDU85gMg== X-Google-Smtp-Source: ABdhPJzZetd8lwXJT7tO3aNE56F/amJ7vs5p84Px8Cp4N6QrKoIW2jmSmXToh5fDxjPBHuCvklCs3g== X-Received: by 2002:a9d:60f:: with SMTP id 15mr16364845otn.266.1642443191554; Mon, 17 Jan 2022 10:13:11 -0800 (PST) Received: from ?IPV6:2804:431:c7cb:989a:152:78c4:5eab:b8b5? ([2804:431:c7cb:989a:152:78c4:5eab:b8b5]) by smtp.gmail.com with ESMTPSA id bb8sm6748680oib.9.2022.01.17.10.13.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Jan 2022 10:13:11 -0800 (PST) Message-ID: <8e9ecb8d-65f3-3ea2-b0ce-f0cf50aca3ac@linaro.org> Date: Mon, 17 Jan 2022 15:13:09 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: Missing audit17 test Content-Language: en-US To: Samuel Thibault , libc-alpha@sourceware.org References: <20220115154522.33x4yyfklglvzsng@begin> From: Adhemerval Zanella In-Reply-To: <20220115154522.33x4yyfklglvzsng@begin> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Jan 2022 18:13:16 -0000 On 15/01/2022 12:45, Samuel Thibault via Libc-alpha wrote: > Hello, > > 9926f6e2eeb3 ("elf: Skip tst-auditlogmod-* if the linker doesn't support > --depaudit [BZ #28 151]") happened to be dropping tst-audit17: Good catch, I will reinstate it. > > diff --git a/elf/Makefile b/elf/Makefile > index 725537c40b..9f3fadc37e 100644 > --- a/elf/Makefile > +++ b/elf/Makefile > @@ -219,7 +219,6 @@ tests += restest1 preloadtest loadfail multiload origtest resolvfail \ > tst-dlopen-self tst-auditmany tst-initfinilazyfail tst-dlopenfail \ > tst-dlopenfail-2 \ > tst-filterobj tst-filterobj-dlopen tst-auxobj tst-auxobj-dlopen \ > - tst-audit14 tst-audit15 tst-audit16 tst-audit17 \ > tst-single_threaded tst-single_threaded-pthread \ > tst-tls-ie tst-tls-ie-dlmopen argv0test \ > tst-glibc-hwcaps tst-glibc-hwcaps-prepend tst-glibc-hwcaps-mask \ > @@ -238,6 +237,9 @@ selinux-enabled := $(shell cat /selinux/enforce 2> /dev/null) > ifneq ($(selinux-enabled),1) > tests-execstack-yes = tst-execstack tst-execstack-needed tst-execstack-prog > endif > +ifeq ($(have-depaudit),yes) > +tests += tst-audit14 tst-audit15 tst-audit16 > +endif > endif > tests += $(tests-execstack-$(have-z-execstack)) > ifeq ($(run-built-tests),yes) > > was that expected? > > Samuel