From: Carlos O'Donell <carlos@redhat.com>
To: Wilco Dijkstra <Wilco.Dijkstra@arm.com>,
'GNU C Library' <libc-alpha@sourceware.org>
Cc: nd <nd@arm.com>, Florian Weimer <fweimer@redhat.com>
Subject: Re: [PATCH] Add malloc micro benchmark
Date: Thu, 28 Feb 2019 04:52:00 -0000 [thread overview]
Message-ID: <8ef46134-94fa-ffba-8f98-13a10a956e7b@redhat.com> (raw)
In-Reply-To: <DB5PR08MB1030A3EB64DA81DB604E140183920@DB5PR08MB1030.eurprd08.prod.outlook.com>
On 2/1/19 11:27 AM, Wilco Dijkstra wrote:
> Add a malloc micro benchmark to enable accurate testing of the
> various paths in malloc and free. The benchmark does a varying
> number of allocations of a given block size, then frees them again.
>
> It tests 3 different scenarios: single-threaded using main arena,
> multi-threaded using thread-arena, main arena with SINGLE_THREAD_P
> false.
>
> OK for commit?
>
> ChangeLog:
> 2019-02-01 Wilco Dijkstra <wdijkstr@arm.com>
>
> * benchtests/Makefile: Add malloc-simple benchmark.
> * benchtests/bench-malloc-simple.c: New benchmark.
This broke Fedora Rawhide during CI testing:
BUILDSTDERR: bench-malloc-simple.c: In function 'bench':
BUILDSTDERR: bench-malloc-simple.c:89:17: error: variable 'res' set but not used [-Werror=unused-but-set-variable]
BUILDSTDERR: 89 | unsigned long res;
BUILDSTDERR: | ^~~
BUILDSTDERR: cc1: all warnings being treated as errors
Affects aarch64, armv7hl, and s390x.
I assume we need a "(void) res" like we have in bench-malloc-thread.c?
I'm going to checkin a quick fix to Rawhide and report back if anything
else breaks.
--
Cheers,
Carlos.
next prev parent reply other threads:[~2019-02-28 4:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-01 16:27 Wilco Dijkstra
2019-02-08 19:34 ` DJ Delorie
2019-02-14 16:39 ` Wilco Dijkstra
2019-02-14 20:42 ` DJ Delorie
2019-02-28 4:52 ` Carlos O'Donell [this message]
2019-03-04 17:35 ` Wilco Dijkstra
2019-03-18 17:16 ` Wilco Dijkstra
2019-04-09 5:27 ` Carlos O'Donell
-- strict thread matches above, loose matches on Subject: below --
2017-12-01 13:51 Wilco Dijkstra
2017-12-01 16:13 ` Carlos O'Donell
2017-12-18 15:18 ` Wilco Dijkstra
2017-12-18 16:33 ` Carlos O'Donell
2017-12-18 23:02 ` DJ Delorie
2017-12-28 14:09 ` Wilco Dijkstra
2017-12-28 19:01 ` DJ Delorie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ef46134-94fa-ffba-8f98-13a10a956e7b@redhat.com \
--to=carlos@redhat.com \
--cc=Wilco.Dijkstra@arm.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).