From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bird.elm.relay.mailchannels.net (bird.elm.relay.mailchannels.net [23.83.212.17]) by sourceware.org (Postfix) with ESMTPS id A4CC13858C2C for ; Thu, 25 May 2023 12:25:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A4CC13858C2C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id EF433541613; Thu, 25 May 2023 12:25:38 +0000 (UTC) Received: from pdx1-sub0-mail-a306.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 7F54C541647; Thu, 25 May 2023 12:25:38 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1685017538; a=rsa-sha256; cv=none; b=VhgQ0lBEX6Xjv6eLasKHNOF5sSD1sFhG4YEcdbMPPcwnu9xlTBFnf6nTPMbfAhlf1gf+q6 zGfIo6KCRFJjKm1wCXvD7WaLR4SrErnfH0AmH3tUwrg06g4dMRjrp/A0/EJYmwkxheaAKf aG6JN3JkwxmCkt07n+/HyUtPrnf0+/uxr55cxQOzeYh+HJ6jRfWvKWAvcsfLODXuJ0MOdq Fw1qHYFhPYt1yLqI4R9XGYsmMVL0mhtbgXoi8/MVDsTRI1Tbw8x3A0gh+3ZsOP7voyl8VD aWVrYfxK+wpAsudV/oRYyw3tkKXkqrbnhRsqr4Tz37w27d8Wqn8q7BkAu5fJxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1685017538; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5XNUOM04HBFQmd3S12nEc3dmkC87XSa/UFoYcXzF9HE=; b=zk2kmNG0x95wEyidT9MprHEXq3f1Q3uVj50LHURiEIpQNgEN303AUImiDaR2gOs0ytvaJk DVKXLTG0lCo7FZqqSnwD5D1QR26lSRzTstH0906D6HJLS/16jx7R3QJB5S+wk3CGrVEO4D QnY9cQI4FPJemT1slPOXZlztLO3oNKwjIp2/+JahT9JgnNrCiOx9lqi3DBxDwIdj4N75yC TrXp2JcCgkAbtC4MCqET5obwj3zEBlzaEGvj2ZJtL/kNpm2P9wzyuWxxStWKJpxSEMyRyd k8TxT9rYoG7OVu/aYpKGa7kbHWawFSzfe+da4DsFJ3CrEnhFbWPWkAAlpkLeqQ== ARC-Authentication-Results: i=1; rspamd-5cdf8fd7d9-fw8rh; auth=pass smtp.auth=dreamhost smtp.mailfrom=siddhesh@gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Plucky-Wipe: 54e29c126d27f2a2_1685017538762_2324835763 X-MC-Loop-Signature: 1685017538762:331446695 X-MC-Ingress-Time: 1685017538762 Received: from pdx1-sub0-mail-a306.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.103.24.74 (trex/6.8.1); Thu, 25 May 2023 12:25:38 +0000 Received: from [192.168.0.182] (bras-vprn-toroon4834w-lp130-02-142-113-138-85.dsl.bell.ca [142.113.138.85]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a306.dreamhost.com (Postfix) with ESMTPSA id 4QRnMQ006Bz8k; Thu, 25 May 2023 05:25:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gotplt.org; s=dreamhost; t=1685017538; bh=5XNUOM04HBFQmd3S12nEc3dmkC87XSa/UFoYcXzF9HE=; h=Date:Subject:To:Cc:From:Content-Type:Content-Transfer-Encoding; b=GSctx7rEj4cOdFo+nQtkfXTjPROkquqZNQEyNBKZy4aotMcv08YnIXLqzpyHmaykv kOkonq41zkITXQKqrjqROhgCv2/AAnqtMjkGe+aAwVE+D+eOWIFHaZKZPb64BKOjjv QSfFoC7LIycIJOMEGX9s3mdXbtI3gnpfpNh0UDtQ8ez/dF8CBzCt2EVcxmCUdT99HP xAHD7MrpcZtgyeaUakFZoLFHDi5xFK+ehpGP9zS+MHdMhVRi0N5VXuSbbiQyO/dcO8 SSmSt5RBDTV9UJ055Ftqj6XkJjomZA1ALRjsum2HaZuZvsKFGycQvXOClw/DgdfdBH LiGE1YeMCZlDw== Message-ID: <8efcede8-fe0f-351b-3376-617a2292d9b5@gotplt.org> Date: Thu, 25 May 2023 08:25:36 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] setipv4sourcefilter: Avoid using alloca. Content-Language: en-US To: Adhemerval Zanella Netto , Florian Weimer Cc: Joe Simmons-Talbott , libc-alpha@sourceware.org References: <20230524181831.41099-1-josimmon@redhat.com> <5a4468f7-d72e-d252-88bf-0c17e349299c@gotplt.org> <87o7m8q30e.fsf@oldenburg.str.redhat.com> <87bki8lkgt.fsf@oldenburg.str.redhat.com> <341f8301-7259-6102-22d7-6c03e88594b7@gotplt.org> From: Siddhesh Poyarekar In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3031.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-05-25 08:20, Adhemerval Zanella Netto wrote: >>>> We already save/restore errno on free since 69fda43b8dd795c.  We can optimize >>>> it a bit by adding munmap/mprotect that calls INTERNAL_SYSCALL_CALL, but I >>>> am not sure if the complexity will really be worth here. >>> >>> Ah, right, then scratch_buffer_free should be okay, too. >> >> I guess, but should we still stick to preserving errno to account for lack of errno preservation in non-glibc malloc implementations? > > I don't think it is worth, this requirement will be in the next POSIX [1] and > it also means that we will need to propagate this assumption on all internal > glibc code (which is only boilerplate code in the end). > > [1] https://www.austingroupbugs.net/view.php?id=385 In that case, LGTM. Reviewed-by: Siddhesh Poyarekar