From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cyan.elm.relay.mailchannels.net (cyan.elm.relay.mailchannels.net [23.83.212.47]) by sourceware.org (Postfix) with ESMTPS id A05BB3838005 for ; Mon, 28 Jun 2021 04:18:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A05BB3838005 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 4820D22C6F for ; Mon, 28 Jun 2021 04:18:20 +0000 (UTC) Received: from pdx1-sub0-mail-a39.g.dreamhost.com (100-98-55-130.trex-nlb.outbound.svc.cluster.local [100.98.55.130]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id D8C5C22BA2 for ; Mon, 28 Jun 2021 04:18:19 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a39.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384) by 100.98.55.130 (trex/6.3.3); Mon, 28 Jun 2021 04:18:20 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Gusty-Wipe: 6b73e45f686c8b49_1624853900092_3167857721 X-MC-Loop-Signature: 1624853900092:3005386509 X-MC-Ingress-Time: 1624853900092 Received: from pdx1-sub0-mail-a39.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a39.g.dreamhost.com (Postfix) with ESMTP id 9B2FF7F455 for ; Sun, 27 Jun 2021 21:18:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gotplt.org; h=subject:to :references:from:message-id:date:mime-version:in-reply-to :content-type:content-transfer-encoding; s=gotplt.org; bh=cQt1uD qdI4dJJVNPwCk5Ly9mXOg=; b=lk/YAHuzqHwD36t4Ripn5GuX+ZnkJh8vQ1Bh87 tLID8080BYuLxB3GsP2LAG1qRi9YmNMVA1wGOdd97tHFRl+uIunXScZuDTHAH3my WCbAHYsjdbBwkTTumNyxtwNMwjAeULtrMKoHtQOW3sT6ctL/wUt6KWZdTKXcg5/8 3e6WI= Received: from [192.168.1.136] (unknown [1.186.101.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a39.g.dreamhost.com (Postfix) with ESMTPSA id C39167F453 for ; Sun, 27 Jun 2021 21:18:18 -0700 (PDT) Subject: [PING][PATCH] Move tst-resolv-res_init-multi to xtests To: libc-alpha@sourceware.org References: <20210622044449.4091104-1-siddhesh@sourceware.org> X-DH-BACKEND: pdx1-sub0-mail-a39 From: Siddhesh Poyarekar Message-ID: <8f314a1d-85a3-b987-4d08-ecb87054ecdb@gotplt.org> Date: Mon, 28 Jun 2021 09:48:13 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210622044449.4091104-1-siddhesh@sourceware.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3037.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jun 2021 04:18:23 -0000 Hi, any objections to this move? Siddhesh On 6/22/21 10:14 AM, Siddhesh Poyarekar via Libc-alpha wrote: > Tests that need network access may cause false failures due to network > glitches because of which they are typically added as xtests. See for > example posix/tst-getaddrinfo{4,5}.c. Move tst-resolv-res_init-multi > also to xtests so that it is not executed in a regular test run. > --- > resolv/Makefile | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/resolv/Makefile b/resolv/Makefile > index 3fbc320ee1..3e17fda571 100644 > --- a/resolv/Makefile > +++ b/resolv/Makefile > @@ -57,7 +57,6 @@ tests += \ > tst-resolv-edns \ > tst-resolv-network \ > tst-resolv-nondecimal \ > - tst-resolv-res_init-multi \ > tst-resolv-search \ > tst-resolv-trailing \ > > @@ -103,6 +102,9 @@ xtests += tst-resolv-qtypes > > # This test has dropped packet tests and runs for a long time. > xtests += tst-resolv-rotate > + > +# This test needs a functioning network to succeed. > +xtests += tst-resolv-res_init-multi > endif > extra-libs-others = $(extra-libs) > libresolv-routines := res_comp res_debug \ >