From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) by sourceware.org (Postfix) with ESMTPS id AA1C63954468 for ; Tue, 13 Apr 2021 20:47:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AA1C63954468 Received: by mail-qt1-x830.google.com with SMTP id y12so13841019qtx.11 for ; Tue, 13 Apr 2021 13:47:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/5y3k7C/n32DVizmlJKTrT1J1y80eeBR5fAQp2SA4qs=; b=QLdwI0hcsexUhLmH77+nWx+ZLTjLM4vPdPiLnY3kHuqHtSh7o7oW0c/dp55bKX+bqB L4mBnx3qgR7vJ7vXKQJPx4PavzLeS1fcrGXeAylgDBc6w2H9sv02SIB+uoGmthkcobxU BTjCfVMnHyhaCQWLYaXPUytmc7LTq6znziAQPoA8nBo3b5TPmSl8GophFNaS5FgSw8BZ 5X3+qbe0Q8h30KiCJ/ekj++1jMVUh5v2Sa5MIEAlmRCZxvC9MABI/hmm7dsL10hccdV6 DSe28BLAFo4YB51ACW0zuAIrkIuhIKLt4TE8xEA0lYQTAKRuwnH86dCnaa8E4E4HQcR7 uQ1w== X-Gm-Message-State: AOAM531gjLwXlLeEPRXGsjiesAmKg70Fd2Vqsylu2qJMIQt978UPDBKD pOJi0PC9UAr/IMxbiZxmfnSa3FtryRnWZg7B X-Google-Smtp-Source: ABdhPJwWTq00i1RHIxaGiesb7Fymzen2Y7+jTa4jB5yKQ/768VVdjgpVgujJTek6H6YMxgJH1c8AGg== X-Received: by 2002:ac8:4d43:: with SMTP id x3mr33694795qtv.326.1618346842076; Tue, 13 Apr 2021 13:47:22 -0700 (PDT) Received: from [192.168.1.132] ([177.194.41.149]) by smtp.gmail.com with ESMTPSA id o189sm1739386qka.86.2021.04.13.13.47.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Apr 2021 13:47:21 -0700 (PDT) Subject: Re: [PATCH] linux: sysconf: limit _SC_MAX_ARG to 6 MiB [BZ #25305] To: Michal Nazarewicz , Andreas Schwab Cc: libc-alpha@sourceware.org References: <20210407151058.1176364-1-mina86@mina86.com> <46c3ea60-7a57-14f7-92f9-e915e3b12dae@linaro.org> <87im4qe61s.fsf@igel.home> <05wsjeil807oxrv57bk8g2i3@mina86.com> From: Adhemerval Zanella Message-ID: <8f7a6c09-713c-68b6-c629-044537fc7779@linaro.org> Date: Tue, 13 Apr 2021 17:47:19 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <05wsjeil807oxrv57bk8g2i3@mina86.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Apr 2021 20:47:28 -0000 On 13/04/2021 16:57, Michal Nazarewicz wrote: >> On 13/04/2021 09:13, Andreas Schwab wrote: >>> In addition, I'd give it a symbolic name with a comment. > > On Tue, Apr 13 2021, Adhemerval Zanella wrote: >> What about: >> >> diff --git a/sysdeps/unix/sysv/linux/sysconf.c b/sysdeps/unix/sysv/linux/sysconf.c >> index 366fcef01e..aceedfa87c 100644 >> --- a/sysdeps/unix/sysv/linux/sysconf.c >> +++ b/sysdeps/unix/sysv/linux/sysconf.c >> @@ -33,6 +33,9 @@ >> actual value varies based on the stack size. */ >> #define legacy_ARG_MAX 131072 >> >> +/* Newer kernels (4.13) limit the maximum command line arguments lengths to >> + 6MiB. */ >> +#define maximum_ARG_MAX 6291456 > > I’d still go with (6 * 1024 * 1024). Otherwise looks good to me. Ok, I fixed it upstream (I forgot to do it when I pushed it earlier).