From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [IPv6:2607:f8b0:4864:20::72b]) by sourceware.org (Postfix) with ESMTPS id 9CC8F388A81A for ; Fri, 28 May 2021 16:59:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9CC8F388A81A Received: by mail-qk1-x72b.google.com with SMTP id i5so4732499qkf.12 for ; Fri, 28 May 2021 09:59:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=dCqMYx7EFdxKDlohqwESnoN1VA3ZaXCQ9zP7/mnCR4g=; b=azf6mupQCbz00UKkVOkl387gPyWFpB2A50b3PxqsT4juNeap9V51IgqxxMZM5L8zet FIIBn2RCntZDH+jjiHuyBXRkoHfgXEN6ojDRLmOJFVIx5g1vCFXC5sPUskk7FE+DrAmm PLJTFKQAv9sBmILXN1d6C456s7S+5krQEX1e6nmDKJ8YMe4ZpcDpFk0J5Y8sXe+QTTG7 IdReZFZSYIGgZvWyB8l2lx1SLpYWYj9AnHHzCp7jXbcpmdu8dLLzCR4F6FaGRziopy3k H+jh6tJ33jI9dqV0GKqm3l9vJ/02L7jEB8ptziSn7/6WdMC20f0sYJ0H/U/XV8NbKGQQ EOjQ== X-Gm-Message-State: AOAM532ofzEWW0bz/QHVm5zSyTz5rk0d1Pxp+0lW2mwQ52AqE+ornH15 j2JfnHqdTofeRY23wJ+FfVcHn26GUKogkg== X-Google-Smtp-Source: ABdhPJxZ0nt/LxXfRYkGXMw9vo/3zW2YKSWFQZnYKn2p+DcD46UzHQ8J0a4FRXswA/lokaTxXUSoDA== X-Received: by 2002:a05:620a:127b:: with SMTP id b27mr4751736qkl.104.1622221181884; Fri, 28 May 2021 09:59:41 -0700 (PDT) Received: from [192.168.1.4] ([177.194.59.218]) by smtp.gmail.com with ESMTPSA id x18sm3741307qkx.118.2021.05.28.09.59.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 May 2021 09:59:41 -0700 (PDT) Subject: Re: [RFC][PATCH v10 4/7] Add DT_GNU_FLAGS_1/DF_GNU_1_UNIQUE to glibc DSOs (bug 22745) From: Adhemerval Zanella To: Vivek Das Mohapatra , libc-alpha@sourceware.org References: <20210322154111.24798-1-vivek@collabora.com> <20210322154111.24798-5-vivek@collabora.com> Message-ID: <8f7df6eb-951d-0b56-c90a-cc305c218589@linaro.org> Date: Fri, 28 May 2021 13:59:39 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 May 2021 16:59:44 -0000 > On 22/03/2021 12:41, Vivek Das Mohapatra via Libc-alpha wrote: >> @@ -636,6 +637,17 @@ build-shlib-objlist = $(build-module-helper-objlist) \ >> # Also omits crti.o and crtn.o, which we do not want >> # since we define our own `.init' section specially. >> LDFLAGS-c.so = -nostdlib -nostartfiles >> + >> +# The stub dynamic-notes.os should not have weak/undefined symbol magic in it. >> +# It's not really part of the internals, rather it is a vector for linker magic >> +# which we need when the linker isn't new enough: >> +%/dynamic-notes.os: CPPFLAGS += -UMODULE_NAME Although it seems correct to built it without defining MODULE_NAME, I wonder if there is a simpler way to define as MODULE_NAME=nonlib (it seems be more correct than not defining any module name). >> +%/dynamic-notes.os: dynamic-notes.c I think this is not really required.