From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x22d.google.com (mail-oi1-x22d.google.com [IPv6:2607:f8b0:4864:20::22d]) by sourceware.org (Postfix) with ESMTPS id 889C73851ABD for ; Wed, 8 Mar 2023 11:48:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 889C73851ABD Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oi1-x22d.google.com with SMTP id bj30so11931724oib.6 for ; Wed, 08 Mar 2023 03:48:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678276133; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=gEoiyxGoweBZ7iZYb8+c9U3h8aygohusnhcP0v9Ln8I=; b=zxBB9xEP9wFpTdkyFAFG4Uq7Td5EDYYQYD4SWM6lq2r1zPel5e2yplYab7Mm8TKSWf Nnmi/0QT+qFmSXELYM51qzpgQSbtLxHzZrMDaLd55SUlwS2/S5PofP4Y908UnHotpytq aMVTkI+UPHZf6hNBTnE0yiIc+ZWcdFYdk4k214FDpEypJDCyREYhNYWqXa74dkn6Effd qyFuMpRmYkdIOoZVropaO3nQ4CHfvQtujWoLPWZTWgHzlGOUBX3EQvDdYlcRUZoz6Hhk FAuOy+yfuTRTqHmb+SA2/LpKY6qu80cObRMeAmb4wmPojra2leheWjhNY+GIooI5arX2 MoDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678276133; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gEoiyxGoweBZ7iZYb8+c9U3h8aygohusnhcP0v9Ln8I=; b=OFHGSBh3WJp7yHd7F7Nm4EOIA+f7hJ7WgLWshjrEgC0qrRA0OeAMHCLJxPiJLp/ev0 scVgVVVPdAQgiJSPkLUM5ZIgjX2XFkbkqfFQvDzEGE7e8AoxnDSURVd/RTXF1QVYimy1 12q/ZbNJcPJgOlMk8CDasdqEmjerUmrWWLWv2+nk8BE7wpxzvNinKN+QJr10Bwo+KP/H 61SV6IeG+wsq0Nnb3dKtWwAESKdE6i+E0/teRSUrMK3QAY5XcuFHLEDfII4IQvXMoxQa xo9dET+V5OUayhDN64wumRqmx0vQk1qDdTi4Sa47Lexp3+6t3ShMuNRibSCQ8mRSqoBJ 9qcA== X-Gm-Message-State: AO0yUKUZj7Cliq37hQfQyTzy3CBZoX2NCoXUZKzUFe+BKHp2YJINp6i+ paErKkg2iIwtSrrurMva5W0L6Q== X-Google-Smtp-Source: AK7set+nSSBUYO4OJWFwddfDo7YVvlfE7vJtPYtzIxJpx5Fb0eHTXIjuoO4UdTCDFWF0CnphghSD7g== X-Received: by 2002:aca:6504:0:b0:37f:ac0a:f4d5 with SMTP id m4-20020aca6504000000b0037fac0af4d5mr8600872oim.3.1678276133574; Wed, 08 Mar 2023 03:48:53 -0800 (PST) Received: from ?IPV6:2804:1b3:a7c0:544b:655d:5559:758d:90f7? ([2804:1b3:a7c0:544b:655d:5559:758d:90f7]) by smtp.gmail.com with ESMTPSA id r64-20020acac143000000b0037834b1a20bsm6303260oif.0.2023.03.08.03.48.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Mar 2023 03:48:52 -0800 (PST) Message-ID: <90023151-aafa-c2e6-0666-3b5d98db3e06@linaro.org> Date: Wed, 8 Mar 2023 08:48:49 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] hurd: fix build of tst-system.c To: Adam Yi , libc-alpha@sourceware.org Cc: joseph@codesourcery.com, i@adamyi.com References: Content-Language: en-US From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 08/03/23 05:11, Adam Yi wrote: > We made tst-system.c depend on pthread, but that requires linking with > $(shared-thread-library). It does not fail under Linux because the > variable expands to nothing under Linux, but it fails for Hurd. > > I tested verified via cross-compiling that "make check" now works > for Hurd. > > Signed-off-by: Adam Yi LGTM, thanks. Reviewed-by: Adhemerval Zanella > --- > stdlib/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/stdlib/Makefile b/stdlib/Makefile > index cd32f53b56..5e38f0e6a2 100644 > --- a/stdlib/Makefile > +++ b/stdlib/Makefile > @@ -281,6 +281,7 @@ LDLIBS-test-on_exit-race = $(shared-thread-library) > LDLIBS-tst-canon-bz26341 = $(shared-thread-library) > LDLIBS-tst-arc4random-fork = $(shared-thread-library) > LDLIBS-tst-arc4random-thread = $(shared-thread-library) > +LDLIBS-tst-system = $(shared-thread-library) > > LDLIBS-test-dlclose-exit-race = $(shared-thread-library) > LDFLAGS-test-dlclose-exit-race = $(LDFLAGS-rdynamic)