From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: Carlos O'Donell <carlos@redhat.com>,
libc-alpha@sourceware.org, Frederic Berat <fberat@redhat.com>,
"Andreas K. Huettel" <dilfridge@gentoo.org>
Subject: Re: [PATCH 0/3] Fix some issues with tests when fortify is enabled
Date: Mon, 24 Jul 2023 15:42:42 -0300 [thread overview]
Message-ID: <9007fff8-b73f-c177-a401-0db4174908fb@linaro.org> (raw)
In-Reply-To: <1b22f4d7-267f-1e3e-dfd1-42af796ee9f0@redhat.com>
On 24/07/23 09:39, Carlos O'Donell wrote:
> On 7/21/23 08:18, Adhemerval Zanella via Libc-alpha wrote:
>> While working on the a3090c2c98facb I saw some issues while building
>> some tests when fortify is enabled. While the test-errno shows only
>> with old gcc 8, both bug-strncat1 and tester shows with gcc 13.1.1.
>>
>> I also checked with version from 7 to 13 with different ABIs (aarch64,
>> arm, mips, powerpc, powerpc64, and x86_64) and they following are the
>> oly missing fixes.
>
> Thank you very much for the thorough testing!
>
>
>> Adhemerval Zanella (3):
>> posix: Fix test-errno build with fortify enable
>
> This one looks good but there was a mismatch between the gcc version
> you said triggered the failure and the one commented in the code.
> If you clarify that we can get this committed.
>
>> string: Fix bug-strncat1 with fortify enabled
>> string: Fix tester with fortify enabled
>
> These two look good to me.
Thanks for the review. Do we want these for 2.38 or should we wait for 2.39?
next prev parent reply other threads:[~2023-07-24 18:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 12:18 Adhemerval Zanella
2023-07-21 12:18 ` [PATCH 1/3] posix: Fix test-errno build with fortify enable Adhemerval Zanella
2023-07-24 12:16 ` Carlos O'Donell
2023-07-24 13:03 ` Adhemerval Zanella Netto
2023-07-21 12:18 ` [PATCH 2/3] string: Fix bug-strncat1 with fortify enabled Adhemerval Zanella
2023-07-24 12:36 ` Carlos O'Donell
2023-07-24 14:24 ` Siddhesh Poyarekar
2023-07-24 14:26 ` Adhemerval Zanella Netto
2023-07-24 14:36 ` Siddhesh Poyarekar
2023-07-21 12:18 ` [PATCH 3/3] string: Fix tester " Adhemerval Zanella
2023-07-24 12:38 ` Carlos O'Donell
2023-07-24 12:39 ` [PATCH 0/3] Fix some issues with tests when fortify is enabled Carlos O'Donell
2023-07-24 18:42 ` Adhemerval Zanella Netto [this message]
2023-07-24 18:45 ` Andreas K. Huettel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9007fff8-b73f-c177-a401-0db4174908fb@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=carlos@redhat.com \
--cc=dilfridge@gentoo.org \
--cc=fberat@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).