From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id C6EDF3848029 for ; Thu, 5 Aug 2021 13:49:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C6EDF3848029 Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-157-2aC3qLMHPxWYbbx_fRrAJQ-1; Thu, 05 Aug 2021 09:49:12 -0400 X-MC-Unique: 2aC3qLMHPxWYbbx_fRrAJQ-1 Received: by mail-qk1-f199.google.com with SMTP id c5-20020a05620a2005b02903b8d1e253a9so4181214qka.11 for ; Thu, 05 Aug 2021 06:49:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=fVz8mb1SCvXZgC2nT3YVQlE2/kRnQM9NAyc6cNTlCBo=; b=YReoAp07I6Zd4wPWhpYq050j0I2RTNGRODoFZbqMgwQRumqldkDMxZl0Cl0L/SPBvR VDnCi6kEWkYgHEQBSsy84sl/IMuhAzBPR7AsEZMkECoWt0O6ICD9cResxEoCWSE5xNmK kNGC0ezCg01eH0qkPB+tO4OqlICY4fz0eWxTyAcuxOZUaghO3A/arr24zhb7SIjrkGGk 4w7oqoS0YBw0mLx5ATPSAyVTBZr93y/YnsDdMyep+gQfYCWCbFqmSeqfWRJpJ5LMHrCs mpwtOshKOsLHNQLO/YfVcS4Zjtkj6hEJdX2cl+THg16Y/1stklw0HN1jk6nqKE0h2SIw D+NQ== X-Gm-Message-State: AOAM5328t0N6lEE5g0oBB9SF8qLacCseKWKNCzTyjb7J4QWhcTuTQ5ar qhfwgWnn/Nmlxk8KyOl2jbb8k2P1sQ4Pg2dQpm1Tof7AE4raJo1SL/Ahq2vwuSdYzHXPPa5F+Ni GYDBVNLs9ds/Qa2Z0i3dx X-Received: by 2002:a05:620a:14b7:: with SMTP id x23mr5137247qkj.98.1628171352020; Thu, 05 Aug 2021 06:49:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzNGUbm8zPebLn4NhP9t82uuB4g71JdXJVdFqccaP6e9UM/eRehhm2sTDr1SsBWqR0rTf5ydg== X-Received: by 2002:a05:620a:14b7:: with SMTP id x23mr5137229qkj.98.1628171351817; Thu, 05 Aug 2021 06:49:11 -0700 (PDT) Received: from [192.168.1.16] (198-84-214-74.cpe.teksavvy.com. [198.84.214.74]) by smtp.gmail.com with ESMTPSA id o27sm2963328qkk.124.2021.08.05.06.49.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Aug 2021 06:49:11 -0700 (PDT) Subject: Re: [PATCH] Linux: Fix fcntl, ioctl, prctl redirects for _TIME_BITS=64 (bug 28182) To: Andreas Schwab , Florian Weimer via Libc-alpha Cc: Florian Weimer References: <8735rpeel5.fsf@oldenburg.str.redhat.com> <87im0lwj6x.fsf@igel.home> From: Carlos O'Donell Organization: Red Hat Message-ID: <9032e612-dca7-6fef-53f5-5ef6b375889c@redhat.com> Date: Thu, 5 Aug 2021 09:49:10 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <87im0lwj6x.fsf@igel.home> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Aug 2021 13:49:15 -0000 On 8/4/21 7:19 AM, Andreas Schwab wrote: > On Aug 04 2021, Florian Weimer via Libc-alpha wrote: > >> __REDIRECT and __THROW are not compatible with C++ due to the ordering of the >> __asm__ alias and the throw specifier. __REDIRECT_NTH has to be used >> instead. > > There should be a test so that this won't happen again. While I agree with this sentiment, as 2.34 RM I would like to see these fixes go into master and release/2.34/master immediately in order to correct any downstream distro issues that relate to these headers. I spoke with Florian off-line about this, and we both would like to see a broader set of changes that do more verification for the installed headers. So I think we will do this for glibc 2.35 as a broader set of changes. Does that work for you? -- Cheers, Carlos.