From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cyan.elm.relay.mailchannels.net (cyan.elm.relay.mailchannels.net [23.83.212.47]) by sourceware.org (Postfix) with ESMTPS id 38FEA3857421; Tue, 6 Jul 2021 13:12:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 38FEA3857421 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id B7876122DEF; Tue, 6 Jul 2021 13:12:17 +0000 (UTC) Received: from pdx1-sub0-mail-a29.g.dreamhost.com (100-96-11-26.trex.outbound.svc.cluster.local [100.96.11.26]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 4A32D122C05; Tue, 6 Jul 2021 13:12:17 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a29.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384) by 100.96.11.26 (trex/6.3.3); Tue, 06 Jul 2021 13:12:17 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Callous-Celery: 2e1830d4707cac72_1625577137552_2621152376 X-MC-Loop-Signature: 1625577137552:165279682 X-MC-Ingress-Time: 1625577137552 Received: from pdx1-sub0-mail-a29.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a29.g.dreamhost.com (Postfix) with ESMTP id E15D17F039; Tue, 6 Jul 2021 06:12:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gotplt.org; h=subject:to :cc:references:from:message-id:date:mime-version:in-reply-to :content-type:content-transfer-encoding; s=gotplt.org; bh=HmU2KE VffooYui3gzM5KfCz++Ew=; b=pcubQDCP67nAlxDGpL1a6KUeJdrMaORv5Dtk1M LaWQ5oVuLZhGDuzDVvoJraaPBJjesKUEYzUlmmmWOLxGRv2Wa+42LDATtGzZh3pS wtq9F1WPCyc6ReeWQKYB2KLjuuOCZePN0grVVzpoX0mBBBKxCwJFTvjBuyHVhbQP nnSI0= Received: from [192.168.1.136] (unknown [1.186.101.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a29.g.dreamhost.com (Postfix) with ESMTPSA id 34E007E3CB; Tue, 6 Jul 2021 06:12:14 -0700 (PDT) Subject: Re: [PATCH v5 1/8] Move malloc hooks into a compat DSO To: Siddhesh Poyarekar , Florian Weimer Cc: libc-alpha@sourceware.org References: <20210705170814.4132997-1-siddhesh@sourceware.org> <20210705170814.4132997-2-siddhesh@sourceware.org> <8735sriw5u.fsf@oldenburg.str.redhat.com> <7f71ca86-3b98-7b26-a52f-0e191f015ee2@sourceware.org> X-DH-BACKEND: pdx1-sub0-mail-a29 From: Siddhesh Poyarekar Message-ID: <90427227-9e71-df6b-d753-81cb21e968df@gotplt.org> Date: Tue, 6 Jul 2021 18:42:10 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <7f71ca86-3b98-7b26-a52f-0e191f015ee2@sourceware.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3029.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Jul 2021 13:12:21 -0000 On 7/6/21 6:30 PM, Siddhesh Poyarekar via Libc-alpha wrote: >> In general, it looks like it's time to add support for mtrace tests to >> the setsuite (that is, tests-mtrace like tests-time64). >=20 > ... or tests-mcheck/tests-malloc-check.=C2=A0 Would you be OK with havi= ng the=20 > test driver call mtrace() at all times?=C2=A0 Only the tests in tests-m= trace=20 > (which for starters we could add all tests in malloc to) will actually=20 > have any impact. I forgot to ask, would you like that to be part of this patchset or=20 would you be OK with the testing enhancement coming in later? Mtrace=20 already has some testing coverage through tst-mtrace for example and=20 other tests using mtrace. Siddhesh