From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cyan.elm.relay.mailchannels.net (cyan.elm.relay.mailchannels.net [23.83.212.47]) by sourceware.org (Postfix) with ESMTPS id D8615385700F for ; Wed, 17 May 2023 00:17:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D8615385700F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 22205760777; Wed, 17 May 2023 00:17:02 +0000 (UTC) Received: from pdx1-sub0-mail-a305.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 83A3E761154; Wed, 17 May 2023 00:17:01 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1684282621; a=rsa-sha256; cv=none; b=bhYx616F9XsIxYUuWf3OTynx8DQqb4+7PN8Fb5Ln0hn1+KFzpDiSpoxcVby/JDD2jeAIRI MDdNBAPqYgvJ1zFIc80scU6TkvssM6U/UoUMwVcblnX7ICY1S/SwXaMuA8rR5vUO4uXx8c cDpm8/C/2e3o3GMbP3aMjRybXmAHMsY+s78apZ5uouga6bbvd5X+u/hsAlVKdpRRwN9r+G L6XhUee+BRdkAq1mlVHmhILg44ZYnzxGlT3KJ52u/Ze1rRPWktP6Y2Nox96tAHvhrGYOjJ ePnDulQ+epEXXZgNJqrz2klDErZOUf9jZcS7rJV7Gm74aNaylQ7qm7Xn82tbeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1684282621; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EGIPS8Tooin4ObXKLYo8g0KXH5HwVK1NTdEZ29+bNCA=; b=4y8WsAmWL+W/580C2Fdrw6lf+o+mlsVUnivtnNyZmJcygPfBp1pACgQ6fnsvt2rQIr7MPS 3m1+mvAMsYuiwPqVTZX/8VQYC4rm/C0ibk/qbgxrytNebMqhD0CkT5PrN98d+oqd9PBLFq WVyerefEDD2Xd1UUbwrVtg4TiTWcl8ZrnjdjsP3p8oYIQVOymF0Wm/mup5vkH5Q8jxd4Wy 8FWPwzFLtxZFeX0EubRb3BcO1XO4n9akmFAUp2kYL0D4x7J2/xAnpaw9ijS2ah4iaQDoKH z/J18/5sI8oeZKnbWpZ4hfnsaZqJfe6Wkt+8+xP1RT0JWIUDTlz7DbdGMBFcKg== ARC-Authentication-Results: i=1; rspamd-5cdf8fd7d9-qfmcz; auth=pass smtp.auth=dreamhost smtp.mailfrom=siddhesh@gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Shade-Trail: 50a983e160412405_1684282621897_3860884889 X-MC-Loop-Signature: 1684282621897:2245360238 X-MC-Ingress-Time: 1684282621897 Received: from pdx1-sub0-mail-a305.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.120.163.35 (trex/6.8.1); Wed, 17 May 2023 00:17:01 +0000 Received: from [192.168.0.182] (bras-vprn-toroon4834w-lp130-09-174-91-45-80.dsl.bell.ca [174.91.45.80]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a305.dreamhost.com (Postfix) with ESMTPSA id 4QLYZN6B5wzQk; Tue, 16 May 2023 17:17:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gotplt.org; s=dreamhost; t=1684282621; bh=EGIPS8Tooin4ObXKLYo8g0KXH5HwVK1NTdEZ29+bNCA=; h=Date:Subject:To:Cc:From:Content-Type:Content-Transfer-Encoding; b=IEOLFBFHKWpM8rpONlaF9NZu2LyVtN8EOUVwRbwbHNZ40Z/+4Kd7sk0LPPE7ISJHU xWlL6Hh1KKF5QKpwDnvxJtb6DtTpEHm73QkxCx4ArBIsXGntzpEO1H0TPGcmIe+eMR WzoVuEa4FsJEL6OeAsDwg2R5ZmCVQO6fLV5gge+6moFTHy1xbwdswHO06mJZodn9PN YknhUSFvi/Sz7AqnFEh8ACglad7Yhwd7TJBBqyjo/hBqysnFYUoHM4iySCGsatlVDM 22C1Pl1WOkiNE1C7Iqr8VpYkpr9VuqcR/sqDTPpec/ftZ55JyNh2encFH183FpUnPz KfoeOBKY7Ndng== Message-ID: <90782c2d-0137-a1be-e3ea-62c95e58cb80@gotplt.org> Date: Tue, 16 May 2023 20:16:59 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] stdlib: Use long long int in stdlib/tst-llabs Content-Language: en-US To: Florian Weimer , libc-alpha@sourceware.org Cc: Siddhesh Poyarekar , Joe Simmons-Talbott References: <87jzx83shb.fsf@oldenburg.str.redhat.com> From: Siddhesh Poyarekar In-Reply-To: <87jzx83shb.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3038.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Reviewed-by: Siddhesh Poyarekar On 2023-05-16 16:56, Florian Weimer via Libc-alpha wrote: > And adjust for GNU style. > > --- > stdlib/tst-llabs.c | 28 ++++++++++++++-------------- > 1 file changed, 14 insertions(+), 14 deletions(-) > > diff --git a/stdlib/tst-llabs.c b/stdlib/tst-llabs.c > index be3cd78ceb..5e4d52def9 100644 > --- a/stdlib/tst-llabs.c > +++ b/stdlib/tst-llabs.c > @@ -25,29 +25,29 @@ > > static int do_test (void) > { > - long i; > + long long int i; > > - TEST_COMPARE(llabs(LLONG_MAX), LLONG_MAX); > - TEST_COMPARE(llabs(LLONG_MIN + 1), LLONG_MAX); > - TEST_COMPARE(llabs(0x00000000ffffffffL), 0x00000000ffffffffL); > - TEST_COMPARE(llabs(0x0000000100000000L), 0x0000000100000000L); > - TEST_COMPARE(llabs(0x80000000ffffffffL), 0x7fffffff00000001L); > - TEST_COMPARE(llabs(0x8000000100000000L), 0x7fffffff00000000L); > - TEST_COMPARE(llabs(-1), 1); > - TEST_COMPARE(llabs(0), 0); > - TEST_COMPARE(llabs(1), 1); > + TEST_COMPARE (llabs (LLONG_MAX), LLONG_MAX); > + TEST_COMPARE (llabs (LLONG_MIN + 1), LLONG_MAX); > + TEST_COMPARE (llabs (0x00000000ffffffffL), 0x00000000ffffffffL); > + TEST_COMPARE (llabs (0x0000000100000000L), 0x0000000100000000L); > + TEST_COMPARE (llabs (0x80000000ffffffffL), 0x7fffffff00000001L); > + TEST_COMPARE (llabs (0x8000000100000000L), 0x7fffffff00000000L); > + TEST_COMPARE (llabs (-1), 1); > + TEST_COMPARE (llabs (0), 0); > + TEST_COMPARE (llabs (1), 1); > > for (i = LLONG_MIN + 1; i < LLONG_MIN + INT_MAX; i += LARGE_PRIME) > - TEST_COMPARE(llabs(i), -i); > + TEST_COMPARE (llabs (i), -i); > > for (i = LLONG_MAX - INT_MAX; i < LLONG_MAX - LARGE_PRIME; i += LARGE_PRIME) > - TEST_COMPARE(llabs(i), i); > + TEST_COMPARE (llabs (i), i); > > for (i = INT_MIN + 1; i < 0; i += LARGE_PRIME) > - TEST_COMPARE(llabs(i), -i); > + TEST_COMPARE (llabs (i), -i); > > for (i = 0; i < INT_MAX; i += LARGE_PRIME) > - TEST_COMPARE(llabs(i), i); > + TEST_COMPARE (llabs (i), i); > > return EXIT_SUCCESS; > } > > base-commit: 89ade905c51a2488e85a28f9de413d8d9c1af82d >