From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: Florian Weimer <fweimer@redhat.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH] malloc: Use __getrandom_nocancel during tcache initiailization
Date: Mon, 1 Aug 2022 10:42:06 -0300 [thread overview]
Message-ID: <90921f54-15b6-2d4c-42ca-a918df579d2d@linaro.org> (raw)
In-Reply-To: <87fsigp7y9.fsf@oldenburg.str.redhat.com>
On 01/08/22 07:35, Florian Weimer via Libc-alpha wrote:
> Cancellation currently cannot happen at this point because dlopen
> as used by the unwind link always performs additional allocations
> for libgcc_s.so.1, even if it has been loaded already as a dependency
> of the main executable. But it seems prudent not to rely on this
> quirk.
>
LGTM, thanks.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> ---
> malloc/malloc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/malloc/malloc.c b/malloc/malloc.c
> index bd3c76ed31..430d204156 100644
> --- a/malloc/malloc.c
> +++ b/malloc/malloc.c
> @@ -254,6 +254,7 @@
> /* For tcache double-free check. */
> #include <random-bits.h>
> #include <sys/random.h>
> +#include <not-cancel.h>
>
> /*
> Debugging:
> @@ -3153,7 +3154,7 @@ static uintptr_t tcache_key;
> static void
> tcache_key_initialize (void)
> {
> - if (__getrandom (&tcache_key, sizeof(tcache_key), GRND_NONBLOCK)
> + if (__getrandom_nocancel (&tcache_key, sizeof(tcache_key), GRND_NONBLOCK)
> != sizeof (tcache_key))
> {
> tcache_key = random_bits ();
>
next prev parent reply other threads:[~2022-08-01 13:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-01 10:35 Florian Weimer
2022-08-01 13:42 ` Adhemerval Zanella Netto [this message]
2022-08-02 9:04 ` Using arc4random() in the library (was Re: [PATCH] malloc: Use __getrandom_nocancel during tcache initiailization) Yann Droneaud
2022-08-02 9:44 ` Florian Weimer
2022-08-03 13:50 ` Cristian Rodríguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90921f54-15b6-2d4c-42ca-a918df579d2d@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).