[PATCH glibc/release/2.38/master] elf: Remove l_init_called_next field from struct link_map

[PATCH glibc/release/2.38/master] elf: Remove l_init_called_next field from struct link_map

[Mark Zhuang]

From 89639547c9d661446064d50833c2dc00cbbee679 Mon Sep 17 00:00:00 2001
From: Mark Zhuang <mark.zhuang@spacemit.com>
Date: Wed, 24 Apr 2024 11:16:20 +0800
Subject: [PATCH] elf: Remove l_init_called_next field from struct link_map

When commit 719866ab2ff0e6d514a04fb47e507d92e70ef7ee revert commit
a3189f66a5f2fe86568286fa025fa153be04c6c0, this filed change was
missed, now remove it.

Reason for remove is same as 719866ab2ff0e6d514a04fb47e507d92e70ef7ee:
Incompatibility with existing applications.

Signed-off-by: Mark Zhuang <mark.zhuang@spacemit.com>
---
 include/link.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/include/link.h b/include/link.h
index 69bda3ed17..1d74feb2bd 100644
--- a/include/link.h
+++ b/include/link.h
@@ -278,10 +278,6 @@ struct link_map
     /* List of object in order of the init and fini calls.  */
     struct link_map **l_initfini;

-    /* Linked list of objects in reverse ELF constructor execution
-       order.  Head of list is stored in _dl_init_called_list.  */
-    struct link_map *l_init_called_next;
-
     /* List of the dependencies introduced through symbol binding.  */
     struct link_map_reldeps
       {
--
2.34.1


This message and any attachment are confidential and may be privileged or otherwise protected from disclosure. If you are not an intended recipient of this message, please delete it and any attachment from your system and notify the sender immediately by reply e-mail. Unintended recipients should not use, copy, disclose or take any action based on this message or any information contained in this message. Emails cannot be guaranteed to be secure or error free as they can be intercepted, amended, lost or destroyed, and you should take full responsibility for security checking. 
 
本邮件及其任何附件具有保密性质，并可能受其他保护或不允许被披露给第三方。如阁下误收到本邮件，敬请立即以回复电子邮件的方式通知发件人，并将本邮件及其任何附件从阁下系统中予以删除。如阁下并非本邮件写明之收件人，敬请切勿使用、复制、披露本邮件或其任何内容，亦请切勿依本邮件或其任何内容而采取任何行动。电子邮件无法保证是一种安全和不会出现任何差错的通信方式，可能会被拦截、修改、丢失或损坏，收件人需自行负责做好安全检查。

Re: [PATCH glibc/release/2.38/master] elf: Remove l_init_called_next field from struct link_map

[Adhemerval Zanella Netto]

On 24/04/24 00:44, Mark Zhuang wrote:
> From 89639547c9d661446064d50833c2dc00cbbee679 Mon Sep 17 00:00:00 2001
> From: Mark Zhuang <mark.zhuang@spacemit.com>
> Date: Wed, 24 Apr 2024 11:16:20 +0800
> Subject: [PATCH] elf: Remove l_init_called_next field from struct link_map
> 
> When commit 719866ab2ff0e6d514a04fb47e507d92e70ef7ee revert commit
> a3189f66a5f2fe86568286fa025fa153be04c6c0, this filed change was
> missed, now remove it.
> 
> Reason for remove is same as 719866ab2ff0e6d514a04fb47e507d92e70ef7ee:
> Incompatibility with existing applications.
> 
> Signed-off-by: Mark Zhuang <mark.zhuang@spacemit.com>

This patch looks ok, although it is not strictly a backport.  Florian,
any idea why this snippet was not within the dd32e1db386c77c61850a7cbd
backport? 

> ---
>  include/link.h | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/include/link.h b/include/link.h
> index 69bda3ed17..1d74feb2bd 100644
> --- a/include/link.h
> +++ b/include/link.h
> @@ -278,10 +278,6 @@ struct link_map
>      /* List of object in order of the init and fini calls.  */
>      struct link_map **l_initfini;
> 
> -    /* Linked list of objects in reverse ELF constructor execution
> -       order.  Head of list is stored in _dl_init_called_list.  */
> -    struct link_map *l_init_called_next;
> -
>      /* List of the dependencies introduced through symbol binding.  */
>      struct link_map_reldeps
>        {
> --
> 2.34.1
> 
> 
> This message and any attachment are confidential and may be privileged or otherwise protected from disclosure. If you are not an intended recipient of this message, please delete it and any attachment from your system and notify the sender immediately by reply e-mail. Unintended recipients should not use, copy, disclose or take any action based on this message or any information contained in this message. Emails cannot be guaranteed to be secure or error free as they can be intercepted, amended, lost or destroyed, and you should take full responsibility for security checking. 
>  
> 本邮件及其任何附件具有保密性质，并可能受其他保护或不允许被披露给第三方。如阁下误收到本邮件，敬请立即以回复电子邮件的方式通知发件人，并将本邮件及其任何附件从阁下系统中予以删除。如阁下并非本邮件写明之收件人，敬请切勿使用、复制、披露本邮件或其任何内容，亦请切勿依本邮件或其任何内容而采取任何行动。电子邮件无法保证是一种安全和不会出现任何差错的通信方式，可能会被拦截、修改、丢失或损坏，收件人需自行负责做好安全检查。

Please refrain to add this footnote on email intended for public maillist,
usually this make the message being solely ignored.

Re: [PATCH glibc/release/2.38/master] elf: Remove l_init_called_next field from struct link_map

[Florian Weimer]

* Adhemerval Zanella Netto:

> On 24/04/24 00:44, Mark Zhuang wrote:
>> From 89639547c9d661446064d50833c2dc00cbbee679 Mon Sep 17 00:00:00 2001
>> From: Mark Zhuang <mark.zhuang@spacemit.com>
>> Date: Wed, 24 Apr 2024 11:16:20 +0800
>> Subject: [PATCH] elf: Remove l_init_called_next field from struct link_map
>> 
>> When commit 719866ab2ff0e6d514a04fb47e507d92e70ef7ee revert commit
>> a3189f66a5f2fe86568286fa025fa153be04c6c0, this filed change was
>> missed, now remove it.
>> 
>> Reason for remove is same as 719866ab2ff0e6d514a04fb47e507d92e70ef7ee:
>> Incompatibility with existing applications.
>> 
>> Signed-off-by: Mark Zhuang <mark.zhuang@spacemit.com>
>
> This patch looks ok, although it is not strictly a backport.  Florian,
> any idea why this snippet was not within the dd32e1db386c77c61850a7cbd
> backport? 

It was a separate change to preserve internal GLIBC_PRIVATE ABI during
the backport, so that process launch during a concurrent update did not
fail needlessly.

Thanks,
Florian

Re: [PATCH glibc/release/2.38/master] elf: Remove l_init_called_next field from struct link_map

[Tom Kacvinsky]

> Please refrain to add this footnote on email intended for public maillist,
> usually this make the message being solely ignored

Some people don’t have a choice in the matter.  Their employer automatically adds the boilerplate text.  That’s why I started using my personal email account for public mailing lists.

Re: [PATCH glibc/release/2.38/master] elf: Remove l_init_called_next field from struct link_map

[Mark Zhuang]

Hi florian,

> It was a separate change to preserve internal GLIBC_PRIVATE ABI during
> the backport, so that process launch during a concurrent update did not
> fail needlessly.
Does "separate change" here refer to these two patches?
* d3ba6c1333 - elf: Move l_init_called_next to old place of l_text_end
in link map
* 750f19526a - elf: Remove unused l_text_end field from struct link_map

Since both of them have been revert, I think we should remove the
l_init_called_next field on branches from 2.35 to 2.38.
Please correct me if I misunderstand or miss any information, thank you.

mark.zhuang <zhuangqiubin@gmail.com> 于2024年4月24日周三 23:47写道：
>
> > > From:  Florian Weimer <fweimer@redhat.com>
> > > Date:  Wed, Apr 24, 2024, 22:23
> > > Subject:  Re: [PATCH glibc/release/2.38/master] elf: Remove l_init_called_next field from struct link_map
> > > To:  "Adhemerval Zanella Netto"<adhemerval.zanella@linaro.org>
> > > Cc:  "Mark Zhuang"<mark.zhuang@spacemit.com>, "libc-alpha@sourceware.org"<libc-alpha@sourceware.org>
> > > * Adhemerval Zanella Netto:
> > >
> > > > On 24/04/24 00:44, Mark Zhuang wrote:
> > > >> From 89639547c9d661446064d50833c2dc00cbbee679 Mon Sep 17 00:00:00 2001
> > > >> From: Mark Zhuang <mark.zhuang@spacemit.com>
> > > >> Date: Wed, 24 Apr 2024 11:16:20 +0800
> > > >> Subject: [PATCH] elf: Remove l_init_called_next field from struct link_map
> > > >>
> > > >> When commit 719866ab2ff0e6d514a04fb47e507d92e70ef7ee revert commit
> > > >> a3189f66a5f2fe86568286fa025fa153be04c6c0, this filed change was
> > > >> missed, now remove it.
> > > >>
> > > >> Reason for remove is same as 719866ab2ff0e6d514a04fb47e507d92e70ef7ee:
> > > >> Incompatibility with existing applications.
> > > >>
> > > >> Signed-off-by: Mark Zhuang <mark.zhuang@spacemit.com>
> > > >
> > > > This patch looks ok, although it is not strictly a backport.  Florian,
> > > > any idea why this snippet was not within the dd32e1db386c77c61850a7cbd
> > > > backport?
> > >
> > > It was a separate change to preserve internal GLIBC_PRIVATE ABI during
> > > the backport, so that process launch during a concurrent update did not
> > > fail needlessly.
> > >
> > > Thanks,
> > > Florian
> >
> >
>
> * 1e04dcec49 - Revert "elf: Move l_init_called_next to old place of
> l_text_end in link map"
> * 719866ab2f - Revert "elf: Always call destructors in reverse
> constructor order (bug 30785)"
> * e0b6c9706c - Revert "elf: Remove unused l_text_end field from struct link_map"
> * d3ba6c1333 - elf: Move l_init_called_next to old place of l_text_end
> in link map
> * 750f19526a - elf: Remove unused l_text_end field from struct link_map
> * a3189f66a5 - elf: Always call destructors in reverse constructor
> order (bug 30785)
>
> There are 3 patches and 3 reverts, but it seems that the order of
> reverts is different.
> Maybe there were some git conflicts when reverting, and resolving the
> conflicts resulted in l_init_called_next being left in the code.
>
> And sorry for the footnote from mark.zhuang@spacemit.com, I'll use
> gmail until I figure out how to delete that footnote.



-- 

Best regards

Re: [PATCH glibc/release/2.38/master] elf: Remove l_init_called_next field from struct link_map

[mark.zhuang]

> > From:  Florian Weimer <fweimer@redhat.com>
> > Date:  Wed, Apr 24, 2024, 22:23
> > Subject:  Re: [PATCH glibc/release/2.38/master] elf: Remove l_init_called_next field from struct link_map
> > To:  "Adhemerval Zanella Netto"<adhemerval.zanella@linaro.org>
> > Cc:  "Mark Zhuang"<mark.zhuang@spacemit.com>, "libc-alpha@sourceware.org"<libc-alpha@sourceware.org>
> > * Adhemerval Zanella Netto:
> >
> > > On 24/04/24 00:44, Mark Zhuang wrote:
> > >> From 89639547c9d661446064d50833c2dc00cbbee679 Mon Sep 17 00:00:00 2001
> > >> From: Mark Zhuang <mark.zhuang@spacemit.com>
> > >> Date: Wed, 24 Apr 2024 11:16:20 +0800
> > >> Subject: [PATCH] elf: Remove l_init_called_next field from struct link_map
> > >>
> > >> When commit 719866ab2ff0e6d514a04fb47e507d92e70ef7ee revert commit
> > >> a3189f66a5f2fe86568286fa025fa153be04c6c0, this filed change was
> > >> missed, now remove it.
> > >>
> > >> Reason for remove is same as 719866ab2ff0e6d514a04fb47e507d92e70ef7ee:
> > >> Incompatibility with existing applications.
> > >>
> > >> Signed-off-by: Mark Zhuang <mark.zhuang@spacemit.com>
> > >
> > > This patch looks ok, although it is not strictly a backport.  Florian,
> > > any idea why this snippet was not within the dd32e1db386c77c61850a7cbd
> > > backport?
> >
> > It was a separate change to preserve internal GLIBC_PRIVATE ABI during
> > the backport, so that process launch during a concurrent update did not
> > fail needlessly.
> >
> > Thanks,
> > Florian
>
>

* 1e04dcec49 - Revert "elf: Move l_init_called_next to old place of
l_text_end in link map"
* 719866ab2f - Revert "elf: Always call destructors in reverse
constructor order (bug 30785)"
* e0b6c9706c - Revert "elf: Remove unused l_text_end field from struct link_map"
* d3ba6c1333 - elf: Move l_init_called_next to old place of l_text_end
in link map
* 750f19526a - elf: Remove unused l_text_end field from struct link_map
* a3189f66a5 - elf: Always call destructors in reverse constructor
order (bug 30785)

There are 3 patches and 3 reverts, but it seems that the order of
reverts is different.
Maybe there were some git conflicts when reverting, and resolving the
conflicts resulted in l_init_called_next being left in the code.

And sorry for the footnote from mark.zhuang@spacemit.com, I'll use
gmail until I figure out how to delete that footnote.