From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x233.google.com (mail-oi1-x233.google.com [IPv6:2607:f8b0:4864:20::233]) by sourceware.org (Postfix) with ESMTPS id 22FBC3898C6B for ; Fri, 6 May 2022 13:20:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 22FBC3898C6B Received: by mail-oi1-x233.google.com with SMTP id e189so7430005oia.8 for ; Fri, 06 May 2022 06:20:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=kRTKz/eC8y4R+9otGgHKUoJXaA+s2kZYAafunTk/o0U=; b=m/7t19MingdlbvgJ+olZc80FAh/oJx0ViVE3YhhS3mGQ1x8BZZqbRn9/pWhdsp22Tz 8u1OB5U1VCxeIUM5tW8RZ7VDLaQQq/vHKp2roXOxhRCSQ6wGxFk0SvuYlsEHEN05rXO3 sDCD93yetSg4qnRlGTc4zJFBZ/rX60tx5JwAhI0DN4SoJNeY8rY6ZaORtIqS5Yv7GgIn hTUoXl0MwosPLbSwvX+dF273KWeJlzE/JRQIxQhTzho7IhjkgBs00Emd0sa6OPldgn+g L6ykHMDYxLSY6FAQtreQZGvsYcVGVID/UxECjSCUKpfgwT8WxPM0LClE8DPiy7DeYLsV SguQ== X-Gm-Message-State: AOAM531vNZLwgT/zxBLW9zvxxSFB4kh2b+/RE6kkK4SHWe9EvgQSBBMQ bhu46lBftZGkBOcQswQdnOrZkdDdoxQJOw== X-Google-Smtp-Source: ABdhPJxR7rGxkp1Fka6/aDaOMtud92hHb3Vnyrrv+wMsjdBsOOfOsIoRm7C/BemDYaTddK7bD2jVTA== X-Received: by 2002:a05:6808:55d:b0:325:8d2b:7c19 with SMTP id i29-20020a056808055d00b003258d2b7c19mr4722255oig.36.1651843252392; Fri, 06 May 2022 06:20:52 -0700 (PDT) Received: from ?IPV6:2804:431:c7cb:726:53f7:4ba7:4810:79df? ([2804:431:c7cb:726:53f7:4ba7:4810:79df]) by smtp.gmail.com with ESMTPSA id l21-20020a544515000000b00325cda1ffb8sm1589919oil.55.2022.05.06.06.20.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 May 2022 06:20:51 -0700 (PDT) Message-ID: <90b8a390-c7d4-39d8-569e-caf104e7bd50@linaro.org> Date: Fri, 6 May 2022 10:20:49 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 1/2] benchtests: Add wcrtomb microbenchmark Content-Language: en-US To: Siddhesh Poyarekar , libc-alpha@sourceware.org References: <20220505184348.3357550-1-siddhesh@sourceware.org> <20220505184348.3357550-2-siddhesh@sourceware.org> From: Adhemerval Zanella In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 May 2022 13:20:54 -0000 On 06/05/2022 09:59, Siddhesh Poyarekar wrote: > (Sorry I just committed it before I saw your message) > > On 06/05/2022 18:20, Adhemerval Zanella via Libc-alpha wrote: >>> +  /* 4-byte chars, because smileys are the universal language and we want to >>> +     ensure optimal performance with them 😊.  */ >>> +  {"en_US.UTF-8", >>> +   L"😀😁😂😃😄😅😆😇😈😉😊😋😌😍😎😏😐😑😒😓😔😕😖😗😘😙😚😛😜😝😞😟😠😡"} >>> +}; >> >> Could you use use hexadecimal character escape in tests? Although gcc handle multiple >> -fexec-charset, trying to build it with a different compiler usually emits a lot of >> warnings. >> > > Hmm, I'm curious to know which compiler this breaks on; it's straight up UTF-8 so should parse just fine, no? I does not really breaks, but clang warns about character enconding (I forgot which was the specific error, I will check it). I have to fix a lot of internal usage to get a clean make check on clang [1]. [1] https://sourceware.org/git/?p=glibc.git;a=commit;h=058bb0d51c3f85041c7cbd14704f72003bdbdee9