public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org,
	Raoni Fassina Firmino <raoni@linux.ibm.com>,
	Tulio Magno Quites Machado Filho <tuliom@ascii.art.br>
Subject: Re: [PATCH] powerpc: Remove backtrace implementation
Date: Fri, 12 Feb 2021 14:25:01 -0300	[thread overview]
Message-ID: <90d1d0e5-a31e-fbac-ead0-7f76f2645cd9@linaro.org> (raw)
In-Reply-To: <878s7ti4m0.fsf@oldenburg.str.redhat.com>



On 12/02/2021 14:21, Florian Weimer wrote:
> * Adhemerval Zanella:
> 
>> The powerpc optimization to provide a fast stacktrace requires some
>> ad-hoc code to handle Linux signal frames and the change is fragile
>> once the kernel decides to slight change its execution sequence [1].
>>
>> The generic implementation work as-is and it should be future proof
>> since the kernel provides the expected CFI directives in vDSO shared
>> page.
>>
>> Checked on powerpc-linux-gnu, powerpc64le-linux-gnu, and
>> powerpc64-linux-gnu.
>>
>> [1] https://sourceware.org/pipermail/libc-alpha/2021-January/122027.html
> 
> Does this really work well (enough) on systems which do not build
> everything with asynchronous unwind tables?  If I recall correctly, GCC
> enabled them by default only quite recently.

This should work as well any other architecture since it uses the libgcc_s
routines.  Afaik the powerpc implementation was done as optimization, not
for correctness.

  reply	other threads:[~2021-02-12 17:25 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-12 17:09 Adhemerval Zanella
2021-02-12 17:21 ` Florian Weimer
2021-02-12 17:25   ` Adhemerval Zanella [this message]
2021-02-22 22:16     ` Tulio Magno Quites Machado Filho
2021-02-23  9:52       ` Florian Weimer
2021-02-23 11:56       ` Adhemerval Zanella
2021-02-23 12:28         ` Florian Weimer
2021-02-23 12:43           ` Adhemerval Zanella
2021-02-26 17:39             ` Raoni Fassina Firmino
2021-04-14 21:37               ` Paul E Murphy
2021-04-15 14:42                 ` Tulio Magno Quites Machado Filho
2021-04-15 20:44                   ` Adhemerval Zanella
2021-04-27 15:09                     ` Florian Weimer
2021-10-14 20:24                   ` Raphael M Zinsly
2021-10-14 21:39                     ` Tulio Magno Quites Machado Filho
2021-10-20 13:39                       ` Adhemerval Zanella
2021-02-26 17:19 ` Raoni Fassina Firmino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=90d1d0e5-a31e-fbac-ead0-7f76f2645cd9@linaro.org \
    --to=adhemerval.zanella@linaro.org \
    --cc=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=raoni@linux.ibm.com \
    --cc=tuliom@ascii.art.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).