From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from antelope.elm.relay.mailchannels.net (antelope.elm.relay.mailchannels.net [23.83.212.4]) by sourceware.org (Postfix) with ESMTPS id B1F9539960C0 for ; Wed, 28 Jul 2021 10:26:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B1F9539960C0 X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 663744826BD; Wed, 28 Jul 2021 10:25:59 +0000 (UTC) Received: from pdx1-sub0-mail-a75.g.dreamhost.com (100-96-16-95.trex-nlb.outbound.svc.cluster.local [100.96.16.95]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id E3F424823AA; Wed, 28 Jul 2021 10:25:58 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a75.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384) by 100.96.16.95 (trex/6.3.3); Wed, 28 Jul 2021 10:25:59 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Harbor-Wiry: 7d2ce3247584fcab_1627467959272_1213738581 X-MC-Loop-Signature: 1627467959272:138473901 X-MC-Ingress-Time: 1627467959272 Received: from pdx1-sub0-mail-a75.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a75.g.dreamhost.com (Postfix) with ESMTP id 9E5F08C383; Wed, 28 Jul 2021 03:25:58 -0700 (PDT) Received: from [192.168.1.152] (unknown [1.186.101.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a75.g.dreamhost.com (Postfix) with ESMTPSA id 12E388C377; Wed, 28 Jul 2021 03:25:56 -0700 (PDT) Subject: Re: [PATCH v2] tests: use xmalloc to allocate implementation array To: Florian Weimer Cc: libc-alpha@sourceware.org References: <20210728073530.3917457-1-siddhesh@sourceware.org> <875ywuamzd.fsf@oldenburg.str.redhat.com> X-DH-BACKEND: pdx1-sub0-mail-a75 From: Siddhesh Poyarekar Message-ID: <91c2cf75-9980-c8f9-131a-e57c7487b841@sourceware.org> Date: Wed, 28 Jul 2021 15:55:50 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <875ywuamzd.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3486.8 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_NONE, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jul 2021 10:26:03 -0000 On 7/28/21 1:28 PM, Florian Weimer wrote: > Okay if it actually links. > > Rest of the patch seems okay to me. I just realized I implemented __returns_nonnull in a different patch[1]. Would you be able to review that too? Thanks, Siddhesh [1] https://patchwork.sourceware.org/project/glibc/patch/20210728050928.3873663-1-siddhesh@sourceware.org/