From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x233.google.com (mail-oi1-x233.google.com [IPv6:2607:f8b0:4864:20::233]) by sourceware.org (Postfix) with ESMTPS id B8BDE385E45B for ; Thu, 28 Apr 2022 21:49:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B8BDE385E45B Received: by mail-oi1-x233.google.com with SMTP id a10so6729974oif.9 for ; Thu, 28 Apr 2022 14:49:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=+04R9pNyzr32oe8OKlVHxhBRt+vBT+Ldi0Fadb8tFK0=; b=e4se6lkwOmwCUg95o6ShIQCQu3QUGUc04umsR9+lmc/0vA55mgRoCZkKDRSis5x/kg h/TKN1OUJWzDI2pdfx0JyapNK/lSrgM14VuChbsYC6riLidbv/oRshXWX6nFDPDzMTMq DVaL/5o9fgDGYHTc/1qUWlFy1BH9fIS961Pu+URGQwq0gRXSkRVVlFgqzGyjbxvaJDE5 hG9LzW0SEMUow/ezdKCtNA7ncvfqx+N9Xzat+nhMAFYl55vzFVlJg1aufcQATRREUqb1 QKHKJaP0G+tmv95YzUoX4zO6/bcriYk5xYutScdqNE0upmqS0uyxHCTY3w/D5quRhov2 mxzA== X-Gm-Message-State: AOAM532JMG4B/Ds3nYp4sFbsj/XHgCdtaIZ9+EdRwdKN0u5BzeLb3BGl Rv4SKjAtTVPojpZey70ZS5BOcCQzYOJStw== X-Google-Smtp-Source: ABdhPJyhPA7HO+1SlOoQkTNekV7+RL2hFYW2cI+4kW+ZMTjWJ3VQM56vQKed8j4Knk9rJKXsWgiukQ== X-Received: by 2002:a05:6808:d4f:b0:325:7e09:e540 with SMTP id w15-20020a0568080d4f00b003257e09e540mr121115oik.113.1651182546015; Thu, 28 Apr 2022 14:49:06 -0700 (PDT) Received: from ?IPV6:2804:431:c7cb:726:baf9:42ff:9628:ddb9? ([2804:431:c7cb:726:baf9:42ff:9628:ddb9]) by smtp.gmail.com with ESMTPSA id e7-20020a056808148700b003252f1da45bsm510898oiw.38.2022.04.28.14.49.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Apr 2022 14:49:05 -0700 (PDT) Message-ID: <91c5153c-d02e-a108-6ee8-32d10688e4c0@linaro.org> Date: Thu, 28 Apr 2022 18:49:02 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v2] linux: Fix fchmodat with AT_SYMLINK_NOFOLLOW for 64 bit time_t (BZ#29097) Content-Language: en-US To: Paul Eggert , libc-alpha@sourceware.org References: <20220427184813.3124798-1-adhemerval.zanella@linaro.org> <59728084-3368-dc44-26b9-c227487f6906@cs.ucla.edu> From: Adhemerval Zanella In-Reply-To: <59728084-3368-dc44-26b9-c227487f6906@cs.ucla.edu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Apr 2022 21:49:09 -0000 On 28/04/2022 17:52, Paul Eggert wrote: > On 4/28/22 04:10, Adhemerval Zanella wrote: >>>> +  const struct timespec ts[] = { { 0x80000001LL, 0}, { 0x80000002LL } }; >>> The two timestamps should use the same format. Otherwise, the patch looks good to me. Thanks. >> Ok, I will use 0x80000001LL for both. > > Oh, I merely meant that one ends in ", 0" while the other one doesn't. > > No big deal. Oops, I will correct it.