From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87133 invoked by alias); 18 Jul 2018 00:07:20 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 87112 invoked by uid 89); 18 Jul 2018 00:07:20 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=Hx-languages-length:790, his, risk X-HELO: mail-qt0-f173.google.com Return-Path: Subject: Re: [PATCH 00/10] Optimized math routines To: Joseph Myers , Szabolcs Nagy Cc: GNU C Library , nd@arm.com, Wilco Dijkstra References: <50b1b8b6-d03c-224f-31ff-8cf9d8268b6d@redhat.com> From: Carlos O'Donell Openpgp: preference=signencrypt Message-ID: <924d1400-3de5-2d2d-e776-72dcc3e2da90@redhat.com> Date: Wed, 18 Jul 2018 00:07:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-07/txt/msg00520.txt.bz2 On 07/17/2018 05:59 PM, Joseph Myers wrote: > On Fri, 6 Jul 2018, Szabolcs Nagy wrote: > >> I think I addressed all of his comments in an acceptable way, >> but i don't know if he had other concerns or if parts of the >> code he has not reviewed yet. > > The missing information in comments in previous versions effectively > prevented review of substantial parts of the code in those versions; > comments are critical information about the interfaces between different > parts of the code that are required for effective review (as well as for > subsequent maintainability of the code). > > I think these changes are far too high risk for this late in the freeze. Thanks for that review. In which case let us defer to 2.29. -- Cheers, Carlos.