From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by sourceware.org (Postfix) with ESMTPS id BAAAC3858C53 for ; Wed, 26 Apr 2023 12:20:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BAAAC3858C53 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-50506ac462bso10477631a12.3 for ; Wed, 26 Apr 2023 05:20:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682511647; x=1685103647; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=c3LrF8hULgnsEmnWANfDr1SyLwEFesd8t55X1hne4VE=; b=wUd05MPnSwAeOv+5xNapGDH2rFG36Q2kGx+MqVOqdJnPwSUouk0piopE1w6MIcjEzl lqDCt2JDzejxGJMwy3dD+znhvkrM33rXFX67VdFBCYxZrK/PGqw/wDKqzypLqATlj22I ZKZLgHwxa0Fj7U5oUhaa5n7cdKM56ed7jXM8a+GwiLfhSQ3/0RNyRTYp0BBgsKEw1taw bAxgFSgpph/Pjpij7U41PtyvnREGCtVT72VmLRbLh+mzsi2rkVdE91UtTWsWXHuMN5k5 vLXYUuq52eFHH0vaWi+eG7boaSczNzovukUHE3nOQPvCgWGcGMYDhtszOemXocPHzMPd IzUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682511647; x=1685103647; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=c3LrF8hULgnsEmnWANfDr1SyLwEFesd8t55X1hne4VE=; b=BvHOG3AeqGm+pBWu3dxP4NHX8aOrP0SyaRbFyrKgtWR7GSv3Mjq24GkpqFMRYw8fen odROndNVg/lxRWtsZPqqWDxWq6AmLK/0Gb//UCUFfFrHqlc5RnERhPs24li1hYDRigsL 7DUJpNMiZ6GwXi3K5lcE8c9O6gZbNg7AdhF+dv6gMcXiPbKUdC7w/tJEqY9LP3OG47kf XDDZnRiRW9IeW+3A0DFdpL55UxU+TEEaLvlxB86RAV/k2UT/4C/tRYUl0DTWDXWLhvBh FBEDt4JpWpfmWAX/Fc/d5mYdATto3LGMzPQtW2R9v3m6Ryu1s9YF5LlqJRdrBfrSclvH Iafg== X-Gm-Message-State: AAQBX9c01xfwFe8YdvqwOB9aHDJpIKxd0sY1lAMb/1QyGdqeVFLip0tE 4B51isYHoDy4EpB1RiXhSY70PCZD7mgM2rH5TCzZHq/qWkc= X-Google-Smtp-Source: AKy350Z9TtiO19XLgl3P13xWeHHKx37P6TnWKjWUcsNI1Ye6i/OAqhbcBCR5s7nNsMxrCQLnSM5qxA== X-Received: by 2002:a17:907:3d5:b0:953:43a1:1988 with SMTP id su21-20020a17090703d500b0095343a11988mr12274521ejb.46.1682511647390; Wed, 26 Apr 2023 05:20:47 -0700 (PDT) Received: from [172.23.2.203] ([31.221.30.162]) by smtp.gmail.com with ESMTPSA id gq18-20020a170906e25200b0094eeda0df09sm8182935ejb.179.2023.04.26.05.20.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Apr 2023 05:20:46 -0700 (PDT) Message-ID: <9322cad4-ac66-de2d-dc9f-448423b6c001@linaro.org> Date: Wed, 26 Apr 2023 13:20:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 1/1] document posix_openpt Content-Language: en-US To: Gavin Smith Cc: libc-alpha@sourceware.org References: <7f02fefd-374c-595b-e5f8-612f81c41bff@linaro.org> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-13.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 23/04/23 06:35, Gavin Smith wrote: > On Wed, Apr 19, 2023 at 09:43:01AM -0300, Adhemerval Zanella Netto wrote: > >> LGTM, I am just no sure which standard to use. >> >>> >>> diff --git a/manual/terminal.texi b/manual/terminal.texi >>> index 7293bfb393..bdaee56053 100644 >>> --- a/manual/terminal.texi >>> +++ b/manual/terminal.texi >>> @@ -1947,6 +1947,33 @@ This subsection describes functions for allocating a pseudo-terminal, >>> and for making this pseudo-terminal available for actual use. These >>> functions are declared in the header file @file{stdlib.h}. >>> >>> +@deftypefun int posix_openpt (int @var{flags}) >>> +@standards{POSIX.1, stdlib.h} >> >> Shouldn't it be POSIX.2, since it is define for _XOPEN_SOURCE >= 600? > > I got from the "feature_test_macros" manpage: > > (Since glibc 2.2) The value 600 or greater additionally ex‐ > poses definitions for SUSv3 (UNIX 03; i.e., the POSIX.1-2001 > base specification plus the XSI extension) and C99 defini‐ > tions. > > This is why I thought "POSIX.1" was the most appropriate. > > POSIX.2 is mentioned in the libc manual, but it doesn't appear to cover > pseudo-terminal functionality: > > Some facilities from ‘ISO/IEC 9945-2:1993, the POSIX Shell and > Utilities standard’ (POSIX.2) are also implemented in the GNU C Library. > These include utilities for dealing with regular expressions and other > pattern matching facilities > > Existing uses of @standards{POSIX.2, ...} in the manual are consistent > with this. > > './summary.pl --help' doesn't offer any further guidance The posix_openpt was originally added with XPG6 XSI (__USE_XOPEN2KXSI), which I think it indeed falls on POSIX.1 (although for 2008). So I think it is correct. I will apply this patch, thanks.