* [PATCH] build-many-glibcs.py: Use make -O for more consistent log output
@ 2021-02-19 16:49 Florian Weimer
2021-02-19 21:14 ` Carlos O'Donell
0 siblings, 1 reply; 2+ messages in thread
From: Florian Weimer @ 2021-02-19 16:49 UTC (permalink / raw)
To: libc-alpha
The -O option avoids interleaving (e.g.) compiler error messages
with other build messages, and makes attribute of messages to
commands easier.
According to my tests, the impact on build time is within the noise.
---
scripts/build-many-glibcs.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/build-many-glibcs.py b/scripts/build-many-glibcs.py
index 071f338cbb..8d97320f6d 100755
--- a/scripts/build-many-glibcs.py
+++ b/scripts/build-many-glibcs.py
@@ -670,7 +670,7 @@ class Context(object):
def do_build(self):
"""Do the actual build."""
- cmd = ['make', '-j%d' % self.parallelism]
+ cmd = ['make', '-O', '-j%d' % self.parallelism]
subprocess.run(cmd, cwd=self.builddir, check=True)
def build_host_libraries(self):
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] build-many-glibcs.py: Use make -O for more consistent log output
2021-02-19 16:49 [PATCH] build-many-glibcs.py: Use make -O for more consistent log output Florian Weimer
@ 2021-02-19 21:14 ` Carlos O'Donell
0 siblings, 0 replies; 2+ messages in thread
From: Carlos O'Donell @ 2021-02-19 21:14 UTC (permalink / raw)
To: Florian Weimer, libc-alpha
On 2/19/21 11:49 AM, Florian Weimer via Libc-alpha wrote:
> The -O option avoids interleaving (e.g.) compiler error messages
> with other build messages, and makes attribute of messages to
> commands easier.
>
> According to my tests, the impact on build time is within the noise.
>
> ---
> scripts/build-many-glibcs.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/build-many-glibcs.py b/scripts/build-many-glibcs.py
> index 071f338cbb..8d97320f6d 100755
> --- a/scripts/build-many-glibcs.py
> +++ b/scripts/build-many-glibcs.py
> @@ -670,7 +670,7 @@ class Context(object):
>
> def do_build(self):
> """Do the actual build."""
> - cmd = ['make', '-j%d' % self.parallelism]
> + cmd = ['make', '-O', '-j%d' % self.parallelism]
> subprocess.run(cmd, cwd=self.builddir, check=True)
>
> def build_host_libraries(self):
>
LGTM. Defaults to deinterlacing the output from the entire recipe (target).
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
--
Cheers,
Carlos.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-19 21:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-19 16:49 [PATCH] build-many-glibcs.py: Use make -O for more consistent log output Florian Weimer
2021-02-19 21:14 ` Carlos O'Donell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).