From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id BECD4398B873 for ; Fri, 19 Feb 2021 21:14:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BECD4398B873 Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-563-qe0QxCkvPPiWDSKollexBQ-1; Fri, 19 Feb 2021 16:14:08 -0500 X-MC-Unique: qe0QxCkvPPiWDSKollexBQ-1 Received: by mail-qt1-f197.google.com with SMTP id p20so4106759qtn.23 for ; Fri, 19 Feb 2021 13:14:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Sl72kauE0ynzNwnRCEBTwd1ak6aGD+qKRYkwhXp3dgE=; b=neX7Pgb35AV1rOUe5DXWIQYO6UKAu3BImr4lCWqyWoxtSw2Vyn1hHkxb6h54eqTJ76 cPYEz/efxdRAhlOesyf5NmbTMi++uHcLqt55HCwkqYy/oDwRj7QCJD0w4Ux+3joKQB7S Dc1vRDv2U+D56hITesOsqGlVwMrrOfN8Mwok/HDcJkENjxTUQvGblaowsezF28kdL43z kMHbe0uJOzWNrZg+sm65Wkb+qxikwZLVWjkCDN6ExDfv/DTNQtXxhDp1KdCBZnU2GVYO IQKIojJbdbqTVxyV5WOt0E2XSpw+U/P/SUbaUUZ5JIRVslp443jMbvHONckRk1CJw/yK 1Aww== X-Gm-Message-State: AOAM5306+sfpgWZpA1F/dUlgD7bTjNl+JIFZOJUaunC1bDeg35hdqGCw 5dbFc0Y1/lAVUP5D+GFlLjBFJ5GZVYlMms1IFcVWGsmTQNbI2T561vblAHgEc2HSba/QB4kEbl/ iNe7epi/g2V4If7ZsiaZSVAJ1MbdSeFNGcbZkcXwbzRFGYop92j027oWdRmDKgO5Ya03stw== X-Received: by 2002:a37:aa4b:: with SMTP id t72mr11578816qke.365.1613769247525; Fri, 19 Feb 2021 13:14:07 -0800 (PST) X-Google-Smtp-Source: ABdhPJxid/Rvk4XALXi1JPKFONvDxR+D0RR0LZZYn2p7l3lyWcvUC20Nq1hBC+l65KyLT/uVdXFOEA== X-Received: by 2002:a37:aa4b:: with SMTP id t72mr11578801qke.365.1613769247318; Fri, 19 Feb 2021 13:14:07 -0800 (PST) Received: from [192.168.1.16] (198-84-214-74.cpe.teksavvy.com. [198.84.214.74]) by smtp.gmail.com with ESMTPSA id q6sm7087733qkd.41.2021.02.19.13.14.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Feb 2021 13:14:06 -0800 (PST) Subject: Re: [PATCH] build-many-glibcs.py: Use make -O for more consistent log output To: Florian Weimer , libc-alpha@sourceware.org References: <87eehc9f4n.fsf@oldenburg.str.redhat.com> From: Carlos O'Donell Organization: Red Hat Message-ID: <9323419b-f0e4-e64d-d41e-b30dd0172796@redhat.com> Date: Fri, 19 Feb 2021 16:14:05 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <87eehc9f4n.fsf@oldenburg.str.redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Feb 2021 21:14:13 -0000 On 2/19/21 11:49 AM, Florian Weimer via Libc-alpha wrote: > The -O option avoids interleaving (e.g.) compiler error messages > with other build messages, and makes attribute of messages to > commands easier. > > According to my tests, the impact on build time is within the noise. > > --- > scripts/build-many-glibcs.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/build-many-glibcs.py b/scripts/build-many-glibcs.py > index 071f338cbb..8d97320f6d 100755 > --- a/scripts/build-many-glibcs.py > +++ b/scripts/build-many-glibcs.py > @@ -670,7 +670,7 @@ class Context(object): > > def do_build(self): > """Do the actual build.""" > - cmd = ['make', '-j%d' % self.parallelism] > + cmd = ['make', '-O', '-j%d' % self.parallelism] > subprocess.run(cmd, cwd=self.builddir, check=True) > > def build_host_libraries(self): > LGTM. Defaults to deinterlacing the output from the entire recipe (target). Reviewed-by: Carlos O'Donell -- Cheers, Carlos.