From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id C0D293839073 for ; Tue, 30 Aug 2022 14:18:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C0D293839073 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661869119; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/wDb5f9Wvnc9tthJVyMLbtHaTtvKBuFrNOilNDCsKms=; b=a8mmP1jUKq25FbZodqENexXQ73rv3NX6WlfhZnrpUZCObWkqs+7kNEhI6dJmOqRbTc3GYt ig0gdrsCP27f5gL0pOjyOeKqZC9LpPwNtelZkoeII1Uw+0xl6ICq7MYaIVEc4jJWKOHJ6V P0aMVwBV8HDeIJerjkNpsGdAGxPOwEA= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-591-gFjUp_FzMtK0UvuWWRVfYQ-1; Tue, 30 Aug 2022 10:18:38 -0400 X-MC-Unique: gFjUp_FzMtK0UvuWWRVfYQ-1 Received: by mail-qt1-f198.google.com with SMTP id v13-20020a05622a188d00b00343794bd1daso8966054qtc.23 for ; Tue, 30 Aug 2022 07:18:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=/wDb5f9Wvnc9tthJVyMLbtHaTtvKBuFrNOilNDCsKms=; b=x55pfUyPeb3IeCmArkeYWEHONTeLpZ0mcdq6NApZc2LlG+2u+q1NAUJlgjyRrD27Pz zSSWM3YUWwvxoEMnoBBYFwCs/MrDm37YtoTbSIE5UJNFnvw8tGNobl5PhzABA6kgcjDH 2Oc8S2YedItm/DCgM/GqT+fklH6xMxPzjpgdUqzAc3Jp7p9UePlsnHZAr0w1UP8t31e5 eNOe6ZYTp5TPI1xeyfWNfX4hRkrGd5UqwboIvdVwKj9CDb+yYXYyZzu1gEsU/jJjLEgf kT3TbXQBSNrxkrMDcZwUjHNoxyw6hsIg6M8Os56df7UufP4+O2pZOqTVDVp7ENc8cCjc 5f1A== X-Gm-Message-State: ACgBeo2CCkN7JUiHh02doQZ7vCTeNcwZg2bTPvEGTJJ1kZIItvX23pSN XlSzwpG3PgOpgDDNKNMckq/axRylHgkMOer2aCEu/PGO+PgVnlxOkB4CnRWGejLrQJrFvy9xpoC VX4KpXywx+xEtq7gaiTb2 X-Received: by 2002:ac8:594d:0:b0:343:713b:d266 with SMTP id 13-20020ac8594d000000b00343713bd266mr14508701qtz.295.1661869116198; Tue, 30 Aug 2022 07:18:36 -0700 (PDT) X-Google-Smtp-Source: AA6agR6DcjM9CWtzUFcPCBlqOn9iXixAW9aXtaoHWmyr2TU+0roCqgQUf5HPwLIDV7vx4MDyZIo83A== X-Received: by 2002:ac8:594d:0:b0:343:713b:d266 with SMTP id 13-20020ac8594d000000b00343713bd266mr14508680qtz.295.1661869115964; Tue, 30 Aug 2022 07:18:35 -0700 (PDT) Received: from [192.168.0.241] (192-0-145-146.cpe.teksavvy.com. [192.0.145.146]) by smtp.gmail.com with ESMTPSA id x24-20020a05620a0b5800b006bb568016easm7999754qkg.116.2022.08.30.07.18.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Aug 2022 07:18:34 -0700 (PDT) Message-ID: <933ac04b-5d33-c482-67a6-ce176f3170a7@redhat.com> Date: Tue, 30 Aug 2022 10:18:33 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] m68: Enforce 4-byte alignment on internal locks (BZ #29537) To: Adhemerval Zanella , libc-alpha@sourceware.org, glaubitz@physik.fu-berlin.de References: <20220830133504.2669323-1-adhemerval.zanella@linaro.org> From: Carlos O'Donell Organization: Red Hat In-Reply-To: <20220830133504.2669323-1-adhemerval.zanella@linaro.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 8/30/22 09:35, Adhemerval Zanella via Libc-alpha wrote: > The HPPA also requires a 16-byte alignment for locks, although it is > just a historical artifact to keep compatibility with old > implementation. > --- > sysdeps/nptl/libc-lockP.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sysdeps/nptl/libc-lockP.h b/sysdeps/nptl/libc-lockP.h > index d3a6837fd2..9efe962588 100644 > --- a/sysdeps/nptl/libc-lockP.h > +++ b/sysdeps/nptl/libc-lockP.h > @@ -34,7 +34,7 @@ > #include > > /* Mutex type. */ > -typedef int __libc_lock_t; > +typedef int __libc_lock_t __LOCK_ALIGNMENT; > typedef struct { pthread_mutex_t mutex; } __rtld_lock_recursive_t; > typedef pthread_rwlock_t __libc_rwlock_t; Are you able to verify that this doesn't change the ABI of any other structures that might have an internal lock? Normally I would use libabigail[1] before and after the patch to look for subtype size changes in public ABIs/APIs. -- Cheers, Carlos. [1] https://sourceware.org/libabigail/