From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-xa31.google.com (mail-vk1-xa31.google.com [IPv6:2607:f8b0:4864:20::a31]) by sourceware.org (Postfix) with ESMTPS id EEE033858014 for ; Thu, 18 Nov 2021 19:58:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EEE033858014 Received: by mail-vk1-xa31.google.com with SMTP id k83so4514079vke.7 for ; Thu, 18 Nov 2021 11:58:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=A+rkooNeGq8Wq4+fmSIv/R2BaQNBCCxUNHYDQxxnegI=; b=SjimxT4BXGwTtxI604CMsSiPHtU/sbs4pTMafz/k1tRDms+GbeKbZkS+u8gFIyRKN4 r62m/CM6qAop5Ilsi07mYJX5rA7u3nxitH7bE156vf9ZIuwoHfurXrvGYsxDu9+BdhVd VwtX3dA9826ZpA4cY8O02q/fXyiZ6RfF1sSlkgj8y/AMhh9JcdzgfmfPZP4Jz36SUJ6U OOyctTVg1f8EyZeMplRq3jWGk3laZ0ZDMUwgxNl7feKdDVKM9Lf2xs3PjFJIaNElJyFn aBa4SG/wnIbzJytiDV8SRBeibl+cSH5jP3ZT5j5fq/VQz7C5qUeQNKA1Sx6tjQktghoO x6bw== X-Gm-Message-State: AOAM532CPHN5ZfcMcLn0450E2Dujo1wtKMy5KR24UpJ5vuZ7ycNZj10C VndEi1VNx8Tor9GNMiTRq5yFWg== X-Google-Smtp-Source: ABdhPJyKjgoK/LXA5U1ATrQTqaeQeQawE4R7WLk8tOV1spNGbogqxRsf3TSDh6bA+OY0CnZ5Q1dVhA== X-Received: by 2002:a05:6122:ca6:: with SMTP id ba38mr108643959vkb.14.1637265483599; Thu, 18 Nov 2021 11:58:03 -0800 (PST) Received: from ?IPV6:2804:431:c7ca:66dc:202f:4b8d:b771:d283? ([2804:431:c7ca:66dc:202f:4b8d:b771:d283]) by smtp.gmail.com with ESMTPSA id s8sm488076vsk.18.2021.11.18.11.58.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Nov 2021 11:58:03 -0800 (PST) Message-ID: <939f23b1-8677-a21c-2d7f-e46df08acba2@linaro.org> Date: Thu, 18 Nov 2021 16:58:01 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Subject: Re: [PATCH v6 01/20] elf: Suppress audit calls when a (new) namespace is empty (BZ #28062) Content-Language: en-US To: Andreas Schwab , Florian Weimer Cc: Adhemerval Zanella via Libc-alpha , John Mellor-Crummey References: <20211115183734.531155-1-adhemerval.zanella@linaro.org> <20211115183734.531155-2-adhemerval.zanella@linaro.org> <87ee7hfdk7.fsf@oldenburg.str.redhat.com> <37adfe77-f066-8046-2fe4-5026d3bdac1c@linaro.org> <877dd8uscm.fsf@igel.home> <87h7ccciug.fsf@oldenburg.str.redhat.com> <87y25otcd6.fsf@igel.home> From: Adhemerval Zanella In-Reply-To: <87y25otcd6.fsf@igel.home> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Nov 2021 19:58:05 -0000 On 16/11/2021 11:16, Andreas Schwab wrote: > On Nov 16 2021, Florian Weimer wrote: > >> * Andreas Schwab: >> >>> On Nov 16 2021, Adhemerval Zanella via Libc-alpha wrote: >>> >>>> + /* Auditing checkpoint: we are going to add new objects. Since this >>>> + is called after _dl_add_to_namespace_list() the namespace is >>> >>> Not a function call here. >> >> I've stopped pointing those out in patch reviews. Is this GNU >> convention really useful? If there is no other markup, it often >> increases readability, > > You can always write "the foo function". > >> particular for identifiers that are also bona fide English words, such >> as read and close. > > Which only proves my point. Ok, I will remove the '()' and reference to just the function name.