From: Paul E Murphy <murphyp@linux.ibm.com>
To: "Gabriel F. T. Gomes" <gabriel@inconstante.net.br>,
libc-alpha@sourceware.org
Subject: Re: [PATCH v3 05/11] ldbl-128ibm-compat: Add *cvt functions
Date: Mon, 09 Dec 2019 23:13:00 -0000 [thread overview]
Message-ID: <93e57469-78a5-f1e4-e52d-9f26e6f4e5bb@linux.ibm.com> (raw)
In-Reply-To: <20191203170540.18428-6-gabriel@inconstante.net.br>
On 12/3/19 11:05 AM, Gabriel F. T. Gomes wrote:
> From: "Gabriel F. T. Gomes" <gabrielftg@linux.ibm.com>
>
> Changes since v2:
>
> - Fix http URLs.
>
> No changes since v1.
>
> -- 8< --
> This patch adds IEEE long double versions of q*cvt* functions for
> powerpc64le. Unlike all other long double to/from string conversion
> functions, these do not rely on internal functions that can take
> floating-point numbers with different formats and act on them
> accordingly, instead, the related files are rebuilt with the
> -mabi=ieeelongdouble compiler flag set.
>
> Having -mabi=ieeelongdouble passed to the compiler causes the object
> files to be marked with a .gnu_attribute that is incompatible with the
> .gnu_attribute in files built with -mabi=ibmlongdouble (the default).
> The difference causes error messages similar to the following:
>
> ld: libc_pic.a(s_isinfl.os) uses IBM long double,
> libc_pic.a(ieee128-qefgcvt_r.os) uses IEEE long double.
> collect2: error: ld returned 1 exit status
> make[2]: *** [../Makerules:649: libc_pic.os] Error 1
>
> Although this warning is useful in other situations, the library
> actually needs to have functions with different long double formats, so
> .gnu_attribute generation is explicitly disabled for these files with
> the use of -mno-gnu-attribute.
>
> Tested for powerpc64le on the branch that actually enables the
> sysdeps/ieee754/ldbl-128ibm-compat for powerpc64le.
> diff --git a/sysdeps/ieee754/ldbl-128ibm-compat/Makefile b/sysdeps/ieee754/ldbl-128ibm-compat/Makefile
> index 6d5414c54a..49d9af9fea 100644
> --- a/sysdeps/ieee754/ldbl-128ibm-compat/Makefile
> +++ b/sysdeps/ieee754/ldbl-128ibm-compat/Makefile
...
> +tests-internal += tst-ibm128-efgcvt tst-ieee128-efgcvt
Are these tests generated? I don't see tst-{ibm128,ieee128}-efgcvt.c in
this patch. The patch looks otherwise OK to me.
next prev parent reply other threads:[~2019-12-09 23:13 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 17:05 [PATCH v3 00/11] Add IEEE long double <-> string functions for powerpc64le Gabriel F. T. Gomes
2019-12-03 17:05 ` [PATCH v3 01/11] ldbl-128ibm-compat: Fix selection of GNU and ISO C99 scanf Gabriel F. T. Gomes
2019-12-09 16:46 ` Paul E Murphy
2019-12-09 16:50 ` Zack Weinberg
2019-12-09 17:09 ` Paul E Murphy
2019-12-09 18:16 ` Gabriel F. T. Gomes
2019-12-09 20:31 ` Paul E Murphy
2019-12-12 13:42 ` Gabriel F. T. Gomes
2019-12-03 17:06 ` [PATCH v3 05/11] ldbl-128ibm-compat: Add *cvt functions Gabriel F. T. Gomes
2019-12-09 23:13 ` Paul E Murphy [this message]
2019-12-13 20:03 ` Gabriel F. T. Gomes
2019-12-03 17:06 ` [PATCH v3 04/11] Refactor *cvt functions implementation (5/5) Gabriel F. T. Gomes
2019-12-03 17:06 ` [PATCH v3 09/11] ldbl-128ibm-compat: Do not mix -mabi=*longdouble and -mlong-double-128 Gabriel F. T. Gomes
2019-12-03 17:06 ` [PATCH v3 03/11] Refactor *cvt functions implementation (1-4/5) Gabriel F. T. Gomes
2019-12-09 21:25 ` Paul E Murphy
2019-12-13 20:19 ` Gabriel F. T. Gomes
2019-12-03 17:06 ` [PATCH v3 06/11] Do not redirect calls to __GI_* symbols, when redirecting to *ieee128 Gabriel F. T. Gomes
2019-12-03 17:06 ` [PATCH v3 08/11] Avoid compat symbols for totalorder in powerpc64le IEEE long double Gabriel F. T. Gomes
2019-12-03 17:06 ` [PATCH v3 02/11] ldbl-128ibm-compat: Add ISO C99 versions of scanf functions Gabriel F. T. Gomes
2019-12-09 18:09 ` Paul E Murphy
2019-12-13 21:13 ` Gabriel F. T. Gomes
2019-12-03 17:06 ` [PATCH v3 07/11] ldbl-128ibm-compat: Compiler flags for stdio functions Gabriel F. T. Gomes
2019-12-03 17:06 ` [PATCH v3 10/11] powerpc64le: Require a compiler with -mno-gnu-attribute Gabriel F. T. Gomes
2019-12-03 17:07 ` [PATCH v3 11/11] RFC: powerpc64le: Enable support for IEEE long double Gabriel F. T. Gomes
2019-12-09 23:47 ` Paul E Murphy
2019-12-13 22:41 ` Gabriel F. T. Gomes
2019-12-13 23:46 ` Paul E Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93e57469-78a5-f1e4-e52d-9f26e6f4e5bb@linux.ibm.com \
--to=murphyp@linux.ibm.com \
--cc=gabriel@inconstante.net.br \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).