From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x33.google.com (mail-oa1-x33.google.com [IPv6:2001:4860:4864:20::33]) by sourceware.org (Postfix) with ESMTPS id A68F23858D32 for ; Tue, 11 Apr 2023 17:39:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A68F23858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oa1-x33.google.com with SMTP id 586e51a60fabf-1842f69fe1fso10544432fac.11 for ; Tue, 11 Apr 2023 10:39:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681234742; x=1683826742; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=C9yvxnQBkZkWZbmdgCZpMID6Z5hu7mmexMhd/B1sQA8=; b=p76cw15XcVZoFw32iaO5Tk4qfwTRUuOGfUBiOEhPWH1e69heYfnIV+tFs/42VHi1D3 uXu8KQlKIZfQE+5f5lVDEV8LgfA6nCewSW4tglMWVUyCv2iIQZiUjBY8iJ2fuAdCjGKZ CzpQ1NlI0GjzVhNzkvOg/jnxWpFgXoRm+dG3GdPI4BmmB541QUBK1/AavjyPvvoBd3ne Yc+o5lqn9VxrtEdCmBKxbD9aK0Jp6h4Qb+LwfsjaR2ea5nF/dNaPQK7Njvf20pMEwI60 DiGs1URK+8EZXhYA2kvqXFhXL241oRU0YYnNiFuj+lXFfa1qv+amyR39bJaIN7xsnG0W /UoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681234742; x=1683826742; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=C9yvxnQBkZkWZbmdgCZpMID6Z5hu7mmexMhd/B1sQA8=; b=cxzTixSwb0sjNi0qaW52fGBqXy19+DzlNL8B4Vy8/FGc1WvtqiD9+xd6KqbqOsIFut CN22EBGrINc16MrS9Xk4R7IQO5wzda9hiyyzPXGf4VHeFrkfXcrviGH3phylM2UUrvQ8 spqZQXEZwUyohdvWVniS7nHLIFnv/L/tJRznCEo35A3/MCc6TMoA2niyo1f1Bxzw9QdL L4oRUDvGjPbAxXgPP6R8h8qustmJ+vbwqjcfEgWx4v8hPqFijyy0sNQh+i9hMfTcxj2R 0Eqq5oZWW9G1uO9oD9hfWJd2I8rvgGkU3fYioa3K9eRgI1psbNk8AJ97s3VFFldSNwHH xXBg== X-Gm-Message-State: AAQBX9fDNcfImrh1dxeR8nUnY5b27X3GYEEGt1wjNRFCKML7Ieqwil82 zW/eeAOAznyNzLHNHQVHc287u35uw8nQCHyNe7mF9Q== X-Google-Smtp-Source: AKy350ZT+ODW9Cc27l/Bhd/LZXUtxojsnPTPD/48LwY4kXZaXVk6oh8n0p0buqksbg0UQ9eqqqSCcw== X-Received: by 2002:a05:6870:420c:b0:17a:e21f:4aa4 with SMTP id u12-20020a056870420c00b0017ae21f4aa4mr7844384oac.31.1681234742350; Tue, 11 Apr 2023 10:39:02 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c2:55a1:7428:425e:4ee7:30b6? ([2804:1b3:a7c2:55a1:7428:425e:4ee7:30b6]) by smtp.gmail.com with ESMTPSA id yy26-20020a056871259a00b001728669a604sm5309768oab.5.2023.04.11.10.39.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Apr 2023 10:39:01 -0700 (PDT) Message-ID: <93efc4cb-f5a6-b04a-a4fa-60f73a4ad1e1@linaro.org> Date: Tue, 11 Apr 2023 14:38:59 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] debug: Re-flow and sort routines variable in Makefile Content-Language: en-US To: libc-alpha@sourceware.org, Florian Weimer References: <871qkxm1jg.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <871qkxm1jg.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 06/04/23 13:13, Florian Weimer via Libc-alpha wrote: > Tested on x86-64-linux-gnu. LGTM with the missing line below. Reviewed-by: Adhemerval Zanella > > --- > debug/Makefile | 110 ++++++++++++++++++++++++++++++++++++++++++++------------- > 1 file changed, 86 insertions(+), 24 deletions(-) > > diff --git a/debug/Makefile b/debug/Makefile > index 52f9a7852c..4a4b37de7a 100644 > --- a/debug/Makefile > +++ b/debug/Makefile > @@ -28,30 +28,92 @@ headers := execinfo.h > # Note that ptsname_r_chk and getlogin_r are not here, but in > # login/Makefile instead. If that subdir is omitted from the > # build, its _FORTIFY_SOURCE support will be too. > -routines = backtrace backtracesyms backtracesymsfd noophooks \ > - memcpy_chk memmove_chk mempcpy_chk memset_chk stpcpy_chk \ > - strcat_chk strcpy_chk strncat_chk strncpy_chk stpncpy_chk \ > - sprintf_chk vsprintf_chk snprintf_chk vsnprintf_chk \ > - printf_chk fprintf_chk vprintf_chk vfprintf_chk \ > - gets_chk chk_fail readonly-area fgets_chk fgets_u_chk \ > - read_chk pread_chk pread64_chk recv_chk recvfrom_chk \ > - readlink_chk readlinkat_chk getwd_chk getcwd_chk \ > - realpath_chk fread_chk fread_u_chk \ > - wctomb_chk wcscpy_chk wmemcpy_chk wmemmove_chk wmempcpy_chk \ > - wcpcpy_chk wcsncpy_chk wcscat_chk wcsncat_chk wmemset_chk \ > - wcpncpy_chk \ > - swprintf_chk vswprintf_chk wprintf_chk fwprintf_chk \ > - vwprintf_chk vfwprintf_chk fgetws_chk fgetws_u_chk \ > - confstr_chk getgroups_chk ttyname_r_chk \ > - gethostname_chk getdomainname_chk wcrtomb_chk mbsnrtowcs_chk \ > - wcsnrtombs_chk mbsrtowcs_chk wcsrtombs_chk mbstowcs_chk \ > - wcstombs_chk asprintf_chk vasprintf_chk dprintf_chk \ > - vdprintf_chk obprintf_chk vobprintf_chk \ > - longjmp_chk ____longjmp_chk \ > - fdelt_chk poll_chk ppoll_chk \ > - explicit_bzero_chk \ > - stack_chk_fail fortify_fail \ > - $(static-only-routines) > +routines = \ > + ____longjmp_chk \ > + asprintf_chk \ > + backtrace \ > + backtracesyms \ > + backtracesymsfd \ > + chk_fail \ > + confstr_chk \ > + dprintf_chk \ > + explicit_bzero_chk \ > + fdelt_chk \ > + fgets_chk \ > + fgets_u_chk \ > + fgetws_chk \ > + fgetws_u_chk \ > + fprintf_chk \ > + fread_chk \ > + fread_u_chk \ > + fwprintf_chk \ > + getcwd_chk \ > + getdomainname_chk \ > + getgroups_chk \ > + gethostname_chk \ > + gets_chk \ > + getwd_chk \ > + longjmp_chk \ > + mbsnrtowcs_chk \ > + mbsrtowcs_chk \ > + mbstowcs_chk \ > + memcpy_chk \ > + memmove_chk \ > + mempcpy_chk \ > + memset_chk \ > + noophooks \ > + obprintf_chk \ > + poll_chk \ > + ppoll_chk \ > + pread64_chk \ > + pread_chk \ > + printf_chk \ > + read_chk \ > + readlink_chk \ > + readlinkat_chk \ > + readonly-area \ > + realpath_chk \ > + recv_chk \ > + recvfrom_chk \ > + snprintf_chk \ > + sprintf_chk \ > + stack_chk_fail fortify_fail \ Here. > + stpcpy_chk \ > + stpncpy_chk \ > + strcat_chk \ > + strcpy_chk \ > + strncat_chk \ > + strncpy_chk \ > + swprintf_chk \ > + ttyname_r_chk \ > + vasprintf_chk \ > + vdprintf_chk \ > + vfprintf_chk \ > + vfwprintf_chk \ > + vobprintf_chk \ > + vprintf_chk \ > + vsnprintf_chk \ > + vsprintf_chk \ > + vswprintf_chk \ > + vwprintf_chk \ > + wcpcpy_chk \ > + wcpncpy_chk \ > + wcrtomb_chk \ > + wcscat_chk \ > + wcscpy_chk \ > + wcsncat_chk \ > + wcsncpy_chk \ > + wcsnrtombs_chk \ > + wcsrtombs_chk \ > + wcstombs_chk \ > + wctomb_chk \ > + wmemcpy_chk \ > + wmemmove_chk \ > + wmempcpy_chk \ > + wmemset_chk \ > + wprintf_chk \ > + $(static-only-routines) \ > + # routines > static-only-routines := stack_chk_fail_local > > # Don't add stack_chk_fail_local.o to libc.a since __stack_chk_fail_local > > base-commit: 0d5cb2ae27c0a163c15e5222fb132bf9d026b14b >