From: Paul E Murphy <murphyp@linux.ibm.com>
To: Raphael M Zinsly <rzinsly@linux.ibm.com>,
libc-alpha@sourceware.org,
Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
Subject: Re: [PATCHv5] powerpc64le: ifunc select *f128 routines in multiarch mode
Date: Tue, 1 Dec 2020 08:24:40 -0600 [thread overview]
Message-ID: <93f8ecae-0697-ed82-6522-374a75961abd@linux.ibm.com> (raw)
In-Reply-To: <4ed32327-5395-dff2-1add-6b3b5b0fc721@linux.ibm.com>
On 11/30/20 11:00 AM, Raphael M Zinsly wrote:
> On 02/11/2020 12:27, Paul E. Murphy via Libc-alpha wrote:
>> Programatically generate simple wrappers for interesting libm *f128
>> objects. Selected functions are transcendental functions or
>> those with trivial compiler builtins. This can result in a 2-3x
>> speedup (e.g logf128 and expf128).
>>
>> A second set of implementation files are generated which include
>> the first implementation encountered along the search path. This
>> usually works, except when a wrapper is overriden and makefile
>> search order slightly diverges from include order. Likewise,
>> wrapper object files are created for each generated file. These
>> hold the ifunc selection routines which export ABI.
>>
>> Next, several shared headers are intercepted to control renaming of
>> asm function redirects are used first, and sometimes macro renames
>> if the former is impractical.
>>
>> Notably, if the request machine supports hardware IEEE128 (i.e POWER9
>> and newer) this ifunc machinery is disabled. Likewise existing
>> ifunc support for float128 is consolidated into this (e.g sqrtf128
>> and fmaf128).
>
>
> LGTM, I tested on POWER8 and POWER9.
>
Pushed. Thank you all for the feedback.
prev parent reply other threads:[~2020-12-01 14:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-02 15:27 Paul E. Murphy
2020-11-19 19:53 ` Tulio Magno Quites Machado Filho
2020-11-30 17:00 ` Raphael M Zinsly
2020-12-01 14:24 ` Paul E Murphy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93f8ecae-0697-ed82-6522-374a75961abd@linux.ibm.com \
--to=murphyp@linux.ibm.com \
--cc=libc-alpha@sourceware.org \
--cc=rzinsly@linux.ibm.com \
--cc=tuliom@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).