From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id D17663857C79 for ; Tue, 7 Jul 2020 07:44:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D17663857C79 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0677XNoA082596 for ; Tue, 7 Jul 2020 03:44:54 -0400 Received: from ppma04ams.nl.ibm.com (63.31.33a9.ip4.static.sl-reverse.com [169.51.49.99]) by mx0a-001b2d01.pphosted.com with ESMTP id 324hfqnf8t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 07 Jul 2020 03:44:53 -0400 Received: from pps.filterd (ppma04ams.nl.ibm.com [127.0.0.1]) by ppma04ams.nl.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 0677UOdE025769 for ; Tue, 7 Jul 2020 07:44:51 GMT Received: from b06avi18626390.portsmouth.uk.ibm.com (b06avi18626390.portsmouth.uk.ibm.com [9.149.26.192]) by ppma04ams.nl.ibm.com with ESMTP id 322hd7u501-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 07 Jul 2020 07:44:51 +0000 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 0677hSKP63111618 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 7 Jul 2020 07:43:28 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 28C9A4C058 for ; Tue, 7 Jul 2020 07:44:49 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1126A4C046 for ; Tue, 7 Jul 2020 07:44:49 +0000 (GMT) Received: from oc4452167425.ibm.com (unknown [9.145.60.183]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP for ; Tue, 7 Jul 2020 07:44:48 +0000 (GMT) Subject: Re: [PATCH] Fix stringop-overflow errors from gcc 10 in iconv. To: libc-alpha@sourceware.org References: <20200616122420.5175-1-stli@linux.ibm.com> <42e031ef-2fd0-845a-4469-4d150e0608bf@redhat.com> From: Stefan Liebler Message-ID: <94508703-9159-169e-7fba-091af18ae55c@linux.ibm.com> Date: Tue, 7 Jul 2020 09:44:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <42e031ef-2fd0-845a-4469-4d150e0608bf@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-07-07_05:2020-07-07, 2020-07-07 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 impostorscore=0 clxscore=1015 cotscore=-2147483648 lowpriorityscore=0 adultscore=0 mlxlogscore=999 priorityscore=1501 phishscore=0 mlxscore=0 spamscore=0 suspectscore=1 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2007070058 X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jul 2020 07:44:56 -0000 On 7/6/20 5:03 PM, Carlos O'Donell wrote: > On 7/6/20 10:30 AM, Stefan Liebler wrote: >> On 6/26/20 8:00 PM, Matheus Castanho wrote: >>> Hi Stefan, >>> >>> On 6/16/20 9:24 AM, Stefan Liebler via Libc-alpha wrote: >>>> On s390x, I've recognize various -Werror=stringop-overflow messages >>>> in iconv/loop.c and iconv/skeleton.c if build with gcc10 -O3. >>>> >>>> With this commit gcc knows the size and do not raise those errors anymore. ... >>>> >>> >>> >>> Thanks for working on this! I also noticed this same issue on power. >>> This patch indeed fixes it there as well. >>> >>> As for the patch, I'm not that familiar with iconv code, but by checking >>> the modified snippet, the loops seem equivalent and the pointers are >>> properly modified as before. So it's mostly harmless, basically >>> rewriting those lines in a different way to please GCC. >>> >>> LGTM. >>> >>> -- >>> Matheus Castanho >>> >> >> @Carlos: Is this patch okay to commit before the release? > > Yes, this doesn't change ABI/API and fixes compiles with gcc 10. > > It is not subject to the ABI/API freeze currently in effect. > > Please do continue to fix bugs and enable operation with the > latest released upstream toolchains. > Committed. Thanks. Stefan