From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 62222 invoked by alias); 9 Sep 2017 11:56:33 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 62209 invoked by uid 89); 9 Sep 2017 11:56:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: mail-wm0-f44.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=qPZuSDM2+DwiM4cUQa/5mnrQFPtfSXvKo9BmAY+DlAo=; b=oyHsVP6Lo5mKmqhb6cCvBRpj7QZdIqtecRQ6SB1hZWa/K0OATfy5kzwWLOSVQwnccl 7OPo83BjdGSVlAghh2813sAVQP7+BTtHf1RTnKE6SmD6z76ufHlov0M3I7owZbYu2uB9 ZivOBHrguTlEcEogSErhdmNgGY2TwNauxOQZqCwtWWEMJOEiYdN4VAP+1Ci6IaHHAeHp XcfQniis8RJGB5E/da++zvzOo80+vt/YktJBOIc9z7VFPW9Ng71gMhpLuVrTfMtG43PG ntGCm3SOsw9D7ImtgGgnZ7kr6LPRuVcvPKZS9UIxdAZvOD4CWZw09d5vRwor2KQW1Lo4 ObVA== X-Gm-Message-State: AHPjjUg1nzSZMLcsk8vNIRpDibGvNeq5d9MApYQRNDuXkf3bQLaK80lU 4PdPCKID61XAfdIqTDKMdJIgCA== X-Google-Smtp-Source: AOwi7QAQ6u57t8yqa6ShSJqPIYwe1lRMfZ5KSNAHc8v/nA0ffnO7uitA9z3VKn+vJOzjl6B7BPh7BA== X-Received: by 10.28.143.208 with SMTP id r199mr3821438wmd.39.1504958187690; Sat, 09 Sep 2017 04:56:27 -0700 (PDT) Subject: Re: [PATCH 3/9] posix: Allow glob to match dangling symlinks [BZ #866] To: Andreas Schwab Cc: libc-alpha@sourceware.org, Paul Eggert References: <1504643122-14874-1-git-send-email-adhemerval.zanella@linaro.org> <1504643122-14874-4-git-send-email-adhemerval.zanella@linaro.org> <878thop5fa.fsf@linux-m68k.org> From: Adhemerval Zanella Message-ID: <9455e298-8c48-c42a-0ec3-ffb8d166c69b@linaro.org> Date: Sat, 09 Sep 2017 11:56:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <878thop5fa.fsf@linux-m68k.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2017-09/txt/msg00410.txt.bz2 I give you that we should properly document what GLOB_ALTDIRFUNC expects for partially initialized glob_t alternative functions, but currenyl glob code assumes that if GLOB_ALTDIRFUNC is set then glob_t function pointers actually points to valid implementation. So I think this is essentially a make issue. And since make also packs its own glob copy from gnulib, it is matter to fix on make if and when it syncs with gnulib. On 09/09/2017 11:50, Andreas Schwab wrote: > This breaks make, it doesn't expect that glob calls gl_lstat. > > dir_setup_glob: > > /* We don't bother setting gl_lstat, since glob never calls it. > The slot is only there for compatibility with 4.4 BSD. */ > > Andreas. >