From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x22d.google.com (mail-oi1-x22d.google.com [IPv6:2607:f8b0:4864:20::22d]) by sourceware.org (Postfix) with ESMTPS id E6D173858030 for ; Tue, 25 Jan 2022 11:33:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E6D173858030 Received: by mail-oi1-x22d.google.com with SMTP id bb37so30389306oib.1 for ; Tue, 25 Jan 2022 03:33:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=YFWb+flAx8BncKaCqEDkpKGQeVzEcTmEwA2IrAaoggg=; b=5B/NtS72hlCNVIiBMVJ8Mhib4/a2s1YqNHnxuKGrIDmx5ncaYmZOLQo0mzBMb8sP3A A+Hq5tFH2W3PlX3C9thWSX/0CL9JR3Uv3sqtYE4P1qY5MLLp5rdPy1il6/+tAUEeFX8Y /CNz8vjrGw/eOJVPY9nhX6lOp/yxRpVBtXzog+yJ0uist7Q+hzGYOjwTp5BwZLyssuo1 33M+Z7QGiA63cNvSCk5AGDqkPK4FzxXGVcoCfUf2v+G4QLoe9kfCIYkV6VNFZ/XO3eF7 qAOMhyoiZlW/aT8DNJnikhRJSIoyF8CLYYz9NylDI9Zt+W2d2/NpxyC++2dXtrwvSga6 39kg== X-Gm-Message-State: AOAM531SYEma++e0AELidvLZxdRMDpyEiUWFplgi928p6n/C7aj+cQRK pnYNzHWRFcvP0F/uf1UyhJqVgQ== X-Google-Smtp-Source: ABdhPJxSscUL47PjVMed63wi8rt2BAvnTR4QixS5Wz+cWCD+QQlkEdzprtsqhbRImPNRYl989CbEnQ== X-Received: by 2002:a05:6808:1244:: with SMTP id o4mr322097oiv.239.1643110401262; Tue, 25 Jan 2022 03:33:21 -0800 (PST) Received: from ?IPV6:2804:431:c7cb:27f8:71c4:5be1:86bc:bfd5? ([2804:431:c7cb:27f8:71c4:5be1:86bc:bfd5]) by smtp.gmail.com with ESMTPSA id h1sm6672962otb.58.2022.01.25.03.33.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Jan 2022 03:33:20 -0800 (PST) Message-ID: <945e3c11-1285-2227-faa3-ce5e764fc3ff@linaro.org> Date: Tue, 25 Jan 2022 08:33:18 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v9 1/3] elf: Add a test for PT_LOAD segments with mixed p_align [BZ #28676] Content-Language: en-US To: Joseph Myers Cc: "H.J. Lu" , libc-alpha@sourceware.org, Florian Weimer References: <20220121211205.268178-1-hjl.tools@gmail.com> <20220121211205.268178-2-hjl.tools@gmail.com> <812466f3-14b4-e9af-9f97-35707c4bd111@linaro.org> From: Adhemerval Zanella In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Jan 2022 11:33:23 -0000 On 24/01/2022 18:21, Joseph Myers wrote: > On Mon, 24 Jan 2022, Adhemerval Zanella via Libc-alpha wrote: > >>> +# Make a copy of tst-p_alignmod-base.so and lower p_align of the first >>> +# PT_LOAD segment. >>> +$(objpfx)tst-p_alignmod1.so: $(objpfx)tst-p_alignmod1-edit \ >>> + $(objpfx)tst-p_alignmod-base.so >>> + rm -f $@ >>> + cp $(objpfx)tst-p_alignmod-base.so $@ >>> + $(test-wrapper-env) $(run-program-env) $(rtld-prefix) \ >>> + $(objpfx)tst-p_alignmod1-edit $@ > > This has broken the testsuite build for all cross-compilation situations > not running the newly built tests. You can't run a program built with the > new glibc unless $(run-built-tests) is yes. Either disable everything > depending on running these programs unless $(run-built-tests) is yes or > revert the commits adding them (reimplementing the editing in Python using > only the standard library might be a possibility for the future; building > the C program for $build wouldn't be a good idea and we'd like to phase > out the remaining two tests that do use C programs for $build by subsuming > them in conformtest). > I forgot about this issue and reimplementing using pythong seems a better approach. I will work on this.