From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 8E2B23857737 for ; Tue, 20 Jun 2023 16:20:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8E2B23857737 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35KGBjv4013203 for ; Tue, 20 Jun 2023 16:20:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=Jf0YHxPb5qik2tZ8iewaUaH87MClKwM6agXeHU3W2jI=; b=oQuZ5AjnA7N5Za3UJmkdMnuKQAVmThkCMQGSKrl1/UwpvKkaccdyELOXdCeEnxrYq4ae RGuazcdBEZ6iqQQsCqlKp+qtkA9SSfSz5EHbycAfobS9HgWMA+z8w+FuZblyodQQt/zw EFIGm4kFdgjcOd6cjHhR2Gpl/FbFwRt43ImEU5wY591j7QXGRv0fTqK/j5qWXoXz1SnA BGj1YRKpVEHKnSMSs5dOhSfHP+tGxpr/nOGL3gqsb7z660fUVh3B3jD3byd6CNJNRxMi MrlGQriSq2WxSuxR27ognFmyrqLHsLnob/zCIaBteVmq87rlaeyE4kFb0mtLZInFg0Ce eA== Received: from ppma03dal.us.ibm.com (b.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.11]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3rbfdxg7y2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 20 Jun 2023 16:20:10 +0000 Received: from pps.filterd (ppma03dal.us.ibm.com [127.0.0.1]) by ppma03dal.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 35K8vhQP006311 for ; Tue, 20 Jun 2023 16:20:09 GMT Received: from smtprelay06.wdc07v.mail.ibm.com ([9.208.129.118]) by ppma03dal.us.ibm.com (PPS) with ESMTPS id 3r94f5d71m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 20 Jun 2023 16:20:09 +0000 Received: from smtpav03.wdc07v.mail.ibm.com (smtpav03.wdc07v.mail.ibm.com [10.39.53.230]) by smtprelay06.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 35KGK68a65405356 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 20 Jun 2023 16:20:07 GMT Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D973258064; Tue, 20 Jun 2023 16:20:06 +0000 (GMT) Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 49DD15805D; Tue, 20 Jun 2023 16:20:06 +0000 (GMT) Received: from [9.61.112.239] (unknown [9.61.112.239]) by smtpav03.wdc07v.mail.ibm.com (Postfix) with ESMTP; Tue, 20 Jun 2023 16:20:06 +0000 (GMT) Message-ID: <94be5917-3607-6e45-115f-a2f6db95b321@linux.ibm.com> Date: Tue, 20 Jun 2023 11:20:05 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] PowerPC: Influence hwcaps via cpu arch-level GLIBC_TUNABLES. Content-Language: en-US To: bmahi496@linux.ibm.com, libc-alpha@sourceware.org Cc: rajis@linux.ibm.com, Mahesh Bodapati References: <20230619080956.3187040-1-bmahi496@linux.ibm.com> From: Peter Bergner In-Reply-To: <20230619080956.3187040-1-bmahi496@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: IJ3IaNeKgTHrC2HyGqKZ2ct8NU1OJQZL X-Proofpoint-ORIG-GUID: IJ3IaNeKgTHrC2HyGqKZ2ct8NU1OJQZL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-20_12,2023-06-16_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 mlxlogscore=699 priorityscore=1501 bulkscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 spamscore=0 phishscore=0 mlxscore=0 clxscore=1015 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306200145 X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/19/23 3:09 AM, bmahi496--- via Libc-alpha wrote: > This patch enables the option to influence hwcaps used by the powerpc. > The user can set a CPU arch-level tunable like power10 instead of single > HWCAP features. > > The influenced hwcap are stored in the powerpc-specific cpu_features struct. > > Below are the supported cpu arch-level tunables. > - power10: power10 feature set > - power9: power9 feature set > - power8: power8 feature set > - power7: power7 feature set > - power6: power6 feature set > - power5: power5 feature set > - power4: power4 feature set. I'm all for allowing modifying full cpu specific hwcap tunables with one "cpu" option, but it's hard to tell whether this change allows modifying single HWCAP/HWCAP2 features too. Say I only want to disable the VSX feature or the MMA feature and nothing else. Does this patch support that? We *do* want that ability! > + /* we don't disable altivec and vsx */ This is not a correctly formatted sentence with proper capitalization, etc. > + if (disable_vsx) > + cpu_features_curr.hwcap &= ~PPC_FEATURE_HAS_VSX; Why the special handling for the VSX feature here? How is it different than say the Altivec feature or any of our other feature bits which don't have special handling? It's not obvious to me why we need special handling, so it's probably not obvious to others either. If we really do need special handling for this, you should add a comment explaining why. > + /* Copy back the supported tunable features */ Missing a '.' and 2 spaces before the */ Peter