From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x233.google.com (mail-oi1-x233.google.com [IPv6:2607:f8b0:4864:20::233]) by sourceware.org (Postfix) with ESMTPS id 6469A3858D33 for ; Tue, 10 Jan 2023 18:19:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6469A3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oi1-x233.google.com with SMTP id r205so10785742oib.9 for ; Tue, 10 Jan 2023 10:19:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=ocWmIMKpB9v5Ysp1LjPYrB4P2QOMFZOwDqCOoyw8kxQ=; b=jKK9Edbc6dxbZ2f2pgzvDc1DbaVj1E1V+jd6OeOHqs7GmMN0Z96cyTCG9XLJ0XUtxX w4GfASkPM6wu7OFGRC5bP248vW+74efu2yMzn4adb5BcZRT8pxKrYIiGlw0Uq5QeZCp/ jVdo6HNIcaJvKp5EWfL1cIemDP5SDg5K62Lz23jJzm0F7ISJolwj0vbDWICRMkP38DLG 9iWL+93wdAzeAFisCFShsgYCxXog980AdDFNLlbcW7mUaXPSo+ofdlE72yNXKW3e4tNE dI1tteKIvBnnzRwkLZlW66Y+Qm6j9U0HCI+KR8FzFyknURMtr+i57WDVZ5X2l0XY8Vnv Gvtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ocWmIMKpB9v5Ysp1LjPYrB4P2QOMFZOwDqCOoyw8kxQ=; b=JcSjQepsj+fnV7ytxMhFTFagEwZrt19Htprflv5WJgjpu7g3On+EtS9NB2FMKJXhlw gVNwgZlKp9cAoahBteXaGEt8Ly3h8KuJS4VfrbuK8SLd5E4ADsFm2lRJ85/wP8VV7G4m ICTpcXSFf3KuHvSvDwB9huSiOHbezd8rJ/FMDeBK2VVO1AHYEF4cucroKMpQFDUtTgp+ Le0J1Rbr9U8VINVh0vovFvM131faPtMO2ngnH1BHHDe5NayuBYWLB6gIjQsX4EgKfpt1 aD+mf8a1yTzrCkLJW6dZKjruNL3yTyL9v+Y/FshxVIHhN3SVoAEyn1h3B+8ROy7siZEL qG1Q== X-Gm-Message-State: AFqh2koy+mXoSsZ1FFpXsYQduicmIOfvJopJU7Bw+Aw0KZz3zdZWYlI8 Af1QOjVTSS+7dxbhTo0ZQukj1A== X-Google-Smtp-Source: AMrXdXuyKTZy1mNLGNCQTIESYQp0icwvog0atIxoXFfor/NsLY7K6SlqoocUzrwZguvxHCTku0L3Pw== X-Received: by 2002:aca:c187:0:b0:361:bf9:ce47 with SMTP id r129-20020acac187000000b003610bf9ce47mr27994768oif.49.1673374751659; Tue, 10 Jan 2023 10:19:11 -0800 (PST) Received: from ?IPV6:2804:1b3:a7c0:a93a:8d00:c4d9:6d86:9f2b? ([2804:1b3:a7c0:a93a:8d00:c4d9:6d86:9f2b]) by smtp.gmail.com with ESMTPSA id j20-20020a056830271400b00684152e9ff2sm2138023otu.0.2023.01.10.10.19.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Jan 2023 10:19:10 -0800 (PST) Message-ID: <94c253ec-7a99-0e6a-5714-e67267ce88c9@linaro.org> Date: Tue, 10 Jan 2023 15:19:08 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v5 08/17] string: Improve generic strchrnul Content-Language: en-US To: Noah Goldstein , Richard Henderson Cc: Richard Henderson , libc-alpha@sourceware.org References: <20220919195920.956393-1-adhemerval.zanella@linaro.org> <20220919195920.956393-9-adhemerval.zanella@linaro.org> <66dba77d-29b0-a927-da2d-1d839112885b@linaro.org> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/01/23 14:16, Noah Goldstein wrote: > On Tue, Jan 10, 2023 at 8:24 AM Richard Henderson > wrote: >> >> On 1/10/23 06:18, Adhemerval Zanella Netto via Libc-alpha wrote: >>> static __always_inline op_t >>> check_mask (op_t word, uintptr_t s_int) >>> { >>> if (__BYTE_ORDER == __LITTLE_ENDIAN) >>> return word >> (CHAR_BIT * (s_int % sizeof (s_int))); >>> else >>> return word << (CHAR_BIT * (s_int % sizeof (s_int))); >>> } >> >> sizeof(op_t), which is usually the same size, but doesn't have to be. >> > Are we aligning by sizeof(op_t) or sizeof(void *)? > The former then `word_containing` will also need to be changed. > > If the latter then sizeof(s_int) is correct. The read/write operation are being done by op_t, so it makes sense to use op_t on the sizeof. It would really matter on ABIs with op_t different than uintptr_t (mips64n32 and x32).