From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 3A1DC3858D32 for ; Sun, 22 Jan 2023 23:20:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3A1DC3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674429655; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UccA03TMid3Xovmlu6xgqgEHHsrsbH8ue4BqTPaNM8I=; b=ArBxa52XpvBxF94sFB34h7TE3C9lmVKCg+LHTN9PMN7wYNjhtnqnldYJn4lzf5KGncHYp7 ckArmCiORlUR0sI+h7oxqw5m8HT13bDfbDdSJWd5c1LpLITk/G7HRueIsQkvdjInST+mnK hcfSq12CwQV0poaNzxIFaugVwynwgxg= Received: from mail-il1-f197.google.com (mail-il1-f197.google.com [209.85.166.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-270-htotgOVJMoqnabr9ThXNZQ-1; Sun, 22 Jan 2023 18:20:54 -0500 X-MC-Unique: htotgOVJMoqnabr9ThXNZQ-1 Received: by mail-il1-f197.google.com with SMTP id l13-20020a056e0212ed00b00304c6338d79so7385101iln.21 for ; Sun, 22 Jan 2023 15:20:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UccA03TMid3Xovmlu6xgqgEHHsrsbH8ue4BqTPaNM8I=; b=m2YBwQUfWR7VyiU6xKbyks2X8Uhrhn4BEAvg+fWRv4wEw9VCPkeipG0FyGS0cAVHCt Oy+qoK8TsqfLRwZqNCHQgAyE1GNDth6TsvUrmNLN10/I///5arwZVKvwgxFwriKzSQ9U 8EEWAvWD/PEt0B+fbRjX0ETiqRNNir64L0jX1OyesfsJQlLgixjSbO8tPzhSplmDZrE/ m7oE0OTR31QtYsQZiaYYWPkB9dcrIg9c89yYgRYuiS6lwhZ7p+SlOvlX+ki6XHztJVhL vitZMHMbNgX315CgF2GUpjnw4AsBHbIG8U8pddmdzaDEwe7rV6d/lsTQ1Y6us49+hT0o 2wlw== X-Gm-Message-State: AFqh2krXDOE6m5gD+tUmZGuMIxalrf6c7L4ANfTxPmV3GLBn48xCqmHF JzGP9nJ9i4J3DSHFX4x/tviFpWSpIHuEGkxuiP3bF56cUV9p0ATxf1CMdA/CqvTFu/xoRDacIAd MHtsU4NEDPqJ1W2ZHItT3 X-Received: by 2002:a05:6e02:1ba8:b0:30f:629c:e11f with SMTP id n8-20020a056e021ba800b0030f629ce11fmr7603284ili.9.1674429653672; Sun, 22 Jan 2023 15:20:53 -0800 (PST) X-Google-Smtp-Source: AMrXdXsSeWNy6LNhs+/jAIkdRUb23VRyQRi9H00tUbdBPu4BREuX3BRwA5Ulo10gAZWS6LZ65NJ/gw== X-Received: by 2002:a05:6e02:1ba8:b0:30f:629c:e11f with SMTP id n8-20020a056e021ba800b0030f629ce11fmr7603277ili.9.1674429653427; Sun, 22 Jan 2023 15:20:53 -0800 (PST) Received: from [192.168.0.241] (192-0-145-146.cpe.teksavvy.com. [192.0.145.146]) by smtp.gmail.com with ESMTPSA id l10-20020a92d8ca000000b002fc323a2902sm13771514ilo.62.2023.01.22.15.20.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 Jan 2023 15:20:52 -0800 (PST) Message-ID: <9531aa0c-bb05-ab2f-fd48-0751fb6f4393@redhat.com> Date: Sun, 22 Jan 2023 18:20:52 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH] Account for grouping in printf width (bug 23432) To: Florian Weimer , Andreas Schwab via Libc-alpha Cc: Andreas Schwab References: <87pmb8ktdo.fsf@mid.deneb.enyo.de> From: Carlos O'Donell Organization: Red Hat In-Reply-To: <87pmb8ktdo.fsf@mid.deneb.enyo.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/21/23 06:40, Florian Weimer wrote: > * Andreas Schwab via Libc-alpha: > >> diff --git a/stdio-common/Makefile b/stdio-common/Makefile >> index 6e9d104524..b46d932a20 100644 >> --- a/stdio-common/Makefile >> +++ b/stdio-common/Makefile >> @@ -195,6 +195,7 @@ tests := \ >> tst-gets \ >> tst-grouping \ >> tst-grouping2 \ >> + tst-grouping3 \ >> tst-long-dbl-fphex \ >> tst-memstream-string \ >> tst-obprintf \ > > Missing $(gen-locales) dependency. The change itself seems okay, it > seems to align with POSIX. Not sure if this is still possibly to > apply during the freeze. I'd like to avoid a partial fix like this just before we release 2.27. My preference would be to review this more thoroughly, apply it when 2.28 opens, and then backport when we have confidence the issue is resolved. -- Cheers, Carlos.