From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59699 invoked by alias); 20 Feb 2018 12:32:18 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 58586 invoked by uid 89); 20 Feb 2018 12:32:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_SHORT,RCVD_IN_DNSWL_LOW,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=dco X-HELO: mx1.redhat.com Subject: Re: [PATCH v4 1/4] Rename nptl-signals.h to internal-signals.h To: Adhemerval Zanella , libc-alpha@sourceware.org References: <1518439345-6013-1-git-send-email-adhemerval.zanella@linaro.org> From: Florian Weimer Message-ID: <954c3a04-12a5-fdd2-2a0e-c875f6e3d6d9@redhat.com> Date: Tue, 20 Feb 2018 13:00:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1518439345-6013-1-git-send-email-adhemerval.zanella@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2018-02/txt/msg00541.txt.bz2 On 02/12/2018 01:42 PM, Adhemerval Zanella wrote: > This patch renames the nptl-signals.h header to internal-signals.h. > On Linux the definitions and functions are not only NPTL related, but > used for other POSIX definitions as well (for instance SIGTIMER for > posix times, SIGSETXID for id functions, and signal block/restore POSIX timers? > Signed-off-by: Adhemerval Zanella We don't use DCO, but have copyright assignments. > diff --git a/nptl/pthreadP.h b/nptl/pthreadP.h > diff --git a/sysdeps/unix/sysv/linux/nptl-signals.h b/sysdeps/unix/sysv/linux/internal-signals.h > similarity index 89% > rename from sysdeps/unix/sysv/linux/nptl-signals.h > rename to sysdeps/unix/sysv/linux/internal-signals.h > index e789198..e007372 100644 > --- a/sysdeps/unix/sysv/linux/nptl-signals.h > +++ b/sysdeps/unix/sysv/linux/internal-signals.h > @@ -1,4 +1,4 @@ > -/* Special use of signals in NPTL internals. Linux version. > +/* Special use of signals internally. Linux version. > Copyright (C) 2014-2018 Free Software Foundation, Inc. > This file is part of the GNU C Library. > > @@ -16,6 +16,9 @@ > License along with the GNU C Library; if not, see > . */ > > +#ifndef __INTERNAL_SIGNALS_H > +# define __INTERNAL_SIGNALS_H > + > #include > #include > > @@ -35,17 +38,16 @@ > > /* Return is sig is used internally. */ > static inline int > -__nptl_is_internal_signal (int sig) > +__is_internal_signal (int sig) > { > - return (sig == SIGCANCEL) || (sig == SIGTIMER) || (sig == SIGSETXID); > + return (sig == SIGCANCEL) || (sig == SIGSETXID); Should this change be mentioned in the ChangeLog? You could remove the unnecessary parens because you modify this line anyway. > /* Remove internal glibc signal from the mask. */ > static inline void > -__nptl_clear_internal_signals (sigset_t *set) > +__clear_internal_signals (sigset_t *set) > { > __sigdelset (set, SIGCANCEL); > - __sigdelset (set, SIGTIMER); Likewise, should be mentioned in the ChangeLog entry. Looks okay otherwise. Thanks, Florian